Comments (6)
Make a pull request. I can't verify these issues because I don't get warnings.
from gzdoom.
I'm not 100% sure about some of the warnings, so I leave this to cc @alexey-lysiuk who may know it better and can reproduce this.
from gzdoom.
I'll try to fix all of them but I need to check changes with MSVC first.
from gzdoom.
@edward-san, could you please try #190? It fixes most of warnings except those in codegen.cpp
.
I'm not quite sure how this case should be handled in Release configurations, by addition of call to I_Error()
probably.
from gzdoom.
If you're talking about:
/home/edward-san/zdoom/gzdoom/trunk/src/scripting/codegeneration/codegen.cpp:4032:12: warning:
variable 'cast' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
else if (op2.RegType == REGT_INT) cast = CAST_I2S;
^~~~~~~~~~~~~~~~~~~~~~~
/home/edward-san/zdoom/gzdoom/trunk/src/scripting/codegeneration/codegen.cpp:4034:51: note:
uninitialized use occurs here
build->Emit(OP_CAST, strng2.RegNum, op2.RegNum, cast);
^~~~
/home/edward-san/zdoom/gzdoom/trunk/src/scripting/codegeneration/codegen.cpp:4032:8: note:
remove the 'if' if its condition is always true
else if (op2.RegType == REGT_INT) cast = CAST_I2S;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~
/home/edward-san/zdoom/gzdoom/trunk/src/scripting/codegeneration/codegen.cpp:4016:11: note:
initialize the variable 'cast' to silence this warning
int cast;
^
= 0
which still happens, indeed, 'assert' is wrong, although @coelckers made commit e0540c6 which would fix the warning by making the invalid cast converted to CAST_I2F
. It could be done the same for the warning above, but is that really okay?
from gzdoom.
The 'assert' means that this is a case that can only be entered as a programming error. In such a case an assert is enough, this can never happen by passing bogus data to the function.
from gzdoom.
Related Issues (20)
- [Feature] linux XDG Base Directory Specification compliance
- SPF_ACTORSCALE for textured particles HOT 6
- [BUG] [Linux] /opt/gzdoom/gzdoom: symbol lookup error: /opt/gzdoom/libzmusic.so.1: undefined symbol: FLAC__StreamEncoderInitStatusString HOT 4
- [BUG] Launcher checkbox selection frames are too big and overlap with each other.
- [BUG] Node cache and LevelPostProcessor
- [Feature] Amount reduction upon leaving a map for items without INVBAR flag HOT 1
- [BUG] Blur sphere powerup does not affect enemy aim
- [BUG] A 'G' at the start of a script error message
- [BUG] GZD starts stuttering after 30mins HOT 5
- Please let me run my game files by dragging and dropping/double clicking the wad>WITHOUT< needing to go through the file selection menu HOT 4
- [BUG] MBF21: Player takes RadiusDamage from projectile in same splash group HOT 2
- [Feature] Make the Windows autobuild script more complete
- [BUG] Items cannot obtain correct owner.height when being picked up from world HOT 3
- [WEBSITE] Zdoom.org incorrectly lists latest download for GZDoom as v4.12.1 HOT 1
- [BUG] `map` in the middle of a cutscene prevents proper cleanup of cutscene
- [Feature] Introduce a partial config-override lump HOT 7
- [BUG] Hexen the "give" command shouldn't give to the player the morph ovum HOT 2
- [BUG] Boom sector movement limits of +/-32000 cannot be used in GZDoom
- [Feature] AddStatusBarClass (multiple HUDs) HOT 1
- [BUG] CTD on Linux/Haskell/NVidia-Quadro mobile with only Doom2 loaded HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gzdoom.