[Error] module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser' about zeekctl HOT 6 CLOSED

Okay, I will open a pull request tomorrow.

from zeekctl.

Thank you. Not sure how this hasn't come up, seems SafeConfigParser has been deprecated since Python 3.2.

I think just using ConfigParser should be more appropriate. How would you feel about opening a PR?

In [3]: configparser.SafeConfigParser()
<ipython-input-3-980feb9aa499>:1: DeprecationWarning: The SafeConfigParser class has been renamed to ConfigParser in Python 3.2. This alias will be removed in Python 3.12. Use ConfigParser directly instead.
  configparser.SafeConfigParser()
Out[3]: <configparser.SafeConfigParser at 0x7fed340b3580>

from zeekctl.

Might be good to understand why zeekctl didn't show the deprecation warning or why no test caught that.

from zeekctl.

It's pretty funny — the deprecation warning comes from warnings.warn(..., DeprecationWarning), which only shows when happening in __main__ or when PYTHONDEVMODE=1:

$ zeekctl
Hint: Run the zeekctl "deploy" command to get started.

Welcome to ZeekControl 2.5.0-24

Type "help" for help.

[ZeekControl] >

$ PYTHONDEVMODE=1 zeekctl
/home/christian/inst/opt/zeek/lib64/zeek/python/zeekctl/ZeekControl/config.py:389: DeprecationWarning: The SafeConfigParser class has been renamed to ConfigParser in Python 3.2. This alias will be removed in Python 3.12. Use ConfigParser directly instead.
  config = configparser.SafeConfigParser()
Hint: Run the zeekctl "deploy" command to get started.

Welcome to ZeekControl 2.5.0-24

Type "help" for help.

[ZeekControl] >

They didn't yell loud enough for us to notice...

from zeekctl.

Okay, another issue, I guess. In the documentation, it is not explicit mentioned in the documentation of the zeekctl whether we should run zeekctl using sudo command.

Without sudo I am able to access the zeekctl but I am still facing an issue with permissions.

`zeekctl
Error: failed to write file: [Errno 13] Permission denied: '/usr/local/zeek/spool/.zeekctl-config.sh.tmp'

Welcome to ZeekControl 2.5.0-39

Type "help" for help.

[ZeekControl] > deploy
Error: failed to read lock file: [Errno 2] No such file or directory: '/usr/local/zeek/spool/lock'
Error: Unable to get lock
[ZeekControl] > exit
`

Hence, the conclusion:

With RawConfigParser only root can access zeekctl.
With ConfigParser both root and normal user are able access zeekctl but the normal user is facing issues with permissions.

from zeekctl.

Okay, another issue, I guess. In the documentation, it is not explicit mentioned in the documentation of the zeekctl whether we should run zeekctl using sudo command.

Without sudo I am able to access the zeekctl but I am still facing an issue with permissions.

`zeekctl Error: failed to write file: [Errno 13] Permission denied: '/usr/local/zeek/spool/.zeekctl-config.sh.tmp'

Welcome to ZeekControl 2.5.0-39

Type "help" for help.

[ZeekControl] > deploy Error: failed to read lock file: [Errno 2] No such file or directory: '/usr/local/zeek/spool/lock' Error: Unable to get lock [ZeekControl] > exit `

Hence, the conclusion:

With RawConfigParser only root can access zeekctl. With ConfigParser both root and normal user are able access zeekctl but the normal user is facing issues with permissions.

Sorry, I overlooked the FAQ section in the documentation.

from zeekctl.