zeljkoprsa / waterlee-boilerplate Goto Github PK

Right now you manually specify an array of js files to include. This doesn't scale very well and doesn't take full advantage of the bower package manager.

https://github.com/ck86/main-bower-files

Right now it the width is a percentage. It really should be 100% width with a max-width.

https://github.com/zeljkoprsa/waterlee-boilerplate/search?utf8=%E2%9C%93&q=+0rem%3B&type=Code

Why would you use such a brittle way to say "zero"?

All of these statements using 0rem units will not work on IE8.

Take a look at this fiddle for an example:
http://jsfiddle.net/austinpray/nn4c88or/

chrome

IE8

padding-left: 0rem;

and

padding-left: 0;

are exactly the same but the latter works on every browser ever. You have just caused a nightmare for anyone who needs to provide support for IE8.

If my browser support argument doesn't faze you, consider that removing these 64 instances of rem will save almost a whole ~200bytes in stylesheet filesize :)

I'm afraid it is not the good place for such question but i don't know where to ask ...
I want to create waterlee-boilerplate/custom theme. I'm a bit lost when it come to configure skin/frontend/waterlee-boilerplate/custom folder.

What are your recommendations in case of skin/frontend/waterlee-boilerplate/default update please ?

One solution is to copy all folders from waterlee-boilerplate/default and past them in waterlee-boilerplate/custom so we keep the same structure and this way we overwrite styles.css

The norm is to use a <i> tag. If for whatever reason <icon> throws the browser a curveball, the user will not be able to close the off-canvas menu.

Propose we remove all instances if <icon> and replace it with <i>

Examples:
http://fortawesome.github.io/Font-Awesome/examples/
http://stackoverflow.com/questions/11135261/i-tag-for-icons

Edit:
It's also worth noting that the <icon> tag does not exist.

Yikes

There is hardcoded label "My account" (without translation) in app/design/frontend/waterlee-boilerplate/default/template/page/html/header.phtml on line 30.

I'm thinking of launching this on a few sites i work on but the menu is not really the norm so looking for alternatives. I found a few responses on the foundation forums but neither one are ideal so i was just wondering if you had come across anything?

Just a question- i noticed on the demo parent categories you have thumbnails. Are those category thumbnails coded into the theme or have you added them with cms static blocks?

Hello,

I have these error on my product page. I usw 1.7.0.2

Trace:
#0 app/design/frontend/waterlee-boilerplate/default/template/catalog/product/view/type/default.phtml(30): Varien_Object->__call('displayProductS...', Array)
#1 app/design/frontend/waterlee-boilerplate/default/template/catalog/product/view/type/default.phtml(30): Mage_Catalog_Block_Product_View_Type_Simple->displayProductStockStatus()
#2 app/code/core/Mage/Core/Block/Template.php(241): include('/Users/Phillip/...')
#3 app/code/core/Mage/Core/Block/Template.php(272): Mage_Core_Block_Template->fetchView('frontend/waterl...')
#4 app/code/core/Mage/Core/Block/Template.php(286): Mage_Core_Block_Template->renderView()
#5 app/code/core/Mage/Core/Block/Abstract.php(863): Mage_Core_Block_Template->_toHtml()
#6 app/code/core/Mage/Core/Block/Abstract.php(582): Mage_Core_Block_Abstract->toHtml()
#7 app/code/core/Mage/Core/Block/Abstract.php(526): Mage_Core_Block_Abstract->_getChildHtml('product_type_da...', true)
#8 app/design/frontend/waterlee-boilerplate/default/template/catalog/product/view.phtml(72): Mage_Core_Block_Abstract->getChildHtml('product_type_da...')
#9 app/code/core/Mage/Core/Block/Template.php(241): include('/Users/Phillip/...')
#10 app/code/core/Mage/Core/Block/Template.php(272): Mage_Core_Block_Template->fetchView('frontend/waterl...')
#11 app/code/core/Mage/Core/Block/Template.php(286): Mage_Core_Block_Template->renderView()
#12 app/code/core/Mage/Core/Block/Abstract.php(863): Mage_Core_Block_Template->_toHtml()
#13 app/code/core/Mage/Core/Block/Text/List.php(43): Mage_Core_Block_Abstract->toHtml()
#14 app/code/core/Mage/Core/Block/Abstract.php(863): Mage_Core_Block_Text_List->_toHtml()
#15 app/code/core/Mage/Core/Block/Abstract.php(582): Mage_Core_Block_Abstract->toHtml()
#16 app/code/core/Mage/Core/Block/Abstract.php(526): Mage_Core_Block_Abstract->_getChildHtml('content', true)
#17 app/design/frontend/waterlee-boilerplate/default/template/page/2columns-right.phtml(53): Mage_Core_Block_Abstract->getChildHtml('content')
#18 app/code/core/Mage/Core/Block/Template.php(241): include('/Users/Phillip/...')
#19 app/code/core/Mage/Core/Block/Template.php(272): Mage_Core_Block_Template->fetchView('frontend/waterl...')
#20 app/code/core/Mage/Core/Block/Template.php(286): Mage_Core_Block_Template->renderView()
#21 app/code/core/Mage/Core/Block/Abstract.php(863): Mage_Core_Block_Template->_toHtml()
#22 app/code/core/Mage/Core/Model/Layout.php(555): Mage_Core_Block_Abstract->toHtml()
#23 app/code/core/Mage/Core/Controller/Varien/Action.php(390): Mage_Core_Model_Layout->getOutput()
#24 app/code/core/Mage/Cms/Helper/Page.php(137): Mage_Core_Controller_Varien_Action->renderLayout()
#25 app/code/core/Mage/Cms/Helper/Page.php(52): Mage_Cms_Helper_Page->_renderPage(Object(Mage_Cms_IndexController), 'no-route')
#26 app/code/core/Mage/Cms/controllers/IndexController.php(75): Mage_Cms_Helper_Page->renderPage(Object(Mage_Cms_IndexController), 'no-route')
#27 app/code/core/Mage/Core/Controller/Varien/Action.php(419): Mage_Cms_IndexController->noRouteAction()
#28 app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(250): Mage_Core_Controller_Varien_Action->dispatch('noRoute')
#29 app/code/core/Mage/Core/Controller/Varien/Front.php(176): Mage_Core_Controller_Varien_Router_Standard->match(Object(Mage_Core_Controller_Request_Http))
#30 app/code/core/Mage/Core/Model/App.php(354): Mage_Core_Controller_Varien_Front->dispatch()
#31 app/Mage.php(683): Mage_Core_Model_App->run(Array)
#32 index.php(87): Mage::run('', 'store')
#33 {main}

The right column have spacing issue.
I add the class "row" to the header.phtml on line: 75.

Hi,
I really think this is a fantastic boilerplate which is why i would like to use it with my latest project but i seem to be having problems. I'm familiar with bower and gulp so i do have some experience with these things but compass is all new to me. I'm running ruby 2.1.2 with all default required gems and receiving no errors. Installing the theme as standard (without running composer) the theme looks okay with just a broken menu but when i run "#compass watch" from "/skin/frontend/waterlee-boilerplate/default" (i presume this is the correct place to run it?) after compiling the css style is completely broken. Please see link for broken state - http://goo.gl/651hwD I cant figure out if this is my particular setup or something else? Where would you start with debugging this- sorry i'm not very experienced with compass but would really appreciate some help.

This is probably somewhere in the inuit documentation but i couldn't find it..
What would would be the correct way to align the "Røyk" heading with the 6 item(s) text?

Using negative margins on .toolbar?

Do any of you guys use irc? where do you hang out? :)

Looks like there is a Gemfile.lock but no Gemfile. Any reason for this?

Hey,

I wonder if the foundation version of waterlee will be discontinued due to inuit implementation?
If so I'd like to ask the users if there is sound demand for future foundation support.

I'm currently working on a foundation based magento site and could imagine to contribute an updated and improved version of waterlee foundation. We may split things up to maintain the choice which version to use without relying on old code.
[edit:] also concerning a foundation 6 version in the future

2.0 without foundation suggests that foundation is no longer wished on waterlee.

Thanks for the awesome work so far! 👍 This project really opened my eyes in several ways.

Cheers

If there are more than 9 products, the pagination is not shown.

Thanks for the boilerplate !
Maybe this ticket is related to #40. Sorry if it's the case.
The problem is about top cart hover on desktop view.
The solution seems to be to edit data-dropdown and id as it is shown on the picture.

Thanks for great boilerplate!
However, I noticed that html 5 footer tag is not used.

Are you guys getting this as well?

(this is latest master with no edits)

Hi!

Your modman is not correct.
It creates the following folder structure after install:

/app/design/frontend/waterlee-boilerplate/waterlee-boilerplate/default/....

app/design/frontend/* app/design/frontend/waterlee-boilerplate

should be

app/design/frontend/waterlee-boilerplate app/design/frontend/waterlee-boilerplate

Thanks.

I think EasyTabs should be removed, e.g. now the latest version is 2.3.0 and waterlee's version is 1.2.2

But, we could provide the sass file in a /thirdparty folder?

I hope i can start making some PR's next week.

It is nice image handling in waterlee-boilerplate. But I want default magento zoom-in-out functionality and I don't know if I am right but image resizing script which work while we resize screen would retire it by resizing image...can we make it possible to work with as normal and as image resizing be still there ??

Congratulations, great job in this boilerplate.
I work with magento for some years, but im a beginner with Sass/Compass. To style this template, I need to edit the SCSS file, compile and upload to /css or edit directly the .CSS?

Hello,
I have this magento admin theme https://www.bubbleshop.net/fr/magento-admin-theme.html?___from_store=default#demo
on wich I would like to integrate Foundation 5.4.5 by ZURB..
Could you please tell me how to do,
regards.

Hey guys,

What is the story with the medium sizes for the top bar? By default they look like this:
(added black background for emphasis)

Why is this? Shouldn't it look like this?

Hi, great work. Looks good.

When are you planning to go beta?

And some questions.

• Would this work with an ajax addto cart extension?
• And we would also like to show all our products on the front page in a grid fashion, how can this be done?

thanks, Sean

Hello Guys,

Thanks for coming here and helping me out on this issue, which may others might also be facing.

I have developed my website on old version of Waterlee Boiler plate of Aug 13 2014
I just noticed that offcanvas for cart is not working in ipad, even in default theme on Aug13
I do not have an option to upgrade, please suggest some solution to me.

Thanks,
Mrugesh

https://github.com/zeljkoprsa/waterlee-boilerplate/search?utf8=%E2%9C%93&q=costum&type=Code

Collapsing the Nav when the screen size is less than 767px causes the search bar to be inaccessible, and instead opens the login link drop down when clicked.

Hello,

I've installed your theme to a fresh magento 1.8.1 install, I haev activated the package in magento admin and cache is disabled.

It doesn't seem to be attaching your CSS but the default magento one instead.

Here is the URL: http://dev.goldstandardnutrition.co.uk/index.php/

I hope you can help. :) Your boilerplate is very promising.

Notice: Use of undefined constant php - assumed 'php' on cart page when developer mode enabled. Needs a space between <?php tag and comment on line 41.

https://github.com/zeljkoprsa/waterlee-boilerplate/search?utf8=%E2%9C%93&q=url%28%22http%3A%2F%2Fwaterlee.jakesharp.co

Not that I don't appreciate you donating your bandwidth for free to my project, but this should definitely not be linking to your server.

When compiling the sass files using compass.app I receive the following error:

/*
Syntax error: Undefined variable: "$h5-font-size".
on line 2 of /Volumes/_//**/**_/skin/frontend/waterlee-boilerplate/default/scss/custom/catalog-page.scss

1: /Volumes/_//**/**_/skin/frontend/waterlee-boilerplate/default/scss/custom/catalog-page.scss

Even on the repo the error is present. Not a clue why because the variables used in all other sass files work fine, just not in this one.

Error can be viewed here:
https://github.com/zeljkoprsa/waterlee-boilerplate/blob/master/skin/frontend/waterlee-boilerplate/default/css/custom/catalog-page.css

Any ideas?

Hello!

First of all, I am sorry for opening this issue cause it is not since interchange has not been implemented yet. So this is really a question - have you been successful with interchange, cause in my store it does not work with prototype and for some reason just removes the img tag altogether.

I would appreciate any help on this topic!

Thank you!

data-topbar needs to be added to line 52 of header.phtml. Without it, the navigation menu (dropdown and mobile toggle) was not working.

<nav class="top-bar" data-topbar>

Hi,

Great work on waterlee, thanks @zeljkoprsa, and all contributers to this repository.

I found style issues on frontend when I use magento native "calendar.js" with "calendar-win2k-1.css" on product page.

Calendar styles conflict with styles.css please see attachments. First screenshot is without styles.css and second screenshot is with styles.css which shows conflicts. I was unable to select date and styles are also messed up.

I have tried to place calendar styles after styles.css but it doesn't work as well. It works when I remove styles.css which shows in screenshot.

Please help on this issue. what should be quick fix for this ??

Thanks

I received a few complaints after launching my new theme that the menu was too hard to use. So I modified it a bit to use accordions for subcategories and links to the category on top level categories.

You can check out the modified files here:
https://github.com/dmto/waterlee-boilerplate/blob/master/app/code/community/JakeSharp/Waterlee/Block/Topmenu.php

https://github.com/dmto/waterlee-boilerplate/blob/master/skin/frontend/waterlee-boilerplate/default/bower_components/foundation/scss/custom/_header.scss

I think this would be a great addition to the boilerplate if someone could improve upon it.

Create a composer.json for Composer-Integration

the path to jquery in the local.xml needs to be changed from:

bower_components/jquery/jquery.min.js

to:

bower_components/jquery/dist/jquery.min.js

if you are going to update foundation

Hi

I was trying to install waterlee using "composer" I have faced this error.

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package magento-hackathon/magento-composer-installer could not be found in any version, there may be a typo in the package name.