clearByTags in Filesystem adapter crashes when .tag file deleted during GlobIterator loop about zend-cache HOT 7 CLOSED

This issue probably also occurs in the other clearBy* methods where the GlobIterator is used as well.

from zend-cache.

hi @skors - thanks for your bug report!

This one is really hard to solve and test and it can happen on every function looping over different items.

A simple file_exists doesn't fully solve the issue as first the result of file_exists will be cached by PHP itself and calling clear_stat_cache would totally degree performance and secondly there is still a possible race condition between file_exists and reading the file.

A better solution would be to catch the error on reading the file and afterwords check if the reason of the error is a missing file. Than ignore the error in this case. For removing files there is already a the method Filesystem::unlink that works this way.

from zend-cache.

@marc-mabe okay. I'll try to work on it and maybe you can take a review if i have understood you correctly

from zend-cache.

Nice thanks

from zend-cache.

@skors any news ?

from zend-cache.

@marc-mabe yes, just give me a few days

from zend-cache.

@marc-mabe please see bugfix/clear-by-tag_on_filesystem-storage branch at skors/zend-cache
https://github.com/skors/zend-cache/tree/bugfix/clear-by-tag_on_filesystem-storage

I've added tests which can reproduce the error now

from zend-cache.