Comments (4)
@remicollet thanks for this great idea!
A few questions:
When control enters apcu_entry() the lock for the cache is acquired exclusively, it is released when control leaves apcu_entry()
- Does that mean the lock for the exact same entry/key or are there other entries/keys effected, too?
- "exclusively" means other processes reading and writing the same key are waiting for the callback to finish.
- Are other writes waiting for the lock to finish and afterwards overwrite the entry? Or are concurrent writes directly blocked (return false)? Does that makes sense?
- -> This could happen if you have different logic writing the same entry like cache warm-up.
The only APCu function that can be called safely by generator is apcu_entry().
For me it means that the result of the callback will be automatically written to cache so your implementation would not be correct as it doesn't store the result. Or should the generator function take care or writing the valid result into cache? This would be more flexible because of some generator function doesn't throw exceptions or also could generate more than one entries.
Marc
from zend-cache.
it doesn't store the result.
Fixed
from zend-cache.
For APCU implementation, see https://github.com/krakjoe/apcu/blob/master/apc_cache.c#L1807
The idea is that the lock is set before the get, so this ensure the callback/store will be execute only once, and then used by other process.
I think this make sense expecially when the cached value require very long computation.
from zend-cache.
This repository has been closed and moved to laminas/laminas-cache; a new issue has been opened at laminas/laminas-cache#11.
from zend-cache.
Related Issues (20)
- Why make Zend\Cache\Storage\Adapter\Filesystem only support string data types? HOT 2
- Add PHP 7.2 support, drop HHVM HOT 1
- ZF2 Memcached PHP7 backward incompatible change HOT 2
- Invalid prototype (PHP 7.2) HOT 10
- StorageFactory Not Reading "cache_dir" Setting HOT 2
- memcached doesn't work with plugin phpSerialize HOT 2
- When 2.8 will be released? HOT 10
- PSR-16 support: serialization using plugin HOT 2
- PSR-16 support: clear by namespace when appropriate HOT 1
- PSR-16 support: prevent concurrent regression when calling delete HOT 3
- ZendCache 2.8 sets $success on getItem if there is a null response HOT 1
- PSR-16 and blackhole not possible HOT 6
- Missing docs about APCU storage HOT 1
- SimpleCacheDecorator and providesPerItemTtl leads undocumented behaviors HOT 4
- StorageInterface::hasItem issue with ext-redis 4.0.1+ HOT 1
- [ZF3] Remove StorageFactory and PatternFactory HOT 2
- Make it possible to decorate cache adapters with PSR6/PSR16 decorators through configuration HOT 1
- Typo in variable for ExtMongoDbResourceManager adapter makes passing db a no-op HOT 3
- SimpleCacheDecorator Cache gets deleted after creation
- Redis::delete is deprecated HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zend-cache.