<input type="checkbox" id="" disabled=""

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

<a class="user-mention notranslate" data-hovercard-type="organization" data-hovercard-

This is my php version: <div class="snippet-clipboard-content notranslate position

Here's the dockerfile. I was able to reproduce: <div class="snippet-clipboard-cont

Got segfault on 7.3 too, traced it to this part: <div class="Box

Thanks for reproducing <a class="user-mention notranslate" data-hovercard-type="user"

Segfault in PHP 7.3.0 when instantiating HtmlResponse in Built-in Web Server,about zendframework/zend-diactoros

Comments (13)

michalbundyra commented on August 29, 2024 1

@malukenho Ah! You have edited your original comment :)

But yes - it works for me as well on PHP 7.3.0:

PHP 7.3.0-1+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Dec  6 2018 20:24:55) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.0-1+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.7.0beta1, Copyright (c) 2002-2018, by Derick Rethans

from zend-diactoros.

malukenho commented on August 29, 2024

@mnavarrocarter Hello!
Can you check your php version?
I tried php -S 0.0.0.0:8000 -t . and it worked fine on version 7.2 and 7.3.
It's very common to have different php versions running on CLI and web server, are you sure that isn't the problem?

from zend-diactoros.

michalbundyra commented on August 29, 2024

@malukenho as the autor says in the subject - PHP 7.3.0 :) I'm just about to check it

from zend-diactoros.

malukenho commented on August 29, 2024

@webimpress yes. I just checked on 7.3 as stated above.

PHP 7.3.0 (cli) (built: Dec  7 2018 11:00:11) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.0, Copyright (c) 1999-2018, by Zend Technologies

from zend-diactoros.

mnavarrocarter commented on August 29, 2024

This is my php version:

PHP 7.3.0-2 (cli) (built: Dec 17 2018 09:51:53) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.0-2, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.7.0beta1, Copyright (c) 2002-2018, by Derick Rethans

Also, here is php -i output.

php -i output

Maybe I can build a docker container that replicates the issue. Could that be useful?

from zend-diactoros.

weierophinney commented on August 29, 2024

Maybe I can build a docker container that replicates the issue. Could that be useful?

Yes, because we've had two people indicate they cannot reproduce.

from zend-diactoros.

mnavarrocarter commented on August 29, 2024

Here's the dockerfile. I was able to reproduce:

FROM debian:buster

RUN apt update && apt install php-common php-mysql php-mbstring php-fpm php-xdebug php-zip php-json php-xml wget -y

WORKDIR /root

RUN wget https://github.com/composer/composer/releases/download/1.8.0/composer.phar

RUN php composer.phar require zendframework/zend-diactoros

RUN echo "<?php require_once 'vendor/autoload.php'; new \Zend\Diactoros\Response\HtmlResponse('Test');" > index.php

EXPOSE 8000

CMD php -S 0.0.0.0:8000 -t .

Then: docker build .

Once built: docker run -p <localport>:8000 <imageid>

from zend-diactoros.

weierophinney commented on August 29, 2024

No; I just edited your comment to fold the contents of the `php -i` output so that readers don't need to scroll through the entire thing to read further comments. On Jan 5, 2019 7:58 PM, "bluebaroncanada" <[email protected]> wrote: Is this solved now? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#343 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABlVySTXMnki7BxR838Z7BUEVGtFvTlks5vAVg9gaJpZM4ZaQKS> .

from zend-diactoros.

anVlad11 commented on August 29, 2024

Got segfault on 7.3 too, traced it to this part:

zend-diactoros/src/Stream.php

Lines 178 to 204 in d966a8a

 /** 

  * {@inheritdoc} 

  */ 

 public function seek($offset, $whence = SEEK_SET) : void 

 { 

 if (! $this->resource) { 

 throw Exception\UnseekableStreamException::dueToMissingResource(); 

 } 

 if (! $this->isSeekable()) { 

 throw Exception\UnseekableStreamException::dueToConfiguration(); 

 } 

 $result = fseek($this->resource, $offset, $whence); 

 if (0 !== $result) { 

 throw Exception\UnseekableStreamException::dueToPhpError(); 

 } 

 } 

 /** 

  * {@inheritdoc} 

  */ 

 public function rewind() : void 

 { 

 $this->seek(0); 

 }

When emitting response, $this->seek is called with one argument, but $whence somehow becomes NULL (despite SEEK_SET being 0). fseek() expects int as third argument and throws an exception.

PHP 7.2, same config - everything works fine.

anvlad11@server:~$ php7.3 -v
PHP 7.3.0-2+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Dec 17 2018 09:22:47) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.0-dev, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.3.0-2+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.7.0beta1, Copyright (c) 2002-2018, by Derick Rethans

anvlad11@server:~$ php7.2 -v
PHP 7.2.13-1+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Dec  7 2018 08:07:36) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.2.13-1+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.6.1, Copyright (c) 2002-2018, by Derick Rethans

from zend-diactoros.

mnavarrocarter commented on August 29, 2024

Thanks for reproducing @anVlad11 ! Now I'm more inclined to believe this is a bug on Php.

from zend-diactoros.

weierophinney commented on August 29, 2024

I'm thinking it's either a bug in PHP, or in the interaction of the output stream emitted by the Docker container.

I can take reproduce using the container above. However, when I use my local PHP 7.3.0 binary and follow the same steps (composer install + php index.php), no segmentation fault occurs. Considering no rewind() or seek() operations occur when first creating the HtmlResponse, nor when destructing it (or its related stream), coupled with the fact that this is abnormal usage (creating the instance and doing nothing with it), I have no idea how or where that seek() call could even happen. As such, I'm going to chalk it up as an edge case for now, and close the issue. If you can find a way to reliably reproduce it with a standard binary, we can re-open.

from zend-diactoros.

anVlad11 commented on August 29, 2024

I've been able to reproduce this using php7.3-fpm with zend-expressive-skeleton application without any modifications to it or php configuration. I could provide any server configuration information, if needed.

from zend-diactoros.

mnavarrocarter commented on August 29, 2024

Thanks @weierophinney. It may be Docker. I'm doing some testing on my own. :)

from zend-diactoros.

Segfault in PHP 7.3.0 when instantiating HtmlResponse in Built-in Web Server about zend-diactoros HOT 13 CLOSED

Comments (13)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	/**
	* {@inheritdoc}
	*/
	public function seek($offset, $whence = SEEK_SET) : void
	{
	if (! $this->resource) {
	throw Exception\UnseekableStreamException::dueToMissingResource();
	}

	if (! $this->isSeekable()) {
	throw Exception\UnseekableStreamException::dueToConfiguration();
	}

	$result = fseek($this->resource, $offset, $whence);

	if (0 !== $result) {
	throw Exception\UnseekableStreamException::dueToPhpError();
	}
	}

	/**
	* {@inheritdoc}
	*/
	public function rewind() : void
	{
	$this->seek(0);
	}