Giter VIP home page Giter VIP logo

Comments (4)

driesvints avatar driesvints commented on August 29, 2024 1

My 2 cents on the issue: I wouldn't revert the change if it was a bug fix to comply to PSR-7 more. Implementing libraries were relying on faulty behavior like @weierophinney noted.

from zend-diactoros.

weierophinney avatar weierophinney commented on August 29, 2024

This is problematic to back out of the 1.8 series of zend-diactoros.

The patch that introduced it, #325, did so in order to make the library comply correctly with the PSR-7 specification. Essentially, by not checking it, we had introduced a bug in our implementation.

That also means that, on the flip side, if you were relying on that behavior previously, you were relying on a bug.

If laravel/passport requires the original behavior, one solution is to do the following in your composer.json:

"require": {
    "zendframework/zend-diactoros": "~1.0"
},
"conflict": {
    "zendframework/zend-diactoros": "1.8.6"
}

Pinging @Ocramius — thoughts on reverting #325 for the 1.8 series?

from zend-diactoros.

driesvints avatar driesvints commented on August 29, 2024

Hey everyone. Seems that the problem lies with Symfony HttpFoundation's ServerBag class and not with Passport itself. See laravel/passport#992

from zend-diactoros.

weierophinney avatar weierophinney commented on August 29, 2024

This repository has been closed and moved to laminas/laminas-diactoros; a new issue has been opened at laminas/laminas-diactoros#8.

from zend-diactoros.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.