zengfenfei / ringcentral-js-client Goto Github PK

Not sure if it's necessary for JS since it's not static compiled language. But TS is. So it is good to have this features.

Here is how models for pubnub implemented in C# and Swift:

https://github.com/ringcentral/ringcentral-csharp-client#subscription
https://github.com/tylerlong/ringcentral-swift-client#pubnub-subscription
https://github.com/ringcentral/ringcentral-csharp-client/blob/master/RingCentral/Special.cs#L91
https://github.com/tylerlong/ringcentral-swift-client/blob/master/Source/Special.swift#L120

Solutions:

1. Delay request before rate limit exceeded(x-rate-limit-remaining is 0)
2. Resend the request after retry-after when rate limit exceeds.
3. Throw error immediately

The RingCentral SMS API doc needs the from property to be populated.

The current documentation results in the following error:

• 400 (Bad Request)
• Fail to send sms Error: Parameter [from] value is invalid

To resolve this, add the from property as shown:

client.account().extension().sms().post({
    to: [{ phoneNumber: "911" }],
    from: { phoneNumber: "{yourSmsNumber}" }, // add this `from` property
    text: "Sms content"
}).then(function (messageInfo) {
    console.log("Sms sent successfully", messageInfo);
}).catch(function (e) {
    console.error("Fail to send sms", e);
});

More information is available in the docs:

• https://github.com/ringcentral/ringcentral-api-docs/blob/master/docs/messages_sms-and-pager.md

https://github.com/zengfenfei/ringcentral-js-client/blob/master/src/generated/url-segments/ServiceInfo.ts

Should support both meetings service-info and account service-info.

Currently /restapi/v1.0/account/{accountId}/service-info is not supported.

Please add code coverage support via Coveralls. Coverage should exceed 90%.

Examples include:

• AWS
  • https://github.com/aws/aws-sdk-js
  • https://coveralls.io/github/aws/aws-sdk-js
• Facebook
  • https://github.com/facebook/react
  • https://coveralls.io/github/facebook/react

Make js-sdk as a peerDependency instead of dependency so that users can specify his own version of js-sdk.