zeraien / django-url-framework Goto Github PK

The readme file is pretty comprehensive, but does not quite cover everything.

Please help upgrade the package to be compatible with Django 2.2 and Python3

ActionController is extended by user controllers but also contains all the inner workings of the framework. In order to make it easier to see what methods are useful for a subclass and which methods are just turning the gears, I'll move all the functionality into a separate class or classes. The framework is long overdue for a refactoring anyway.

in setup.py

In controller.py line #91 is commented out -- this removes the ability to have /cart/(\d+) auto-generated. What was the problem it caused? I uncommented it and it seemed to work.

Right now you need to specify action settings as function parameters, like so:

def submit(self, request):
    return {}
submit.allowed_methods = ['POST']

I'm thinking it might be smarter to do something like this:

from django_url_framework.decorators import post
@post
def submit(self, request):
    return {}

Which would limit it to POST only. Adding multiple decorators can limit it to multiple methods.

If you attempt to use self._go, with an invalid action, the error message is not correct.
Instead you get:
AttributeError: 'InvalidActionError' object has no attribute 'message'

** Example code to explain the scenario**
Specifically the functions with objects.

def edit(self, request, id = None):
  return HttpResponse('edit')

/cart/edit/id/ --> working fine

@login_required
def edit2(self, request, id = None):
  return HttpResponse('index2')

/cart/edit2/id/ --> 404 error