Giter VIP home page Giter VIP logo

ascii-art-2021's Introduction

zero-to-mastery

Zero to Mastery Open Source

Screenshot

ascii-art-2021's People

Contributors

acidminded95 avatar bobomatic avatar ckosa avatar deepaksaipendyala avatar dhakshinesh avatar dylanbuchi avatar dysrhythmic avatar insidiae avatar jkagawa avatar karthiknatarajan-27558 avatar mattcsmith avatar mpbasto avatar mpetrushanskyi avatar mrai-rohan avatar ndeoligence avatar nisnym avatar programmer-rd-ai avatar rafiaquddoos avatar sachdevavaibhav avatar siddharth329 avatar usergr avatar virtual avatar yashraj2003e avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ascii-art-2021's Issues

Web app: **Download as png file** always saves default pic.

Expected: Downloading should always save the displayed ascii.
To replicate:

  1. Click on Choose File and select a different supported file.
  2. Click Submit. The selected image should be shown below in ASCII.
  3. Press Download as png file and save file locally.
  4. Open the saved PNG image.

The saved image has the default image - ZTM logo - instead of the new image.

Add support for web app

  • Add features for web app where users can upload image and get ascii art, even download the output file for the same
  • Ping down to get assigned for this enhancement.

Add testing

Add automated testing to ensure it works as intended after changes are made

Image path argument input is not being processed

Whenever I run python3 ./community_version.py -i image_path, the program still ask for the image path. Inputting the path again does not resolve the problem. It hangs in there asking for a new input.
Screen Shot 2021-10-20 at 11 00 35 PM

Anyone know how to properly run the program?

Add logging

Add logging to assist with debugging. Here is a blog on logging for those who have never done it before.

Discussion Tab

More than adding issues it would be better to have a discussion tab.

With best regards,

Deploy ?

Should I deploy this project or is zero-to-mastery going to host this project ?

Add dependency manager

I'd like to use Poetry for this.
But I'll add a requirements file - for anyone unfamiliar, so it's beginner-friendly.

But Poetry should help with packaging, since some GUI implementations might wanna add this as a dependency.

Animation of The ascii

Animation of The ASCII.

I think that would look really nice and it would be much better than downloading this.

With best regards,
Ranuga

Documentation needed for getting started with app.py

I added default directories to the keyfile for both gui.py and app.py.
I was able to successfully test gui.py.

However, I need additional guidance/documentation on how to correctly initialize the webapp for app.py. Even when running from master I encounter errors due to not having the root directory './webapp/*'. I used both flask run and python app.py to initialize the webapp. Are there other steps necessary for the webapp to initialize the default directory?

Update(2021-10-09_21:05ct): I manually created the directories ./webapp/* and was able to successfully execute the app.

Originally posted by @ckosa in #42 (comment)

How can I help for this project?

How can I help with this project?

I would recommend adding a project tab for this repo so we can see what is to do and what is currently doing and what is done.

I think it would be really easy for new contributors.

With best regards,
Ranuga

Add CLI args processing

The code currently always produces an ascii file when you run it. Which is not cool if you just want it printed out. In fact, there's no way to stop the file from being written to disk. And other will add more functionality soon.

We need a way to tell the program what to do when calling it. This is usually done using command-line arguments. (Like how you can call python like this: python -m venv /path/to/venv

We need a way for our program to handle the same type of input. Something like: ./community-version.py --image example/ztm-logo.png --output ztm-logo.txt

That would tell it to open the ztm-logo.png and write the ascii to ztm-logo.txt. When run without --output, maybe it should just print to stdout

Outfile Bug

When we choose to out file the ascii image in a txt file the program creates a txt but still show the image in console.
Can I fix this issue?
Screenshot (463)_LI

Hosting

Hosting

I can host this project in Heroku if we need to.

Should we host this now or should we wait for some more time?

With best regards,
Ranuga

module

  • modularizing the code will makes it easy to import and use in other programs.
  • Even keeping in PyPi.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.