zhaowenlan1779 / svdsketch.jl Goto Github PK

This package suffers from severe type instability from some LinearAlgebra function.
Firstly, it seems that eigen is always performed on a symmetric matrix (A * A'), you should use eigen(Hermitian(x)).
Secondly, A' (adjoint) returns a different type instead of Matrix{Float64}, you need to use function barrier to isolate the type instability.
Thirdly, alpha in function _svdsketch is initialized with 0, an integer. Then it's assigned with a floating number. You should initialize it with a floating number.
These errors are found by SimpleTypeChecker, a fortran-style static type checker for Julia.

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!