zikula / extensionlibrary Goto Github PK

View Code? Open in Web Editor NEW

6.0 6.0 0.0 3.47 MB

Browsable Zikula Extensions library

PHP 77.05% CSS 0.11% JavaScript 3.36% Smarty 19.48%

extensionlibrary's People

Contributors

Stargazers

Watchers

extensionlibrary's Issues

Add option to blocks to add class btn-block

Current:

With btn-block:

This needs to be an option as the buttons on the startpage should not have this class.

Vendor view now working correctly

see http://zikula.org/library/v/christian-flach (should be only Christian Flach's extensions)

GitHub API: Prepare for upcoming organization permissions changes

http://ift.tt/1tL8W95 January 07, 2015 at 01:00AM

@cmfcmf Check if that matters for the ExtensionLibrary.

interesting DI idea

https://groups.google.com/d/msg/doctrine-user/ZLttjX1ZTPQ/5GgM8_JDZmwJ

I don't relly like the usage of strings when the same value is used all over the project.
To write 100x 'MyNamespace\Model\MyEntity' is quite bad if you want to refactor things some times.

response:

Declare the entity classes in config files, inject the repositories with DI

parameters:
    my.entity.class: MyNamespace\MyEntity

service:
    my.repository:
        class: MyRepo
        factory_service: doctrine.orm.entity_manager
        factory_method: getRepository
        arguments:
            - %my.entity.class%

this could maybe be something to try (in any project, I just decided to post it here)

Moving release assets from Jenkins to GitHub takes too long for GitHub

This does NOT mean anything is failing on the Zikula side. However we should send the response BEFORE moving the assets to avoid timeout messages at GitHub. This could somehow be handled by a kernel.terminate event listener.

small layout problem

My Todo list

split release blocks
add option to auto-create news post on new release
improve viewreleases page
- add download links to modals
- add download links to table
add jenkins-endpoint to be notified when a jenkins build has finished

Check if admin:repo_hook scope is really necessary

Check if this commit was necessary: 7175fcc

use github's 'secret' to authenticate webhook

https://developer.github.com/webhooks/securing/

move some vendors to plugins

We should consider moving the OAuth and GithubApi vendors to independent plugins so that they could be used by other extensions. possibly other vendors as well.

@cmfcmf

React to Upcoming GitHub Api changes

https://developer.github.com/changes/2014-12-08-organization-permissions-api-preview/

Allow to add tags <= the latest tag

Example: Latest tag is 2.5, I'd like to add a tag 1.7 for my 1.x legacy branch. This is currently denied.

use core event-dispatcher?

If possible, use the core's event-dispatcher instead of including own in /vendor

GitHub API: New guide: Discovering resources for a user

GitHub announced something at their developer blog at January 08, 2015 at 01:00AM. @cmfcmf Check if that matters for the ExtensionLibrary.

EL doesn't work locally

locally - after I upgraded to 1.0.10 this is what I get. (Also tried reinstalling)

maybe it doesn't matter, but something is wrong. it seems like it should run locally.

GitHub API: New Releases API methods

GitHub announced something at their developer blog at February 18, 2015 at 01:00AM. @cmfcmf Check if that matters for the ExtensionLibrary.

GitHub API: An integrator's guide to organization application policies

GitHub announced something at their developer blog at January 19, 2015 at 01:00AM. @cmfcmf Check if that matters for the ExtensionLibrary.

use monolog

use monolog for logging instead of fopen() fwrite() etc

example:

use Monolog\Logger;
use Monolog\Handler\StreamHandler;

$logger = new Logger('mailer');
$logger->pushHandler(new StreamHandler('app/logs/mailer.log', Logger::INFO));
$logger->addError("Could not send message to: $emailList :: " . $message->toString());

Fetch GitHub IP-Adresses dynamically

https://api.github.com/meta

update screenshots and docs on migration to actual domain

current screenshots and docs refer to ntq subdomain. This must be updated after migration.

dynamically get routes

It isn't good to hardcode the route into the module. Have to "lookup" the route instead. This might be difficult/impossible with the doc files (.md)

cc: @cmfcmf

Need sorting and paging in main view

soon, this page will become unwieldy - it will need a limit on display, sorting and paging

Check if changes to deployments API need to be addressed in the EL

See https://developer.github.com/changes/2014-10-21-deployment-webhook-payload-changes/.

Needs to be done until the 5th of November.

Consider moving all vendor information from the manifest file to zikula.org

Users could authenticate via GitHub OAuth and change vendor information centrally at http://zikula.org.

Improve Layout on small screens

filter not working

the filter (type or version) doesn't appear to be working at zikula.org

Things to do

@cmfcmf

trim content going to log
create manifest validation mechanism for users to test their manifest
change verification system to be version based instead of vendor based
create workflow for admin to verify/deny a version
move versions to a tab and add comments and rating to another tab
add filter dropdown for core version (#10) and ext type
add smarty page caching

Edit by @cmfcmf

blow up the database 💣 ❗ 💥 🎉 😃

Garbage collect OAuth tokens if session is destroyed.

Polish dependencies

Quote from the docs:

Dependencies are specified with a simple hash of name, type and version. The name should be the repository name and not the title. The type must be as defined in extension type above. Version uses the same definition as core compatibility. See Specifying Versions.

That means:

"dependencies": [
  {
    "name": "TestModule",
    "type": "m",
    "version": "~1"
  }
]

However, the repository name is not unique. I propose to use the name from the composer.json file (e.g. cmfcmf/test-module) instead.

Additionally, the core dependency is currently placed in compatibility. As this is a dependency too, I suggest to move it into the dependencies array:

"dependencies": {
  "cmfcmf/test-module": "~1",
  "zikula/core": ">=1.3.5 <1.5"
}

Opinions?

user validation errors incomplete

there is still an issue on validation where the offending fields are not identified in the error display, but the validation works properly. This seems to be a vendor issue, but not sure.

Add 'delete tag' admin function to the admin tab

Need some way to remove stuff from the db. Seems like the best option is to add delete options in the admin tab for each extension.

Auto-create failed

I was trying to add zikula-modules/Scribite but it failed:

[1] Github\Exception\RuntimeException: Not Found
at n/a
in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/knplabs/github-api/lib/Github/HttpClient/HttpClient.php line 146

at Github\HttpClient\HttpClient->request('repos///hooks', '{&quot;name&quot;:&quot;web&quot;,&quot;active&quot;:true,&quot;events&quot;:[&quot;push&quot;],&quot;config&quot;:{&quot;url&quot;:&quot;http:\/\/zikula.org\/library\/webhook&quot;,&quot;secret&quot;:&quot;&quot;,&quot;content_type&quot;:&quot;json&quot;}}', 'POST', array())
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/knplabs/github-api/lib/Github/HttpClient/HttpClient.php line 105

at Github\HttpClient\HttpClient->post('repos///hooks', '{&quot;name&quot;:&quot;web&quot;,&quot;active&quot;:true,&quot;events&quot;:[&quot;push&quot;],&quot;config&quot;:{&quot;url&quot;:&quot;http:\/\/zikula.org\/library\/webhook&quot;,&quot;secret&quot;:&quot;&quot;,&quot;content_type&quot;:&quot;json&quot;}}')
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/Manager/RepositoryManager.php line 102

at Zikula\Module\ExtensionLibraryModule\Manager\RepositoryManager->createWebHook(false, array('push'), 'http://zikula.org/library/webhook')
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/Controller/UserController.php line 584

at Zikula\Module\ExtensionLibraryModule\Controller\UserController->addExtensionAction(object(Zikula_Request_Http))
    in  line 

at call_user_func_array(array(object(UserController), 'addExtensionAction'), array(object(Zikula_Request_Http)))
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php line 145

at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Zikula_Request_Http), '1')
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php line 66

at Symfony\Component\HttpKernel\HttpKernel->handle(object(Zikula_Request_Http), '1', true)
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/DependencyInjection/ContainerAwareHttpKernel.php line 64

at Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel->handle(object(Zikula_Request_Http), '1', true)
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php line 185

at Symfony\Component\HttpKernel\Kernel->handle(object(Zikula_Request_Http))
    in /home/zwww/core/src/index.php line 21

[2] Github\Exception\RuntimeException: Not Found
at n/a
in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/knplabs/github-api/lib/Github/HttpClient/Listener/ErrorListener.php line 92

at Github\HttpClient\Listener\ErrorListener->onRequestError(object(Event), 'request.error', object(EventDispatcher))
    in  line 

at call_user_func(array(object(ErrorListener), 'onRequestError'), object(Event), 'request.error', object(EventDispatcher))
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php line 164

at Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(array(array(object(ErrorListener), 'onRequestError'), array('Guzzle\Http\Message\Request', 'onRequestError')), 'request.error', object(Event))
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php line 53

at Symfony\Component\EventDispatcher\EventDispatcher->dispatch('request.error', object(Event))
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Message/Request.php line 589

at Guzzle\Http\Message\Request->processResponse(array('handle' => object(CurlHandle)))
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Message/Request.php line 378

at Guzzle\Http\Message\Request->setState('complete', array('handle' => object(CurlHandle)))
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Message/EntityEnclosingRequest.php line 49

at Guzzle\Http\Message\EntityEnclosingRequest->setState('complete', array('handle' => object(CurlHandle)))
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Curl/CurlMulti.php line 303

at Guzzle\Http\Curl\CurlMulti->processResponse(object(EntityEnclosingRequest), object(CurlHandle), array('msg' => '1', 'result' => '0', 'handle' => 'Resource id #1049'))
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Curl/CurlMulti.php line 257

at Guzzle\Http\Curl\CurlMulti->processMessages()
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Curl/CurlMulti.php line 240

at Guzzle\Http\Curl\CurlMulti->executeHandles()
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Curl/CurlMulti.php line 224

at Guzzle\Http\Curl\CurlMulti->perform()
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Curl/CurlMulti.php line 111

at Guzzle\Http\Curl\CurlMulti->send()
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Curl/CurlMultiProxy.php line 94

at Guzzle\Http\Curl\CurlMultiProxy->send()
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/guzzle/guzzle/src/Guzzle/Http/Client.php line 284

at Guzzle\Http\Client->send(object(EntityEnclosingRequest))
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/knplabs/github-api/lib/Github/HttpClient/HttpClient.php line 140

at Github\HttpClient\HttpClient->request('repos///hooks', '{&quot;name&quot;:&quot;web&quot;,&quot;active&quot;:true,&quot;events&quot;:[&quot;push&quot;],&quot;config&quot;:{&quot;url&quot;:&quot;http:\/\/zikula.org\/library\/webhook&quot;,&quot;secret&quot;:&quot;&quot;,&quot;content_type&quot;:&quot;json&quot;}}', 'POST', array())
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/vendor/knplabs/github-api/lib/Github/HttpClient/HttpClient.php line 105

at Github\HttpClient\HttpClient->post('repos///hooks', '{&quot;name&quot;:&quot;web&quot;,&quot;active&quot;:true,&quot;events&quot;:[&quot;push&quot;],&quot;config&quot;:{&quot;url&quot;:&quot;http:\/\/zikula.org\/library\/webhook&quot;,&quot;secret&quot;:&quot;&quot;,&quot;content_type&quot;:&quot;json&quot;}}')
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/Manager/RepositoryManager.php line 102

at Zikula\Module\ExtensionLibraryModule\Manager\RepositoryManager->createWebHook(false, array('push'), 'http://zikula.org/library/webhook')
    in /home/zwww/core/src/modules/ExtensionLibrary/Zikula/Module/ExtensionLibraryModule/Controller/UserController.php line 584

at Zikula\Module\ExtensionLibraryModule\Controller\UserController->addExtensionAction(object(Zikula_Request_Http))
    in  line 

at call_user_func_array(array(object(UserController), 'addExtensionAction'), array(object(Zikula_Request_Http)))
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php line 145

at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Zikula_Request_Http), '1')
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php line 66

at Symfony\Component\HttpKernel\HttpKernel->handle(object(Zikula_Request_Http), '1', true)
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/DependencyInjection/ContainerAwareHttpKernel.php line 64

at Symfony\Component\HttpKernel\DependencyInjection\ContainerAwareHttpKernel->handle(object(Zikula_Request_Http), '1', true)
    in /home/zwww/core/src/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php line 185

at Symfony\Component\HttpKernel\Kernel->handle(object(Zikula_Request_Http))
    in /home/zwww/core/src/index.php line 21

Add RSS feeds

new versions
new extensions
new core releases
...

Elements are hiding on hover

If you hover some elements on the user display page they become hidden:

The green check showing that it was verified.
The blue badge showing core version compatibility.

Explain verification

On some extensions there is a green check icon included with a tooltip like Extension has been verified. A user does not know what this should imply though. So there is some explaination required in the library frontend.

GitHub API: Breaking changes to Authorizations API responses on April 20

GitHub announced something at their developer blog at February 19, 2015 at 01:00AM. @cmfcmf Check if that matters for the ExtensionLibrary.

GitHub API: Removing token attribute from Authorizations API responses (Update)

GitHub announced something at their developer blog at February 03, 2015 at 08:00AM. @cmfcmf Check if that matters for the ExtensionLibrary.

Accomodate Extensions without `composer.json`

Extensions that are Core 1.3.x compatible (only) will not have a composer.json file and we must accommodate these extensions.

cc/ @cmfcmf

GitHub API: More time to prepare for the breaking changes to organization permissions

GitHub announced something at their developer blog at February 24, 2015 at 01:00AM. @cmfcmf Check if that matters for the ExtensionLibrary.

relocate `keywords` field to composer.json ?

the composer specification (not the core one, the "real" one) has the keywords field. Is there any reason that we don't use it and instead use a keywords field in the manifest file?

this is currently only a question for debate and not yet for implementation.

Order of versions is wrong

Currently the order on the details page is:
1.3.0
1.2.9
1.2.5
1.2.10

Unify / rename webhook endpoints

The endpoint for third party apps (modules / themes / plugins). To be notifed on new releases to add them to the EL.
The endpoint for zikula/core. Used to fetch releases and to be notified on new releases.
The (not jet existing) endpoint for jenkins. To be notified after a new build.

Proposal for routes:

Add api field to the manifest file.

Add a required api field to the manifest file. The only value it is allowed to be set to currently would be v1.
This allows to have multiple EL api versions.

@craigh

Javascipt error

the 'verify' extension JS is not working properly.

index takes too long to load

simply visiting /library/ takes way to long (this is on my dev box at home).

item	time
Total time	62234 ms
Initialization time	767 ms

the web profiler says the controller is the problem. I suspect the filter is the issue. In this case, I have not filtered anything so the view is "unfiltered".

We need to cache the view or do something to speed this up.

Dizkus Topic hook: see http://zikula.org/Forum/viewtopic/topic/59763/start/1#pid267412
several others

add route prefix to manifest

@cmfcmf

It might be a good idea to "register" the selected route prefix as part of the manifest. This would allow the EL to keep track and prevent conflicts.

zikula / extensionlibrary Goto Github PK

extensionlibrary's People

Contributors

Stargazers

Watchers

extensionlibrary's Issues

Recommend Projects

Recommend Topics

Recommend Org