zillode / notify Goto Github PK

I'm trying to create a proper fedora package of this go library, but I am hitting this strange error when running the tests on aarch64/arm64:

+ go test -compiler gc -ldflags '' github.com/zillode/notify
panic: notify: epoll_wait(2) error function not implemented
goroutine 10 [running]:
github.com/zillode/notify.(*inotify).loop(0x442011c000, 0x442008b7a0)
	(...)/src/github.com/zillode/notify/watcher_inotify.go:215 +0x114
created by github.com/zillode/notify.(*inotify).lazyinit
	(...)/src/github.com/zillode/notify/watcher_inotify.go:133 +0x10c
FAIL	github.com/zillode/notify	1.774s

It seems this issue has already been fixed upstream: rjeczalik#116

Cgo rules have changed slightly in the upcoming Go 1.10. With the current beta1:

jb@kvar:~/e/s/g/z/notify $ go version
go version go1.10beta1 darwin/amd64
jb@kvar:~/e/s/g/z/notify $ go install
# github.com/zillode/notify
./watcher_fsevents_cgo.go:51: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal
./watcher_fsevents_cgo.go:162: cannot use nil as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFStringCreateWithCStringNoCopy
./watcher_fsevents_cgo.go:163: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal

The required changes are documented here:

https://go-review.googlesource.com/c/go/+/66332

There were some updates to rjeczalik/notify, e.g. rjeczalik#105 which is very relevant.
@Zillode Is it ok if I merge it into this repo?

I don't think there is anything directly affecting syncthing-inotify, but potentially (while unlikely) for the FS notification PR on syncthing.
And in the future, should I just do the merge or keep asking/notifying you first?

Hello!

Are there plans to contribute changes to rjeczalik/notify?

I am the Debian maintainer for Syncthing in Debian and I would love to avoid having the two libraries in Debian.

There was just some PR activity over on rjeczalik repo, so there is activity. I would like to create a PR for the changes introduced in #2 and also a work-in-progress PR for #3.
It makes sense that this PRs come from the Zillode fork and not mine. Now this is the first time I have push access to a git repo, so I wanted to ask first: Is it ok if I create the necessary branches and issue the PRs?

We need a new Go 1.10 fix... Ironcally the revert of the previous one...