Giter VIP home page Giter VIP logo

Comments (6)

runtologist avatar runtologist commented on August 25, 2024 1

I think it's a good idea to upgrade while leaving the API mostly intact and making a switch separately.

We might also want to do an intermediate release introducing the new API and deprecating the existing one.

from zio-telemetry.

easel avatar easel commented on August 25, 2024 1

I agree, the approach you've taken keeps the change surface much more reasonable for consumers. Frankly, if we were going to change up the API, I think I'd go consider going the route of decoupling from any implementation entirely in favor of a "native" interface with adapters to opentracing/opentelemetry on the backend.

from zio-telemetry.

runtologist avatar runtologist commented on August 25, 2024

AFAIK not. PRs would be highly appreciated.

from zio-telemetry.

easel avatar easel commented on August 25, 2024

Ok. I have hacked at making things compile a little bit locally but I'm not sure how it will impact usability -- basically every usage of Span has to be replaced with Context.

from zio-telemetry.

duxet avatar duxet commented on August 25, 2024

Ok. I have hacked at making things compile a little bit locally but I'm not sure how it will impact usability -- basically every usage of Span has to be replaced with Context.

I've left Spans in my PR, as they can be easily injected/extracted from Context. I think it would make more sense to make such switch in a separate PR if it would needed, eg. for sharing baggage with logging/metrics.

from zio-telemetry.

runtologist avatar runtologist commented on August 25, 2024

Closing this issue as the upgrade is done. I propose continuing discussion about API in #194.

from zio-telemetry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.