Comments (6)
I think it's a good idea to upgrade while leaving the API mostly intact and making a switch separately.
We might also want to do an intermediate release introducing the new API and deprecating the existing one.
from zio-telemetry.
I agree, the approach you've taken keeps the change surface much more reasonable for consumers. Frankly, if we were going to change up the API, I think I'd go consider going the route of decoupling from any implementation entirely in favor of a "native" interface with adapters to opentracing/opentelemetry on the backend.
from zio-telemetry.
AFAIK not. PRs would be highly appreciated.
from zio-telemetry.
Ok. I have hacked at making things compile a little bit locally but I'm not sure how it will impact usability -- basically every usage of Span has to be replaced with Context.
from zio-telemetry.
Ok. I have hacked at making things compile a little bit locally but I'm not sure how it will impact usability -- basically every usage of Span has to be replaced with Context.
I've left Spans in my PR, as they can be easily injected/extracted from Context. I think it would make more sense to make such switch in a separate PR if it would needed, eg. for sharing baggage with logging/metrics.
from zio-telemetry.
Closing this issue as the upgrade is done. I propose continuing discussion about API in #194.
from zio-telemetry.
Related Issues (20)
- OpenTelemtry: set status description only when StatusCode is ERROR
- OpenTelemetry: add Tracing.spanScoped method
- OpenTelemetry: rename some of the dangerous methods by adding the unsafe suffix
- OpenTelemetry: attributes don't show up for the span created by autoinstrumentation HOT 9
- OpenTelemetry: integration with zio-http, parent span ends immidiately for the response stream HOT 2
- OpenTelemetry span for ZStream HOT 4
- OpenTelemetry: find a way to avoid specifying type parameters when calling Tracing aspects HOT 5
- OpenTelemetry: Baggage gets lost when integrating with zio-http
- Any reporters other than Zipkin reporter? HOT 4
- OpenTelemetry: integration with popular http libraries such as zio-http and http4s
- OpenTelemetry: add logging support
- Configure MIMA to fail the build on backward incompatible code changes.
- OpenTelemetry: add gprc example (autoinstrumentation and manual)
- OpenTelemetry: update examples and docs to show all-in-one example via the Honeycomb observability platform HOT 1
- OpenTelemetry: map ZIO runtime data (log annotations, metrics) to OTEL metrics counterparts
- Use zio-theseus as a reference to integrate zio-opentelemetry with a doobie, kafka, grpc, etc. HOT 6
- OpenTelemetry: implement a mapping from ZIO Metrics Summary to OTEL Histogram HOT 8
- OpenTelemetry: propagate ZIO log annotations to OTEL span attributes
- Opentelemetry-example doesn't collect data to Jaeger and Seq HOT 2
- Rewrite opentelemetry example modules using idiomatic Scala 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zio-telemetry.