zoellner / gmail-batch-stream Goto Github PK

Hi @zoellner ,

I'm using the library and find it exactly suitable to my need.
However, i'm getting the above error despite using it.

Can you help?

After employing gmail-batch-stream, the node process does not exit at the end, despite the stream being consumed fully (using done() or toArray()).

Currently there is one rate limiter per GBS. in some cases however, one might need to run several operations for one user in a stream (e.g. list messages then get messages).
A rate limiter per user, created outside the GBS, would be needed in this case.

I tried it out but ran into many issues (will report them separately as soon as I get some idea if they are all the same issue or several different ones), suspecting that this library does not support Node v10 (or something else relevant to my setup).

Adding some basic tests would allow me to verify if the code runs as expected in my environment.

Some inspiration:
https://github.com/SpiderStrategies/node-gmail-api/tree/master/test (including tests for batch requests using nock)
https://github.com/fedecia/gmail-api-sync/tree/master/test (includes helper scripts to generate access tokens)

For whatever reason, the pseudo gmail client returned promises, causing havoc in this library.

In the end, I had to change the usage example to resolve promises using .flatMap(_h) before piping to gbs:

.flatMap(_h) // resolve promises
.pipe(this.googleBatchStream.pipeline(1, 5))

and

.flatMap(_h) // resolve promises
.pipe(GBS.pipeline(100, 5)) //Run in batches of 100. Use quota of 5 (for users.messages.get).

This is a great addition to the world of open source! Thanks!
However, with highland.js at 3k stars and rxjs at 16k stars, rxjs seems to have a wider adoption than highland.js. Is this library using any highland.js-specific features? If not, is supporting RxJS an option?

To fix this, add to multipart: batch.map((request, index) => {:

        request.qs = request.qs || { };
        request.json = request.json || { } ;

Cause: When a 404 response is encountered, the body is not JSON, but plain text.

HTTP/1.1 404 Not Found
Content-Type: text/html; charset=UTF-8
Date: Thu, 13 Dec 2018 22:36:43 GMT
Expires: Thu, 13 Dec 2018 22:36:43 GMT
Cache-Control: private, max-age=0
Content-Length: 9

Not Found