zoinkwiz / quest-helper Goto Github PK

Legends' quest appears to entirely skip the rune puzzle, and also skips killing Viyeldi with the dagger.

during the step after making the potion where you use it on the door, it says something isn't right and the quest is closed and I can't reopen. have gotten so many quests completed with your plugin (22 remaining quests) after manually continuing after I was able to open the quest again and finished smoothly thanks so much! (21)

Runelite plugin version 1.1.2
Rum deal dosn't open when you click the little arrow on the right next to the title. It instead just jumps back up to the search bar, and nothing happens afterwards. This might simply be because the quest isn't supported yet though. So sorry if that is the case. Love your plugin, I am a new player in osrs and I wouldn't have been able to enjoy the game the same way without it. So thank you for your great work.

I'm sure quite a lot of players (myself included) would love to contribute, but at a glance it seems to be rather difficult to go about testing as you develop. Some steps to get developers started would be very helpful.

For example, say hypothetically someone were wanting to help by implementing a quest. I'll use a rather high level quest such as Monkey Madness II as an example, but this generally applies to every quest; at a glance from an individual external to the project it seems impossible to follow typical iterative development practices, debug and otherwise make meaningful progress in that endeavor without having multiple accounts with the requirements to complete that quest, and running through it multiple times.

A basic workflow or guidelines on how you generally go about implementing new quests would be great!

Love the program, and I want to help support the devs. Can we have a donate link to send a pizza or something?

Cheers, Idk if it's from you're side or Runelite but it doesn't seem to auto update or neither update at all, The latest update inside of runelite is 1.1.1 but it doesn't seem to be the latest one according to ur ghub.

Regards

In the sidebar it'd be good to have the option to view an item's tip. Current thinking would be to add a small (i) icon next to such an item, which can be clicked/hovered over to display the tip.

During the part of the quest where u collect taxes from bearded people, it's missing the dialog with Keepa Kettilon in the fishing shop.

I believe the correct NPC you need to talk to is random, so need to either have the player talk to everyone until they get the right one, or find out a way to work out which NPC is correct.

Clicking on the Rum Deal quest in the side panel does nothing.

here are my runelite logs on the crash
client.log

In the Infiltrate the H.A.M. sub-section there is a missing step. Without this step Zanik will not notice the trap door.

Here is the sub-section for reference

The step can be seen in the Wiki's quick guide listed as

Talk to Johanhus Ulsbrecht southeast of the stage. (Chat 4•3)

and in Slayermusiq1's guide.

This step either belongs before the "Go stand at the south of the stage..." step or it should replace that step.

All other quests get started when clicking the arrow except for Rum Deal. I just completed Zogre Flesh Eaters with a similar problem to another issue (Not proceeding after getting info on how to take care of things. Was able to continue on my own.)

I find the icons too big alot of the time, like 'search' 'talk to this npc' icons cover the whole npc/item/thing to click on

. Would be nice with a size slider or presets.

Hey, I think this plugin is great and would love to contribute. I hope you're open to some open-source contribution.

I'm partway through writing a pull request to include Underground Pass, but some things are a little muddy:

1. Do you normally collect all the necessary info by just stepping through quests with the dev tools on and writing down NPC/object IDs? Is there some quicker way to collect all this info?
2. Do the integer keys in BasicQuestHelper#loadSteps correspond to the VarPlayer state of the quest, or are they arbitrary?
3. What's the difference between using QuestStep#addSubstep and ConditionalSteps?

Thanks for the awesome plugin and info

Currently the order is only indicated in the current step, but the dialog options for the Incantation steps aren't highlighted.

They should highlight, likely with a check for the widget which appears of the player saying the line. Need to be careful of people exiting/re-entering dialog.

On the memory challenge for Lunar Diplomacy, the Path 7 from the OSRS Wiki guide was drawn on screen, but the solution was actually Path 10. Furthermore, it seems like only 8 of the 10 (and possibly more) paths are currently supported.

Hi! Been enjoying the plugin a lot.

On the A Tail of Two Cats guide, it tells you to talk to Reldo in the Varrock Museum, but he's in the Castle's library, not the museum. The quest marker is right, but the text is wrong.

Just so you guys can fix so others don't take an unecessary trip to the museum like I did lol

Hi!

Whilst doing the Prince Ali Rescue quest on my ironman, I noticed a few flaws in the quest helper:

1st flaw:
The "Key imprint" step doesn't tell you to bring a bronze bar, which is required to complete the step.

2nd flaw:
The "Talk to Leela east of Draynor Village" dialog doesn't appear to display what dialog options to choose, also doesn't tell you to get a skirt and rope.

I might be able to submit a pull request to fix the flaws noted above this weekend.

sorry for the lack of detail but i figure something is better than nothing.
durring the part of the quest after you come back up the stairs after putting the potion in the tea it highlights the first dialog option only and basically loops i had to just click the others and the quest moved forward. loving the plugin tho id probs be hitting a record if i didnt get stoped here gonna grind the whole list

Hey, could you add the keybind of the dialogue choice to the overlay widget in a nice bright colour?

https://github.com/Zoinkwiz/quest-helper/blob/master/src/main/java/com/questhelper/steps/choice/DialogChoiceSteps.java
I think that this is the chat choice place.

https://github.com/Zoinkwiz/quest-helper/blob/master/src/main/java/com/questhelper/panel/QuestStepPanel.java
That may be the panel place, not really sure though.

When an npc has 4 dialogue options to choose from, the correct one (3 for example) would add the default dialogue option keybind (big blue 3 in this case) to the overlay widget in the top left.

Sick plugin, 10/10
Cheers.

It would be pretty convenient if there was a list of currently supported quests in the panel when a quest isn't active.

At a point during the quest (unknown) the quest fails to update correctly to the next step.

It seems that there are other issues with the tracking as well but can't remember right now

As of last night November 10th, 2020 Quest Helper would make Runelite very laggy after a short amount of time of Runelite being launched. The only way to stop it was to uninstall Quest Helper

It's a great plugin, I've enjoyed it in Leagues since I already have a quest cape on my main. Please let me know when you fix it so I can install it again. Thanks!

Email:
[email protected]

4 buckets are water are required for Plague City. However, They are not listed in the Item Requirements.

It could be handy when preparing for a quest to be able to generate a bank tag quickly which has all the items you'll need in it, rather than searching through your bank.

Hi!

I'm doing the quest right now, and I noticed the target marker for the sailor is pointing to an inaccessible island, instead of the docks.
Also, there's no marker for the queen and the king between talking to Matilda and the advisor.
I'm using Quest Helper 1.1.1 with RuneLite 1.6.29 (on win 10 64 bit if that matters).

Thanks a lot for your work!

When I tried doing The Golem, I got stuck at the abovementioned step. I only got 3 dialogue options and no options related to the quest. I googled what could be the problem and it seems that you need to at least enter the Uzer ruins once before you can get the correct dialogue option from the Curator.

Reported via youtube:

For Olaf's Quest, once you get the map, the plugin simply stops highlighting anything.

On the step where you make the Clockwork Penguin in your POH, you require a Plank and Silk in addition to the clockwork or steel bar. The plugin does not reflect this properly.

I believe it's around this line in the code:

Certain quests require a cat out, or another follower like Zanik. There should be a requirement which indicates if you have the required follower following you.

Reproduction:

1. Look for quest 'Ghosts Ahoy'
2. Click the arrow '>' to open quest in the Quest Helper
3. Nothing happens, unable to open any other quests from this point.

Stacktrace:

io.reactivex.rxjava3.exceptions.UndeliverableException: The exception could not be delivered to the consumer because it has already canceled/disposed the flow or the exception has nowhere to go to begin with. Further reading: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#error-handling | java.lang.reflect.InvocationTargetException
	at io.reactivex.rxjava3.plugins.RxJavaPlugins.onError(RxJavaPlugins.java:367)
	at io.reactivex.rxjava3.internal.observers.LambdaObserver.onError(LambdaObserver.java:83)
	at io.reactivex.rxjava3.internal.observers.LambdaObserver.onNext(LambdaObserver.java:67)
	at io.reactivex.rxjava3.internal.operators.observable.ObservableDoFinally$DoFinallyObserver.onNext(ObservableDoFinally.java:80)
	at io.reactivex.rxjava3.internal.operators.observable.ObservableMap$MapObserver.onNext(ObservableMap.java:63)
	at io.reactivex.rxjava3.internal.operators.observable.ObservableFilter$FilterObserver.onNext(ObservableFilter.java:52)
	at com.jakewharton.rxrelay3.PublishRelay$PublishDisposable.onNext(PublishRelay.java:179)
	at com.jakewharton.rxrelay3.PublishRelay.accept(PublishRelay.java:144)
	at com.jakewharton.rxrelay3.SerializedRelay.accept(SerializedRelay.java:57)
	at net.runelite.client.eventbus.EventBus.post(EventBus.java:115)
	at net.runelite.client.callback.Hooks.clientMainLoop(Hooks.java:193)
	at client.draw(Client.java:1519)
	at client.ak(Client.java)
	at ba.d(GameShell.java:361)
	at ba.run(GameShell.java:315)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.reflect.InvocationTargetException: null
	at jdk.internal.reflect.GeneratedMethodAccessor362.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at net.runelite.client.plugins.Plugin.lambda$findSubscriptions$1(Plugin.java:102)
	at io.reactivex.rxjava3.internal.observers.LambdaObserver.onNext(LambdaObserver.java:63)
	... 13 common frames omitted
Caused by: java.lang.NullPointerException: null
	at com.questhelper.quests.ghostsahoy.DyeShipSteps.setupSteps(DyeShipSteps.java:260)
	at com.questhelper.steps.DetailedOwnerStep.<init>(DetailedOwnerStep.java:55)
	at com.questhelper.quests.ghostsahoy.DyeShipSteps.<init>(DyeShipSteps.java:72)
	at com.questhelper.quests.ghostsahoy.GhostsAhoy.setupSteps(GhostsAhoy.java:336)
	at com.questhelper.quests.ghostsahoy.GhostsAhoy.loadSteps(GhostsAhoy.java:96)
	at com.questhelper.questhelpers.BasicQuestHelper.startUp(BasicQuestHelper.java:47)
	at com.questhelper.QuestHelperPlugin.startUpQuest(QuestHelperPlugin.java:491)
	at com.questhelper.QuestHelperPlugin.onGameTick(QuestHelperPlugin.java:211)
	... 18 common frames omitted```

The coal and mithril check should be flipped. Currently it will recommend coal for mining level >= 55 as well.

In addition to the minimap arrow showing where to go, it could be useful to have an arrow on the floor showing where to go.

No info on the side panel for Demon Slayer, arrows and dialogue options still show up.

After talking to Mathilda, it will say to speak to Advisor Ghrim, and continually point to the stairs to the throne room in Miscellania Castle, though you will have to speak to Vargas first.

It seems that when we reach the step that says "Search Bob's barrel on the ground floor." it doesn't move past that. I've tried to drop the item that we get from the barrel and get a new one and it still does not proceed.

A "skip step" button would be greatly appreciated!

Certain individuals may want to only have the general hint as to what to do, but not all the arrows and highlights. Others may want to only have the general quest overview section and nothing more. I should add options to pick and choose what's desired from the quest helper.

In addition, certain things such as highlight colours.

When viewing a quest in quest helper it can be helpful to pre-read the wiki incase there are other details such as maps, recommended teleports, etc. Having a handy dandy link would be a++

I'm unable to start the quest help for "Rum Deal" due to my farming requirement being below 40 though I'm able to boost >40 with Brown Spice from Evil Dave's lair.

Thank you.

UPDATE - I now have 40 Farming and am still unable to run the "Rum Deal" quest helper. My apologies for the confusion w/ title.

For demon slayer the plugin only lists 25 bones as an item requirement. The quest also requires 1gp(you have to give gypsy aris 1gp when you start the quest) and a bucket of water(it does show you where to pick up a bucket, though. So not really a big deal). Edit: Also found the quest doesn't list food+armor and varrock/draynor teleports. And in the enemies to defeat section Delrith isn't listed.

Just wanted to add I'm really liking the plugin quite a bit, and I hope you continue working on it. It's great! I'll continue to report any issues I come across. Thanks!!

In Death to the Dorgeshuun, zanik needs to find a trapdoor for you. There is a prerequisite step missing for this to happen. You first need to talk to Johanhus Ulsbrecht (4 - 3) and then Zanik can find the trapdoor.

The text "Return the plunder to the chest in Bill's hull" repeats 4 times in the instructions panel under the "Plunder the pirates" section of the quest

When talking to Davey in the step "Kill evil spirit" there's a 47 prayer point requirement. I would have liked that to be shown in the plugin

This can be useful for scenarios where you only want to show chat prompts when the player is talking to the correct NPC. Notably this'd be useful for Biohazard, when you need to give the ingredients for the plague test to the chemist's helpers.

If you're say upstairs, and an ObjectStep starts which is on the ground floor and the object is near enough to already be rendered, the object won't become highlighted when you go downstairs. This is due to the init step only considering the current plane. This needs to be resolved.

The side instructions and sections are missing for the quest. The highlighted items and on screen arrows still work as do the necessary items in the instructions window. Restarting the quest did not help.

This was noticed on an account playing Trailblazer league.

Any plans to add SOTE?

Hi,

I have some problems with the quest sync of the watchtower quest,

I have already reinstalled the plugin; and have tried to use it on a difrent pc

I have v1.1.5

Thanks in advance