zone117x / mimemapping Goto Github PK

License: MIT License

C# 100.00%

mimemapping's Introduction

MimeMapping

Constants for (almost) all MIME types and method to determine MIME type from a file name. Contains just over 1000 mime types.

The Dictionary is generated from the jshttp/mime-db db.json. Works similar to .NET's System.Web.MimeMapping.GetMimeMapping.

It aggregates data from the following sources:

The library is just a literal C# Dictionary<string, string> with over 1000 entries, and a helper method that can be passed a file path.

Example Usage

string myFile = "myimage.jpg";
string mimeType = MimeMapping.MimeUtility.GetMimeMapping(myFile);
Console.WriteLine(mimeType); // output: image/jpeg

string randomFile = "data.asdf";
string mimeType = MimeMapping.MimeUtility.GetMimeMapping(randomFile);
Console.WriteLine(mimeType); // output: application/octet-stream

string rawExtension = "json";
string mimeType = MimeMapping.MimeUtility.GetMimeMapping(rawExtension);
Console.WriteLine(mimeType); // output: application/json


// List all types..
foreach(var kp in MimeMapping.MimeTypes.TypeMap)
{
  Console.WriteLine($"File extension: {kp.Key}, mime string: {kp.Value}");
}

mimemapping's People

Contributors

Stargazers

Watchers

Forkers

asylum4you musukvl leandrocannizzaro garrettdavis christopherbahr coderrob visualon stantoxt edwinyosorahardjo coolqingcheng tstojecki phxnsharp jzabroski maybelaterornot horch004 gintsk

mimemapping's Issues

Consolidating Efforts

Hi @zone117x
I am the new maintainer of:
https://www.nuget.org/packages/Mime-Detective/
https://github.com/MediatedCommunications/Mime-Detective

and have recently published an update expanding to over 14,000 mime signatures. Are you open to combining/joining efforts?
If so, can you add TonyValenti as a admin on the MimeMapping nuget package?

Add https://datatracker.ietf.org/doc/html/rfc7807 types

Add test for better coverage

We should add more tests to get higher coverage

Apache mime type list seems outdated. Why don't build this library on iana list?

I notice I bring an example: I verified that sqlite is not even mentioned in the apache list. Moreover "recently" iana has changed the standard (https://stackoverflow.com/a/55071463) and has updated its list accordingly.

I understand that iana doesn't provide the list of extensions together with the mime, but at least you could be able to validate the mime type. So at least you could put this list next to the one used with the file extension.

What is your opinion about this?

thanks

Pull in mime types from jshttp/mime-db project

The popular js lib https://github.com/jshttp/mime-db has a community maintained list of extensions that are not represented in the existing sources.

Specifically this file: https://github.com/jshttp/mime-db/blob/95e5d5d11bb55e5e107ed7503b37394f7d9ff8ac/src/custom-types.json

The templating/build engine should pull in the extensions from this source.

Generate `KnownMimeTypes.cs` on build

We should automatically build the KnownMimeTypes.cs on build

Update repo settings

disable merge commits
set squash merge to title and commit details
enable auto delete branches

🤗

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

github-actions

.github/workflows/build.yml

actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11

actions/cache v4.0.1@ab5e6d0c87105b4c9c2047343972218f562e4319

codecov/codecov-action v4.1.0@54bcd8715eee62d40e33596ef5e8f0f48dbbccab

actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11

actions/cache v4.0.1@ab5e6d0c87105b4c9c2047343972218f562e4319

actions/upload-artifact v4.3.1@5d5d22a31266ced268874388b861e4b58bb5c2f3

.github/workflows/release.yml

actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11

actions/cache v4.0.1@ab5e6d0c87105b4c9c2047343972218f562e4319

actions/upload-artifact v4.3.1@5d5d22a31266ced268874388b861e4b58bb5c2f3

actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11

tj-actions/git-cliff v1.5.0@75599f745633e29f99bd9e14a30865b7d2fcbe84

ncipollo/release-action v1.14.0@2c591bcc8ecdcd2db72b97d6147f871fcd833ba5

nuget

MimeMapping.csproj

MinVer 4.3.0

Microsoft.SourceLink.GitHub 8.0.0

Test/Test.csproj

System.Net.Http 4.3.4

Newtonsoft.Json 13.0.3

MSTest.TestFramework 3.2.2

MSTest.TestAdapter 3.2.2

Microsoft.NET.Test.Sdk 17.9.0

regex

KnownMimeTypes.tt

mime-db v1.52.0

Check this box to trigger a request for Renovate to run again on this repository

GetMimeMapping function is file extension case sensitive

MimeMapping.MimeUtility.GetMimeMapping(mediaFile.Path) function returns "application/octet-stream" for "1.JPG" and "1.Jpg"

Is it a bug or planned behavior?
I'm suggesting to lower case file extension before lookup if that is the bug. And update readme if that is planned behavior.

Refine the build targets

Looking on our build targets it looks like:
<TargetFrameworks>netstandard2.0;net461</TargetFrameworks>

Can we drop net461 as it is out-of-support?
Should it be replaced by net462 or can we just trim it? Are we using something useful from it?

Enable renovate bot

@zone117x Can you please enable renovate on this repo. So we get automated dependency updates. I'm a maintainer of that bot, so will configure it for our needs. 🤗

Renew `nuget.org` api key

Current key is expired, so please renew.

https://github.com/zone117x/MimeMapping/actions/runs/7885027305/job/21515261685#step:8:13

Migrate to `System.Text.Json`

Since System.Text.Json is part of .NET and we don't use specific Newtonsoft.Json functionality, it is easily possible to drop additional external dependency in favor of System.Text.Json

https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/migrate-from-newtonsoft?pivots=dotnet-8-0

Restructure repo

We should restructure repo to a more conventional dotnet project

add main project to MimeMapping folder
move projects to src and test folders ?
others ?

Keynote file type

Apple Keynote files (.key, application/vnd.apple.keynote) isn't listed. Do you not refer to https://www.iana.org/assignments/media-types/media-types.xhtml ?

New Release

@zone117x Should we release a major or minor update?

I would prefer a major bump because of the new mime db source and a lot changes because of it.

Example usage invalid

string myFile = "myimage.jpg";
-string mimeType = MimeMapping.MimeTypes.GetMimeMapping(myFile);
+string mimeType = MimeMapping.MimeUtility.GetMimeMapping(myFile);
Console.WriteLine(mimeType); // output: image/jpeg

string randomFile = "data.asdf";
-string mimeType = MimeMapping.MimeTypes.GetMimeMapping(randomFile);
+string mimeType = MimeMapping.MimeUtility.GetMimeMapping(randomFile);
Console.WriteLine(mimeType); // output: application/octet-stream

string rawExtension = "json";
-string mimeType = MimeMapping.MimeTypes.GetMimeMapping(rawExtension);
+string mimeType = MimeMapping.MimeUtility.GetMimeMapping(rawExtension);
Console.WriteLine(mimeType); // output: application/json


// List all types..
foreach(var kp in MimeMapping.MimeTypes.TypeMap)
{
	Console.WriteLine($"File extension: {kp.Key}, mime string: {kp.Value}");
}

JFIF file type not mapped

Could we add support for JFIF please?

add codecov token to secrets

it's required for codecov action v4

Add strong name

Currently given library is missing a strong name signing and hence it cannot be referenced from strongly named libraries and projects. Currently, on build one gets warning:

Warning CS8002 Referenced assembly 'MimeMapping, Version=1.0.1.26, Culture=neutral, PublicKeyToken=null' does not have a strong name.

.. and in runtime this would fail with exception:

Could not load file or assembly 'MimeMapping, Version=1.0.1.26, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)":"MimeMapping, Version=1.0.1.26, Culture=neutral, PublicKeyToken=null

Adding a strong name (with open key) would make the library usable for both signed and unsigned consumers.

Difference with System.Web.MimeMapping.GetMimeMapping

I know the following example uses URL instead of file system path but it works well for System.Web.MimeMapping

var myFile= "https://test.com/file/random-file"
string mimeType = System.Web.MimeMapping.GetMimeMapping(myFile)
//Console.WriteLine(mimeType); // output: application/octet-stream

var myFile= "https://test.com/file/random-file"
string mimeType = MimeMapping.MimeUtility.GetMimeMapping(myFile); //System.ArgumentOutOfRangeException exception