zx80 / anodb Goto Github PK

Theres a typo in the check for mariadb, it should be self._db not self.db:

musicsite-api-1       |   File "/usr/local/lib/python3.11/site-packages/anodb.py", line 88, in __init__
musicsite-api-1       |     self._conn = self._connect()
musicsite-api-1       |                  ^^^^^^^^^^^^^^^
musicsite-api-1       |   File "/usr/local/lib/python3.11/site-packages/anodb.py", line 188, in _connect
musicsite-api-1       |     elif self.db == "mariadb":  # pragma: no cover
musicsite-api-1       |          ^^^^^^^
musicsite-api-1       | AttributeError: 'DB' object has no attribute 'db'. Did you mean: '_db'?

Thank you for your time on this package, it's a really elegant way to interface with aiosql.

I'm stuck on Python 3.9 for the moment because one of my libraries isn't compatible with 3.10+ (appdynamics). Would it be possible to bring back 3.9 support? Probably would mean having to use the old union type syntax, sorry.

I saw this comment mentioning 3.7 and 3.8 weren't compatible:

Hi,

when using psycopg (and I think also sqlite) directly, we can control transaction scope by using the connection object. This remains true even when we use aiosql, because the connection object is "outside" the aiosql object. For example:

conn = psycopg.connect("service=foo", autocommit=True)
queries = aiosql.from_path("queries.sql")
with conn.transaction():
    queries.insert_foo(conn, foo="foo")
    queries.insert_bar(conn, bar="bar")
crunch_numbers_furiously_for_hours()
with conn.transaction():
    queries.insert_baz(conn, baz="baz")

But with anodb, as it is now, I have to rely on peeking inside your object and (ab)using the ostensibly private _conn member. So you should consider one of:

1. Expose the _conn member, maybe just with a getter method, or
2. Make your own transaction interface, maybe by forwarding some methods calls automatically to _conn

Thanks for your attention,

--
Ian