Modal class not working on slideshow caption hrefs about 18f.gsa.gov HOT 7 CLOSED

We discussed yesterday that it wouldn't work because the DOM keeps being destroyed and reinserted.

from 18f.gsa.gov.

Can we remove the href attribute? I don't believe we need to link directly to anything. The sources are cited.

from 18f.gsa.gov.

Remove the href from what element?

from 18f.gsa.gov.

From the photo-credit

from 18f.gsa.gov.

Ah right. I like the ability to look at the source of the images, but we are attributing. Passing back to @quepol to make final decision on whether to remove the links.

from 18f.gsa.gov.

I know we discussed the DOM issue, but I swear it was working at some point during my testing. Alas...

I, too, make it a best practice to link, not just text attribute. Let's leave it for now.

from 18f.gsa.gov.

Resolved w/ that commit. Closing.

from 18f.gsa.gov.