Giter VIP home page Giter VIP logo

Comments (4)

aantron avatar aantron commented on May 23, 2024

Agreed. I'll have to think about how to package these, because they need to go in the .rei file, but the .rei file is shared between JS and native, and Js.Promise doesn't exist on native. Might have to split the .rei files, so each implementation gets its own. I guess it won't be a big deal in terms of them going out of sync, because we still subject both JS and native Repromise to the same tests.

In the meantime, here is how these can be defined:

external fromJSPromise:
  Js.Promise.t('a) => Repromise.Rejectable.t('a, Js.Promise.error) =
  "%identity";

external toJSPromise:
  Repromise.Rejectable.t('a, _) => Js.Promise.t('a) = "%identity";

from promise.

aantron avatar aantron commented on May 23, 2024

Ok, I added the functions to master, as Repromise.Rejectable.fromJsPromise and Repromise.Rejectable.toJsPromise.

The commit also includes tests and docs.

Thanks for prompting this :)

from promise.

lpil avatar lpil commented on May 23, 2024

Thank you!

from promise.

aantron avatar aantron commented on May 23, 2024

This is now in NPM in @aantron/repromise 0.6.0. Thanks again for prompting it :)

from promise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.