Comments (4)
Agreed. I'll have to think about how to package these, because they need to go in the .rei
file, but the .rei
file is shared between JS and native, and Js.Promise
doesn't exist on native. Might have to split the .rei
files, so each implementation gets its own. I guess it won't be a big deal in terms of them going out of sync, because we still subject both JS and native Repromise to the same tests.
In the meantime, here is how these can be defined:
external fromJSPromise:
Js.Promise.t('a) => Repromise.Rejectable.t('a, Js.Promise.error) =
"%identity";
external toJSPromise:
Repromise.Rejectable.t('a, _) => Js.Promise.t('a) = "%identity";
from promise.
Ok, I added the functions to master
, as Repromise.Rejectable.fromJsPromise
and Repromise.Rejectable.toJsPromise
.
The commit also includes tests and docs.
Thanks for prompting this :)
from promise.
Thank you!
from promise.
This is now in NPM in @aantron/repromise
0.6.0. Thanks again for prompting it :)
from promise.
Related Issues (20)
- Pipe last implementation HOT 2
- Promise.allOk and its variations HOT 6
- Add `Promise.both` HOT 2
- BuckleScript 8.0.0 breaks listToArray / Promise.all HOT 5
- Reduce compiled size again HOT 4
- Format with refmt? HOT 2
- About the deprecation of the infix operators HOT 2
- Promise.allOkArray never resolves if input is an empty array HOT 1
- Tests: remainsPending appears not to be working
- Converting from Js.Promise HOT 3
- Convert tests to OCaml syntax
- Add a js_of_ocaml variant
- Try an internal module with double underscores to hide "rejectable" from error messages
- Exceptions cause resolution with `undefined` HOT 8
- Provide type abbreviation for promises that reject with Js.Promise.error
- Convert README snippets to ReScript syntax
- Convert to ReScript syntax once there is enough adoption HOT 10
- tap on a rejected promise triggers unhandled promise rejection HOT 3
- Native Example HOT 4
- Example for reason syntax with letop
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from promise.