Giter VIP home page Giter VIP logo

Comments (3)

TheSpyder avatar TheSpyder commented on September 22, 2024 1

Thanks! I was tempted to log a PR but I wasn't sure if I had the right idea :)

I think it's fine for this to only work with Promise.Js. Those are the only ones I feel the need to tap anyway, since I use them for bindings.

from promise.

aantron avatar aantron commented on September 22, 2024

@TheSpyder Thanks for the report and the suggestion. I've added a reproducing test case in 356dd59, and your fix. It's now in npm as reason-promise 1.1.4. Apologies for the pretty big delay.

from promise.

aantron avatar aantron commented on September 22, 2024

I updated only Promise.Js.tap, but not Promise.tap, Promise.tapOk, Promise.tapError, or Promise.tapSome. In an idealized type-safe world, these functions would never face promise rejections, and it might actually be good for them to cause rejection reports, if they do. Please let me know if you have any issues with that, and would like them changed, as well.

from promise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.