Giter VIP home page Giter VIP logo

Comments (10)

lessp avatar lessp commented on May 23, 2024 3

I interpreted this question as if it said "on JS," because promise native remains an OCaml library __(which, to my knowledge, nobody is using :P)__

How dare you!

image

from promise.

jyssh avatar jyssh commented on May 23, 2024 1

I interpreted this question as if it said "on JS,"

You got it right.

Perhaps I won't do this conversion for that reason. I originally created this issue before the announcement of Melange, when it looked like there would be no compiler that used/favored Reason anymore.

Makes sense. And frankly, I am relieved. For a moment, I feared this reason-to-rescript decision would carry over to dream as well.

because promise native remains an OCaml library (which, to my knowledge, nobody is using :P)

Well at the beginner stage at least, the promise syntax looks more intuitive to me than lwt. So there is that.

from promise.

TheSpyder avatar TheSpyder commented on May 23, 2024 1

Even if this library isn't converted to ReScript syntax, which is fine, can the bs-platform peer dependency be removed? The main package has been renamed to rescript so anyone still using this with rescript is (or will eventually) get a 'missing peer dependency' warning.

from promise.

aantron avatar aantron commented on May 23, 2024 1

I hate to bug you, but can we get that release please? 😅

Now out as [email protected]. Thanks for bugging me. I had lost track of this.

from promise.

jyssh avatar jyssh commented on May 23, 2024

Given the widening gulf between the rescript and the reason/ocaml ecosystem, will this switch mean that promise will become a rescript-only library?

from promise.

aantron avatar aantron commented on May 23, 2024

Perhaps I won't do this conversion for that reason. I originally created this issue before the announcement of Melange, when it looked like there would be no compiler that used/favored Reason anymore.

will this switch mean that promise will become a rescript-only library?

I interpreted this question as if it said "on JS," because promise native remains an OCaml library (which, to my knowledge, nobody is using :P)

from promise.

aantron avatar aantron commented on May 23, 2024

How dare you!

My apologies :D

Perhaps with Melange there will be good reason, eventually, to "push"/advertise native reason-promise. But there is also the pending merging of effects into the language, so perhaps not.

from promise.

aantron avatar aantron commented on May 23, 2024

@TheSpyder I removed the peer dependency completely. I figure anyone using reason-promise is going to inevitably depend on rescript (or bs-platform) anyway, and we don't need an extra nag. I'll do a release in the coming days. Thanks for noting it!

from promise.

TheSpyder avatar TheSpyder commented on May 23, 2024

yes, I think between the project rename and melange it no longer makes sense to use peer dependency at all 👍

Thanks!

from promise.

TheSpyder avatar TheSpyder commented on May 23, 2024

I hate to bug you, but can we get that release please? 😅

from promise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.