Giter VIP home page Giter VIP logo

Comments (2)

davesnx avatar davesnx commented on September 21, 2024 1

I have vendored this project under server-reason-react on https://github.com/ml-in-barcelona/server-reason-react/tree/main/packages/promise, and changes that I made was:

  • Add dune file for js/
  • Remove type Result and result dependency on native/ (was there for compatibility with 4.02)
  • Remove type result on js/ (was there for compatibility with BuckleScript < 6)

Just my 2 cents about ReScript/Melnage. If there's a need for a compatibility with ReScript (#73) maybe we could migrate either js/promise.re to ReScript and keep it under a bsconfig folder or migrate to OCaml and add the dune with the modes melange.

I have done this similar stuff for styled-ppx and it's a decent solution

from promise.

jchavarri avatar jchavarri commented on September 21, 2024

One thing that comes to mind is that because melange also uses dune, a new library should be added, maybe they could be called promise.native and promise.melange or something like that.

from promise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.