[Bug]: RangeError: Maximum call stack size exceeded. when openning the application about actual HOT 6 CLOSED

Linking to closed issue due missing information: #2241

from actual.

https://github.com/actualbudget/actual/files/14165218/crash.csv

from actual.

Ok, so it took me quite a while to get to the bottom of this. The crux of the problem is - transactions created WAYYYY in the past cause issues with budget table calculations. The simple fix for you would be - don't import transactions from 1980. Use the last few years.

To proper patch this we need to refactor topological sorting from a recursive implementation to an iterative one.

from actual.

Yeah, I imagined the problem was that.
A suggestion is to set a limit to the past where is "old enough" to actual keeps working.
In other words, if the user sets a date to much in the past, don't save it.

It's better to have this kind of lock cuz I see this as critical bug. The file is exported from the bank that way. If you don't pay enough attention when doing it, you just lose your instance or have to edit the database file by hand.

from actual.

Out of curiosity, I tried to see how far back we have to go to break the current code:
Considering today 19-03-2024, I had to put 19-03-2028 to have the same error, that's 96 years to the past. So, if you check if the transaction is more than 90 years old, we are safe.

This creates a interesting bug (hardly able to see by us): If I starting using actual today, it will fail to load at 19/03/2120. lol

from actual.

This would be the workaround I was thinking about.

I didn't try to run this code, I just forked and tried pinpoint where should be the change I suggested.

Since actual has syncing features for offline use, I can imagine there is a better/another place to make the same change.

from actual.