alezost / alect-themes Goto Github PK

First, Thanks for a great theme.

Using spacemacs
To reproduce:
set theme to alect-black
-v (describe variable)
start typing something to filter the list (spacemacs--cur-theme)
the fg and bg are very similar and can't be read (beige).

I've long setup some ignored faces like:

(use-package alect-themes
  :ensure t
  :init
  (setq alect-ignored-faces		;leave these as per defaults
	'(font-lock-comment-face
	  font-lock-string-face
	  font-lock-keyword-face
	  font-lock-function-name-face
	  font-lock-variable-name-face
	  font-lock-constant-face
	  info-title-1 info-title-2
	  info-title-3 info-title-4))
  :config
  (load-theme 'alect-dark t)
...
...

which has always worked fine. But after recently updating alect-themes, I find these faces are not ignored. If I later (re-)load the alect-dark theme, these faces are ignored correctly, but not sadly on the first pass. Thanks for this great theme.

It would be great to have faces for Tuareg (and Caml/OCaml by inheritence), as well as utop and merlin. Also, faces for cperl-mode.

Very few themes support those modes and it would made a great differential/addition to alect-themes to support those.

Hey Alex,

is there a way to create a defun that changes the main bg on the fly?

(in terminals I often use different bg depending on what I'm doing in this frame,
dark-green, dark-red, dark-blue,...
general emacs have set-background)

something like this, (though I'm unsure of what bgs need defined for just the main one)

(defun jr-changeBg-green ()
"set bg dark green"
(interactive)
;(progn
(alect-set-color 'dark 'bg "#002d00")
(alect-set-color 'dark 'bg-1 "#002d00")
(alect-set-color 'dark 'bg-2 "#002d00")
;)
)

I'm terrible at Emacs Lisp and can't figure out why I cannot use a function when using alect-overriding-faces.

E.g., instead of

(setq alect-overriding-faces
    '(
        (font-lock-comment-face ((t :foreground "#beefff")))
    )
)

I want to do something like

(defvar my-colors-alist
    '(
        ("foo"      . "#beefff")
        ("bar"      . "#cccccc")
    )
    "List of my custom colors."
)

(defun z (string)
    (cdr (assoc string my-colors-alist))
)

(setq alect-overriding-faces
    '(
        (font-lock-comment-face ((t :foreground (z "foo"))))
    )
)

, but I get this error:

Wrong type argument: stringp, (z foo)

. I get that it expects a string type, but really? There's no programmatic way to retrieve predefined hex strings?

Aloha Alex,

I've been experimenting with spacemacs and noticed that the alect themes yield a funky looking status bar. The attached screenshot shows the background box is too big (it extends down past the bottom edge of the status bar) and the font color makes for difficult reading.

All the best,
Tom

Aloha Alex,

By chance, I saw this in Messages while using alect light.

Invalid face attribute :inherit mu4e-contact-face [3 times]

I'm using spacemacs, with this version of emacs: GNU Emacs 25.2.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.21)
of 2017-09-22, modified by Debian

All the best,
Tom

I cannot know why and how. What I know is that theme is selected and emacsclient is invoked from mutt. Not by hand. When theme is dark, the emacsclient shows some white background.

Current emacsclient may be seen here:

https://gnu.support/files/tmp/2023-01-16/Screenshot-2023-01-16-07-58-00-159819804.png

when other emacsclient is invoked from mutt I see this:

https://gnu.support/files/tmp/2023-01-16/Screenshot-2023-01-16-08-00-58-568615834.png

and here is side by side:

https://gnu.support/files/tmp/2023-01-16/2023-01-16-08:01:48.png

Do you think this is theme issue or maybe Emacs issue? To me it looks as theme issue.

Aloha Alex,
I recently started using a new email client, mu4e. The face, mu4e-header-highlight-face, is used extensively by mu4e, but shows up poorly using alect light. The dark theme is OK, but the light theme is somewhat hard to use. Here is a screen shot:

All the best,
Tom

Hello and thank you for these wonderful theme(s)! The only nitpick I have is the lack of faces for company mode. Perhaps something like this:

(company-tooltip                   ((,c :foreground ,(gc 'gray+2)
                                        :background ,(gc 'bg+2))))
(company-tooltip-selection         ((,c :foreground ,(gc 'bg-1)
                                        :background ,(gc 'fg+1))))
(company-tooltip-mouse             ((,c :background ,(gc 'green))))
(company-tooltip-common            ((,c :foreground ,(gc 'green)
                                        :background ,(gc 'bg))))
(company-tooltip-common-selection  ((,c :background ,(gc 'bg))))
(company-scrollbar-fg              ((,c :foreground ,(gc 'bg-1))))
(company-scrollbar-bg              ((,c :background ,(gc 'fg+1))))
(company-preview                   ((,c :foreground ,(gc 'gray+2))))
(company-preview-common            ((,c :foreground ,(gc 'blue) :underline t)))

Hi there,

The default color is great, but I sometimes want to try other colors.
The following code does not effect.
(alect-set-color 'light 'bg-1 "black")
What am I missing?
Thank you.

(flyspell-duplicate ((,c :foreground ,(gc 'gray) :background ,(gc 'bg)) :weight bold))
I think this should be:
(flyspell-duplicate ((,c :foreground ,(gc 'gray) :background ,(gc 'bg) :weight bold)))