dms-api's People
Forkers
gertie-sheshedms-api's Issues
Code quality
your create user, documents and role can be broken down into functions
Code Quality - Critical
Test case for Documents Endpoint:
-- is poorly implemented. The case should test the length of the returned collection is equal to the limit passed in not a limited doc as you titled that test case(@ Line 190)
-- has redundant lines 193 and 195
-- has an error in line 196. It's supposed to test the returned collection length against the set limit, not 0
Code Quality - Nitpick
Export format for app in the express.js file is inconsistent with the rest of the codebase<you exported the app as {app} where in other files you exported as just app>
user.controller.js file too long
The user.controller.js is over 200 lines of code.
Refactoring this class would make it simple and easy to read.
Code Quality - Critical
-- Indentation for the User spec file is not properly implemented -- especially starting from line 15
Absent test coverage badge
No badge showing report of test coverage
code quality
redundant use of error and success response. It can be converted into a function and reused
Code
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.