Giter VIP home page Giter VIP logo

dms-api's Issues

Code Quality - Critical

-- Indentation for the User spec file is not properly implemented -- especially starting from line 15

Code quality

your create user, documents and role can be broken down into functions

Code Quality - Nitpick

Export format for app in the express.js file is inconsistent with the rest of the codebase<you exported the app as {app} where in other files you exported as just app>

Code Quality - Critical

Test case for Documents Endpoint:

    -- is poorly implemented. The case should test the length of the returned collection is equal to the limit passed in not a limited doc as you titled that test case(@ Line 190)
    -- has redundant lines 193 and 195
    -- has an error in line 196. It's supposed to test the returned collection length against the set limit, not 0

code quality

redundant use of error and success response. It can be converted into a function and reused

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.