amoreaux / sketch-icons Goto Github PK

I have a large icon set, divided into subfolders. Right now if I choose the parent folder, nothing gets imported. I have to go through each individual subfolder. Could it be set up to search for icons recursively?

I can successfully install the plugin, but the menu items don't do anything.

Sketch version 48.1
Mac OS 10.13.2

I have trouble in making for mask for icon when using plug-in on sketch version 50, could you please send me an updated version to activate this function? Thank u so much : )

Hi there,
I'm trying to import the Feather icon sets. Icons are outlined, so it's only a path with a 2px border.
Once I import an icon with the Sketch-icons plugin, the symbol is empty.

I have no problem with a filled icon. I did the test myself with two icons I created: one with a fill and no border, the other with a border but no fill.

Sketch version: v48.2

Carl —

Hi, I just installed the plugin (High Sierra, using sketch runner).

When I try to import the icons I am getting a very weird behaviour: Icons are smashed into a solid colour square.

I reviewed the output and found that the problem is caused by a squared path that is added to the icon.

I have 100+ icons on this project so going one by one removing the Path is just impossible. Please help! :)

Hi,
When I click on Import Icons nothing happening but when I click on other links like Replace icons or settings it works fine! so, how can I import icons now? please help!

Hi AMoreaux,
it seems the executable .sketchplugin file is missing in the package in this latest update.
I tried and downloaded a couple of time but nothing. In your readme.md file the link is to the previous version.

Thanks,
A

It could be extremely useful to be able to export a selection of icons using an inverse method of importing. I mean… I would like to be able to export without the color symbol applied to a shape mask. The shape used as mask then will have a variable hexadecimal color fill.

For example, in icomoon you can export your icons set with another color applied.

So then we would have cleaner svgs!

Perhaps it helps…
My friend @sandhose told me :
Launch the terminal, go to your assets folder et type :
sed -i ‘’ -e ‘/<rect /d’ ./*
It will remove from the svg file the line <rectangle …> used for the color.

Hi,
first of all thank you for the plugin and keeping it updated. It's really great!

I noticed the apply color mask function behaves weird when applying it to rotated shapes. I can't specify exactly what is happening, but it seems to somehow "reset" the rotation or something.

Maybe you can look into that?

I attached a sample file that shows some bugs.

color-mask-bugs.sketch.zip
.

I want to import material design icons, and add the mask.

Most icons are perfect, except some icons like ic_battery_80， ic_battery_50 series.
when imported , all the same, like the ic_battery_full.

Sketch 49.1 (51147), Sketch-Icons 3.0.14
Selecting: "Plugins->Sketch Icons->Import Icons..." does not perform any action.

Expected behavior: Configure your import modal should open.

Click any of the options in the Sketch Icons menu does not work.

When I try to import SVG files and apply a color mask, and convert to symbol, it is only importing the file, it is NOT applying a color mask, and NOT converting to a symbol. Here is the error I'm seeing in the Plugin Output console:

ERROR: TypeError: undefined is not an object (evaluating 'e.layers().reverse().forEach') «Plugin Output»
ArtboardChanged «Plugin Output»

Color masks don't work.
Can't create symbols (with checkbox in icon import modal).

Using masking is good but there is issue when the artboard export to zeplin (color not read). Maybe if there is feature import as icon font the zeplin issue will be resolve. thanks

After updating to Sketch v49, this plugin will no longer apply a mask. It doesn't allow me to choose a color symbol as the mask color from the same document or any library even though the libraries are listed in the dropdown.

After the import has finished some of the icons are not sized properly – they remain enormous in size.

Screenshot

Thanks for this one! I had a similar idea for a plugin to generate these icons. The huge downside is, i take a lot of stroked icons and they need to be converted to shapes so that they work as a mask. Another downside was the creation of the symbol itself. I would recommend/had the following workflow concept in my mind:

1. Drag n drop you icon/icons (I use iconjar/nucleo)
2. Select the icons
3. Shortcut to create the symbol including the masking of it. A popup appears with all necessary settings
4. Push it to the symbol page

In your workflow i have to create the stroke to shape and also the artboard itself. In most of the projects i gather the icons while i am working on the project. I am not importing 10+ icons at once.

Is it possible to adopt the position and size of the icon path/shape within the original SVGs viewBox/canvas?

In other words: When I have an icon on a 48x48px canvas which is actually only 40x40px large and an icon on a 48x48px canvas which extends to 44x44px and I import them using the Plug-In, the original proportions between the two icons are lost, as both are scaled to the size defined at import (minus padding).

I know Sketch throws this information away when importing SVGs.

A possible workaround might be: Adding a rectangle of the viewBox' size to every SVG before importing and deleting that rectangle afterwards.

Awesome plugin btw, might be really useful. Thanks and congrats!

• Default size and padding
• Display modal to retype padding and size when replace icon. (checkbox)
• Link to folder (#23)

When importing icons, "convert to symbol" does not work if color mask is enabled. Artboards appear as normal non-symbol artboards. Running latest mac os and sketch version.

Hey, I can't seem to get my icons to import with a color mask, nor converted to a symbol when using "from color picker". Maybe I'm just missing something? I'm linking to a video of me using the plugin along with attaching a zip of my test icons. Thanks in advance for any help, really want to get this working!
sketch_icons_plugin_test_folder_02.zip
https://www.dropbox.com/s/m8jt61d0c4845ec/sketch_icons_help.mov?dl=0

I try to use "replace icons'" but this feature doesn't work and my icons doesn't change.
I have no error feedback. :/

First of all, thank you for the greet work!
Alter I click "Import icons..." menu button, a modal dialog shows ,but not completely.
It seems all input elements in the modal dialog are missing. See attachment below.

I've tried reinstall the plugin (manually or via Runner),disable all other plugins, but neither works

OS ver:10.13.5 High Sierra
Sketch ver:45.2
stitch-icons ver:4.0.5

When a user slides and drops icons. The window of import opens to ask import parameters.

When I try to apply a Color mask via Symbol it just colorizes the shapes in the symbol directly and doesn't add the color as a mask. So I can't change the color in the overrides.

It would be cool to have an ability to generate multiple sizes of the icon. Currently plugin allows only to create only one.

For example, allow multiple fields for size or maybe a dynamic button “+ add size”.

Plugin can't find Symbols to add to Color.

3.0.14 can't be installed with Sketch's plugin updates because the .zip referenced in the appcast.xml has the wrong version number (3.0.12) in its manifest.json.

Plugin shows no response at all. I just updated OS to High Sierra 10.13.3 running a older version of Sketch 47.1

When I click on an option, the popup box doesnt appear so essentially can't use the plugin.

I have Sketch 49.1.
The import screen doesn't appear.

Just downloaded and installed the plug-in.

When I try Import, nothing comes up. Nothing seems to happen at all.

I tried disabling all other plug-ins, but that didn't have any effect.

with the newest update from Sketch 52.1, there is no way to use the plugIn to import icons.

When importing icons or adding a mask to already-created icons, mask never applies. Running sketch 48.2 on mac.

More a feature request, but can the ability to add "path/to/symbol" structuring during the creation of the symbols?

Hello. It's an amazing plugin! I'm not sure if it's intended, but when organizing icons on Sketch v51, it just duplicates them as well.

Thanks,

Add option to to create a symbol from the selected color picker color.

This is more of a nice-to-have when generating large icon libraries. If you are allowing the user to pick a color, giving them the ability to convert that picked color into a dynamic symbol in the same step would compliment the plugin's intended functionality.

Trying to import fonts but nothing happens. I'm sure you're aware.

When generating an icon with a dynamic color mask allow an option to remove the black fill on the vector shape. Currently, if the dynamic color mask has alpha transparency, it is obscured by the black fill and requires the user to have to

1. Generate icons without color mask
2. Select all icons and remove black fill
3. update selected icons with dynamic color mask

Remove fill option would allow user to just generate icons without black fill.

When I select one or many artboards and try to "Apply color mask..." masks are not applied. I'm using the latest version of Sketch and I'm on the latest Mac OS.

some cases designer needs icon font ass assets not only svg

Doesnt work for SVGO compressed SVGs

when i wanna replace an icon, maybe ask again about the size of the icons

It is not possible to import svg with a color mask, either from my custom colors or applying one via plugin.

See fix example: #43

Some icons in my set will turn up as blank canvasses. I dropped some example files below that are not showing up. For the set below, only the milk, pig and chicken will show, the rest are blank artboards with nothing inside.

my-icons-collection-23.zip

Sketch 48.2
Plugin suddenly stopped working.
If there is a mask, the plugin deletes it when trying to replace or add it.

Now that sketch 51 supports layer style overrides, I'd like to move away from masks and into styles. Would love for this plugin to let me apply a layer style to all icons.