arithmetric / awespottr Goto Github PK

Thanks for such a timesaving tool. Being able to find prices across a number of regions is rather useful. However I did notice that its suggestions on the cheapest zone seem to be incorrect, as per the output below ...

~/Downloads  awespottr p3.8xlarge
Checking spot prices for p3.8xlarge instance type.

AWS Zone                 Hourly Rate 
------------------------ ------------
us-west-2b               $3.672000   
us-west-2c               $3.672000   
us-east-1f               $3.728000   
us-east-1b               $3.736400   
us-east-1a               $3.782400   
eu-west-1a               $3.966000   
eu-west-1c               $3.966000   
us-east-2b               $5.262000   
us-east-2a               $5.519800   
ap-northeast-2a          $19.924000  
ap-northeast-2c          $19.924000  
ap-northeast-1a          $20.972000  
ap-northeast-1c          $20.972000  

Cheapest hourly rate for p3.8xlarge is $19.924000 in zone ap-northeast-2c

In this case I would have expected it to flag us-west-2b and us-west-2c as the cheapest zones.

In addition to #7 that allows for multiple instance types to be specified on the command line, I've a general clean-up and refactoring at https://github.com/allenluce/awespottr/tree/es6ify ready to go.

Steps to reproduce the bug:

1. Create a role in IAM section of AWS console.
2. Create a policy from the JSON document from the home page, attach a policy to a role.
3. Assign a role to the AWS instance.
4. Run awespottr on the instance.

Expected results:
awespottr should show the regions and prices (this was working in summer 2018).

Actual results:
awespottr prints access denied error. See the full text it prints below.

[18:52]:apl@adeaseweb::>awespottr c4.xlarge
Checking spot prices for c4.xlarge instance type.
{ AuthFailure: AWS was not able to validate the provided access credentials
at Request.extractError (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/services/ec2.js:50:35)
at Request.callListeners (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
at Request.emit (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
at Request.emit (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:683:14)
at Request.transition (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:685:12)
at Request.callListeners (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
message: 'AWS was not able to validate the provided access credentials',
code: 'AuthFailure',
time: 2019-01-16T23:53:05.198Z,
requestId: '3a4648cb-9b1c-4624-8fde-b4174359b09f',
statusCode: 401,
retryable: false,
retryDelay: 24.198964719436013 } 'AuthFailure: AWS was not able to validate the provided access credentials\n at Request.extractError (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/services/ec2.js:50:35)\n at Request.callListeners (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/sequential_executor.js:105:20)\n at Request.emit (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/sequential_executor.js:77:10)\n at Request.emit (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:683:14)\n at Request.transition (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:22:10)\n at AcceptorStateMachine.runTo (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/state_machine.js:14:12)\n at /usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/state_machine.js:26:10\n at Request. (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:38:9)\n at Request. (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:685:12)\n at Request.callListeners (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/sequential_executor.js:115:18)'
error { AuthFailure: AWS was not able to validate the provided access credentials
at Request.extractError (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/services/ec2.js:50:35)
at Request.callListeners (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
at Request.emit (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
at Request.emit (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:683:14)
at Request.transition (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/request.js:685:12)
at Request.callListeners (/usr/lib/node_modules/awespottr/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
message: 'AWS was not able to validate the provided access credentials',
code: 'AuthFailure',
time: 2019-01-16T23:53:05.198Z,
requestId: '3a4648cb-9b1c-4624-8fde-b4174359b09f',
statusCode: 401,
retryable: false,
retryDelay: 24.198964719436013 }
[18:53]:apl@adeaseweb::>

Allow searching for spot prices in specific regions rather than across all regions.

Add display of the average spot prices over a time period (i.e. last day) in addition to the last spot price.

Add command line option for outputting only information about the cheapest region, including region name and spot price.

Gather the on-demand/reserve prices for instances and display comparisons, including:

• Show percent discount from on-demand price
• Highlight spot prices that exceed on-demand price