Comments (7)
heitorlessa
commented on August 17, 2024
2
Yeah. That and the fact you can't search was the rational since you're looking at sampling data (trace).
Logs on the other hand gets indexed, and can be searched.
Tracing metadata, on the other hand, is used when the trace call itself doesn't give you much so it's your next step to solve a problem, specially an Exception or response.
Hope that makes sense -- I'll implement the ability to disable this behaviour in the Python lib on Friday
from powertools-lambda-java.
heitorlessa
commented on August 17, 2024
1
Hey - I’m confused, isn’t the default behaviour to capture exception and
response, but with an option to disable it if they don’t want it?
Tracing data is expired after 30 days, and you can’t search on
metadata/exceptions like you can in Logs. It’s safer to have that data and
save the day when needed than the other way around — With an explicit
update in the docs saying this is how to disable this behaviour.
…On Mon, 17 Aug 2020 at 22:10, Pankaj Agrawal ***@***.***> wrote:
Closed #34
<#34> via #35
<#35>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBDAYYN3X4YMLHKZJBDSBGFBXANCNFSM4QBZQJWQ>
.
from powertools-lambda-java.
pankajagrawal16
commented on August 17, 2024
Hey @heitorlessa , Yeah indeed the default behavior was that. We thought of making the experience consistent with regards to logevent flag for logger, where we don't log events by default until user explicitly enables that.
We can discuss this further, point you made regarding 30 days retention is also a valid consideration.
What do you think @msailes @stevehouel ?
from powertools-lambda-java.
pankajagrawal16
commented on August 17, 2024
Making the issue open until we close the discussion around it.
from powertools-lambda-java.
pankajagrawal16
commented on August 17, 2024
Makes sense to me. Thanks for the input. Let's see if other agrees too. Its nice to have these discussion as history to come back to it.
from powertools-lambda-java.
stevehouel
commented on August 17, 2024
Yeah agreed with what @heitorlessa said. We should enable Exception and Response tracing by default and give ability to disable it on demand.
from powertools-lambda-java.
pankajagrawal16
commented on August 17, 2024
I guess we all agree with the points made here and also keeping it consistent with python version is a good idea.
from powertools-lambda-java.
Related Issues (20)
- Validation module compatible with batch module HOT 2
- Unexpected error occurred when using powertools in lambda function HOT 6
- Trace Annotations not getting added if Annotation Key has a space in it HOT 11
- Putting metrics fails when POWERTOOLS_METRICS_NAMESPACE is not set HOT 3
- Logging: Trace ID not logged with Java 17 runtime HOT 1
- Feature enhancement: Create a Subsegments for operations handled by Powertools HOT 5
- Logging: print `message` as JSON, instead of wrapping into a string HOT 14
- Exceptions not showing in Traces HOT 1
- RFC: Introduce Version 2
- RFC: Remove support for Java 8 in V2 HOT 7
- Feature enhancement (Logger): automatically intercept Runtime exceptions, and log information HOT 7
- Log level not restored at the end of execution HOT 2
- Support batch secrets retrieval in Parameters module HOT 6
- Maintenance: update jackson and aws-xray-recorder dependencies together HOT 4
- RFC: handle batch messages in parallel in batch module HOT 13
- v2: Example logging configuration needs to be updated HOT 3
- v2 - Params builders do not supply default TransformationManager HOT 1
- bug - v2 - end-to-end tests broken
- AbstractCustomResourceHandler - Unable to send response HOT 2
- LambdaEcsLayout seems to incorrectly serialize the service field HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from powertools-lambda-java.