Labels: severity.Low type.FeatureFlaw
original: brynagoh/ped#3

there are 2 add filter features. one of them is been describe as find feature.

Labels: severity.High type.DocumentationBug
original: e00426142/ped#3

ArrayIndexOutOfBoundsException not caught when whitespace(s) is/are input:

Labels: severity.High type.FunctionalityBug
original: nivikcivik/ped#4

The instructions for transferring data in the UG uses single quotations, rather than backticks to denote a file. Writing the filename as shortlist.txt may be clearer for the users.

This also occurs in other sections of the UG, for example, in the Quick Start section. Surrounding the command in backticks would make it clearer as a command to be run in the terminal.

Labels: severity.Low type.DocumentationBug
original: brandonfoong/ped#3

Perhaps it would be better to set restrictions on the type of input each filter takes in? Maybe could check for illegal characters?

especially since you state what are valid inputs for the "type" field below:

Labels: severity.Low type.FeatureFlaw
original: nivikcivik/ped#5

In the UG, it is stated that if lease_remaining is the parameter to filter by, then the maximum value will be 99.

However, on testing, it seems like bounds checking is not performed, and it accepts values more than 99, negative values, and even strings.

Labels: severity.Medium type.FunctionalityBug
original: brandonfoong/ped#7

As seen from the find result, lease_remaining have values such as 77 years 5 months. Maybe can be more precise on the user input value by number of years and follow by months

Labels: severity.Medium type.FeatureFlaw
original: e00426142/ped#7

Split methods into smaller classes.

Clean up duplicate methods / methods serving same function.

In the UG, the command to run the executable file is given as java -jar hdbuy.java, as shown below. However, the filename of the executable is hdbuy.jar.

Labels: severity.Low type.DocumentationBug
original: brandonfoong/ped#5

":information_source:" is visible; could be confusing to readers

Labels: severity.VeryLow type.DocumentationBug
original: nivikcivik/ped#3

This may not be ideal for fast typers:
I input 2 spaces before 2 and it didnt read my input.
Perhaps you could trim the input before reading it?

Labels: severity.Medium type.FeatureFlaw
original: nivikcivik/ped#10

As a user, I want to search resale flats by location.

User input:
location [location]

Output:
list of units in that location sorted by price, from lowest to highest

This could be an issue for fast-typers. Maybe you could consider making your program take in inputs that are not case sensitive?

Labels: severity.Medium type.FeatureFlaw
original: nivikcivik/ped#8

The UG suggests that one can use save and shortlist, however, during testing, these 2 commands were not interpreted as valid commands.

Labels: severity.High type.DocumentationBug
original: brandonfoong/ped#8

Update the price and remaining lease of shortlisted flats

In the UG, :bulb: is used instead of the corresponding emoji, as shown below:

This also occurs in the instructions of the remove command.

Labels: severity.Low type.DocumentationBug
original: brandonfoong/ped#2

By running any command many times (e.g. filter abc 123), we can get a stack overflow error, as shown below:

This could lead to issues when users run too many commands in a single instance of HDBuy.

Labels: severity.High type.FunctionalityBug
original: brandonfoong/ped#11

Implement a way to show user the query results in TextUi class.

If the filter feature is only able to take in certain values for filter type (eg 1-5 room) in certain format, the right error message should be prompt to the user instead of just take in the value user typed and return no result. I key in filter type 4room and no result came out for the find. Maybe can try to use .contain() to slove this problem.

Labels: severity.High type.FeatureFlaw
original: e00426142/ped#5

Minor typo for header of "find" feature. It could be confusing to readers.

Labels: severity.VeryLow type.DocumentationBug
original: nivikcivik/ped#1

User will enter queries. Once all queries are keyed in, he can then search for flats.

Commands:

location [location] -- String location

type [type] -- 1 room, 2 room, 3 room, 4 room, 5 room, executive, multi generation

lease_remaining[years] -- String years

search --submits all queries and retrieves flats

close --closes the app

Task:
Make use of QueryKey class and form a HashMap.
map.put(QueryKey.LOCATION, "Bedok");
map.put(QueryKey.TYPE, "3 room");
map.put(QueryKey.LEASE_REMAINING, "95");
return map

Labels: severity.High type.DocumentationBug
original: brynagoh/ped#1

input: help
output: all available commands and how to use

This line could be confusing for readers when reading for the first time. Perhaps you could make it a bit clearer?

Labels: severity.Medium type.DocumentationBug
original: nivikcivik/ped#9

As a user, I want to search for units by remaining lease.

User input:
lease [years_left]

Output:
list of units with lease provided

Filter flats from search results by price

Logic: Run other filters first, and fetch results. From results, filter by price.

Input:
budget 1000000

As a user, I want to search for units within a price range.

User input:
price [minprice maxprice]
price [price]

Output:
list of units within price range

The UG suggests that the program will save its contents to shortlist.txt.

However, during an execution, it seems like no new files are created.

Labels: severity.High type.FeatureFlaw
original: brandonfoong/ped#9

In your UG, you stated maximum lease is 99.

However, your program has no upper bound set here. Perhaps you may want to catch this error?

For upperbound:

For lowerbound:

Labels: severity.Medium type.FeatureFlaw
original: nivikcivik/ped#6

When user key in double value for filter lease_remaining , UI did not show an error message to tell the user it is an invalid input. It will take in whatever values user type and resulting in zero finding result.

Labels: severity.Medium type.FunctionalityBug
original: e00426142/ped#4

When (single space character) is provided as the input to the program, it crashes with the following error message:

Labels: severity.High type.FunctionalityBug
original: brandonfoong/ped#4

The user guide writes that the maximum lease is 99, but the user is able to input negative values or values more than 99. Although 'find' returns no flats, it may be more intuitive to the user to warn them which values are invalid.

Labels: severity.Low type.FeatureFlaw
original: brynagoh/ped#2

When there are no shortlisted HDB flat and User type in save the UI will only return two line without any error message telling the user what went wrong.

Labels: severity.Medium type.FunctionalityBug
original: e00426142/ped#1

Dataset: https://data.gov.sg/dataset/resale-flat-prices

Allow commands to fetch resale flats from dataset.

If filter is given as a command to the program without any arguments, it crashes the program immediately with the following error message:

Labels: severity.High type.FunctionalityBug
original: brandonfoong/ped#10

When the user trying to shortlist a HDB flat using save feature and key in index that does not exist in the list of HDB found (eg. 101 out of 100) no error message is been returned by the UI.

Labels: severity.Medium type.FunctionalityBug
original: e00426142/ped#2

As a user, I want to search for units matching a flat type.

User input:
type [type] -- 1 room, 2 room, 3 room, 4 room, 5 room, executive, multi generation

Output:
list of units with the type

Clear all current filter conditions
List all current filter conditions

Labels: severity.Low type.FunctionalityBug
original: brynagoh/ped#4

'sort asc' and 'sort desc' will have outputs, but 'find' will say that there are no parameters currently. Currently, it is rather confusing to identify when the filters are reset.

Labels: severity.Medium type.FunctionalityBug
original: brynagoh/ped#5

UG is lack of details and still have many grammatical error.
Can improve on Introduction of the app by giving more details. This sentence should be "HdBuy allows you to find and bookmark available resale flats that matches your preferences easily."
Can add more quick search links.

Labels: severity.Medium type.DocumentationBug
original: e00426142/ped#6

Input:
sort high
sort low

Output:
The list of flats sorted by respective order

the ":bulb:" is visible at 2 places; could be confusing to readers

Labels: severity.VeryLow type.DocumentationBug
original: nivikcivik/ped#2

In the UG, it is stated that strings with spaces can be used as the input for the parameter location.

However, when running the program, it seems like only the first word is taken, as shown below:

Labels: severity.Medium type.FunctionalityBug
original: brandonfoong/ped#6

In this case, if there should be an error here, maybe it can be "Invalid input" error and not a "Number of parameters error":

Labels: severity.Medium type.FunctionalityBug
original: nivikcivik/ped#7

After executing the help command, the following output is shown:

This is different from the expected output in the UG, which shows a list of all commands. A screenshot of the UG at the point of the Demo PE is attached below.

Labels: severity.Medium type.FeatureFlaw
original: brandonfoong/ped#1