ballaerospace / cosmos Goto Github PK

Improve coverage and code quality.

The main.sh files all need to have dos2unix run on them and the executable bit set. When creating the gem on windows git needs to have been configured to not convert crlf otherwise the gem will be made with bad main.sh files. The git setting core.autocrlf needs to be "input" not "true" or the local files that are put into the gem will have bad line endings in them when the gem is created. You will probably need to delete and reclone the repository after changing this setting.

This is now possible because INTERFACE_TARGET can take alternative filenames for cmd_tlm_server.txt.

BinaryAccessor has been on my todo for a while. It always shows up with tons of duplication and complexity.

The UNKNOWN target is created with an UNKNOWN command and an UNKNOWN telemetry packet that have no parameters/items. When you call commands.identify or telemetry.identify, if a packet is defined without any ID_PARAMETERS or ID_ITEMS then it is immediately identified with whatever buffer you pass it. Thus the first packet which has no ID items will identify everything. Since the target_names routine sorts the targets, any targets alphabetically past “UNKNOWN” won’t ever get their packets identified.

Make unit tests pass consistently across platforms.

Ensure read conversion cache cannot be cleared mid-use. A poorly timed clear could lead to nil being returned instead of the converted value.

Warn users if reading a packet log uses the latest instead of the version specified in the file header

This mode would create a "User's Guide" that would respect IGNORE_PARAMETER and IGNORE_ITEM. @dholshou

Automatically requiring a new stream protocol is not functional in stream_interface.rb. Cleanup and use Cosmos.require_class to fix.

Fix autohotkey script for TlmExtractor and add print method to pry_dialog to handle new pry version behavior.

Use Bundler Correctly for App installs. The involves adding a call to require 'bundler/setup' to each of the tool launchers.

Bug in MACRO prevents it working with more than one item between MACRO_APPEND_START and MACRO_APPEND_END. \

Block count is not number of lines and 10000 is too much.

User's have requested that ask() take a default value as many times they are asking for multiple parameters but only one actually changes. The current API is ask(question, allow_blank = false, password = false). Password was just added in 3.2.0. I don't want to break the API but I feel like the default parameter should be second as it's more likely to be used than blank and password. I also think blank is least likely and should be last. Should we create a new method "ask_default" and eventually switch ask to it after a deprecation warning? Or do we continue to simply tack on parameter to the end of methods without any though of usage and consistency?

Ruby 2.1 implemented nonblocking IO without exceptions. See https://dl.dropboxusercontent.com/u/582984/again_5138.pdf and https://bugs.ruby-lang.org/issues/5138 for the full discussion.

I've seen the Telemetry Grapher crash due to a "Comparison of Float with Float failed" error. I think the only way you can get this is if one of the values is a nan. By default the json_drb code allows nans and thus nans can be returned from the server. Somewhere the telemetry grapher needs to handle nans so the scaling code works. I'm not sure if it should replace nans with zero or simply remove them which would result in a blank spot in the graph. The first solution might look like real data might might be confusing. The second solution would result in a hole in the graph that might be confused with a telemetry drop out.

@jmthomas Looks like your refactoring broke this. Please fix.

Using the 'should_clean' and 'transpec' gems this should be automatic.

I've seen COSMOS occasionally open a log file, immediately close it, and then open another log file with the '_1.bin' extension. Seems like there is a rare race condition when starting a new log file that causes it to be closed and another opened.

@jmthomas This is a regression. It probably occurs with graphing any integer. Put definitely occurs when graphing states.

It is getting really big and should include a scroll bar.

Update the templates to remove call to System.paths['HANDBOOKS'].
reference

TestRunner build_test_suites destroys CustomTestSuite if underlying test procedures change

Dynamically created file for Mac launchers should not be included in CRC calculation

Array items when requested as :FORMATTED or :WITH_UNITS return an array of strings. Derived items that return arrays should behave the same.

Add ccsds_log_reader.rb as an example of alternative log readers

Persistence should be applied even if changing from stale. This allow persistence to handle initial startup issues as well are spurious issues while running.

Gem dependencies are interpreted at gem build time so the current method does not end up requiring ruby-termios if built on windows. Update to adding ruby-termios to Gemfiles and move to a extension compile time install of ruby-termios if not on windows.