chrisfosterelli / akismet-api Goto Github PK

Node 4 has come out, I'd like to add official support for it. I'd also like to look at what else Travis supports for node versions and see about running tests on those.

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml
• The new Node.js version is in-range for the engines in 1 of your package.json files, so that was left alone

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Dependencies are currently out of date

Because why not?

Non-SSL references to the akismet website should be SSL.

Version 9.0.23 of nock was just published.

This version is covered by your current version range and after updating it in your project the build failed.

nock is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hi,
first thank you for your great job on this client api.
Then, do you think it is possible to add support for "honeypot_field_name" & "hidden_honeypot_field", it is the only option which is present in the api Akismet and which is not present in your client. This could be useful to allow additional filtering.
Thank you in advance.

I recently encountered an issue within a Next.js application after installing akismet-api version 6.0.0. When I attempt to use the Akismet client in my Next.js route handler, I receive the following error: TypeError: hexoid is not a function.

Environment
Node.js Version: 18.7.0
Next.js Version: 14.3.2
Akismet API Version: 6.0.0

In the "Promises and Callbacks" section, I mention that the rest of the README will use callbacks. We should provide a Promise-based version of the documentation that uses promises in the examples, and link to that README version from the "Promises and Callbacks" section.

The user agent is a hardcoded version string. I'd like to get this from the package.json file instead.

Dependencies are out of date, this should be a quick fix to update.

I'd like to add explicit support for using akismet-api in the browser

David DM is no longer available

This would be a nice section to have

I'd like to look at moving away from superagent and toward request, as request seems to be the more defacto standard nowadays. I'll have to code it up and see if it's better, worse, or the same for readability and usability.

The dependency bluebird was updated from 3.5.3 to 3.5.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

bluebird is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

We can get a dev akismet key and use some of the hardcoded test behaviours to make sure that everything works end-to-end, which'll help augment the unit tests.

Could not find a declaration file for module 'akismet-api'. '.../node_modules/akismet-api/lib/akismet.js' implicitly has an 'any' type.
Try npm install @types/akismet-api if it exists or add a new declaration (.d.ts) file containing declare module 'akismet-api';ts(7016)

As well as checkSpam, submitHam and submitSpam support the property is_test so you don't need to worry about make fake submits when you are testing

Akismet is upgrading the requests anyway, but this will reduce request time and improve security.

Since this project no longer supports node 0.8, we can remove the setimmediate shim.

Version 3.6.1 of superagent just got published.

This version is covered by your current version range and after updating it in your project the build failed.

superagent is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Our tests should test both the promise and callback interfaces to the library.

Although I'm pretty sure we can trust bluebird to do it's job properly, we may be accidentally not passing something in a promise-y way and it'd be good to have explicit tests for how that's consumed in promise land.

Let's keep it modern, would be good to have this in ES6 using Babel.

The is_test option (https://akismet.com/development/api/#comment-check) would be very handy, especially when running integration tests on my application.

Appears easy enough to implement but would be willing to submit a pull request if required :)

All of the functions take fields like this:

  user_ip : '123.123.123.123',              // Required!
  user_agent : 'MyUserAgent 1.0 Webkit',    // Required!
  referrer : 'http://google.com',           // Required!
  permalink : 'http://myblog.com/myPost',
  comment_type : 'comment',
  comment_author : 'John Smith',
  comment_author_email : '[email protected]',
  comment_author_url : 'http://johnsblog.com',
  comment_content : 'Very nice blog! Check out mine!'

It would be very nice to change these to proper JS style attributes (Ex: userIp), potentially with nested objects like comment.

This would be a breaking change and create a new major version

Exists in node 13.x, coming to LTS in 14.x soon.
For import to work with named imports the module specifically has to support it, or else users can only import as the exported object as a default export.

Akismet no longer requires this field, so we should update our docs to match.

Node 8 is out \o/ Need to add travis CI tests

Legal license should now be for Two Story Robot Labs Inc.

It looks like Nock no longer supports node 0.8, so we can't upgrade our nock dependency until we let go of node 0.8 as well.

0.8 is quite old, and right now we only "kinda" support it since we use the caret format. Given that it is EOL I'm more inclined to remove 0.8 support and update nock to the latest version.

Version 3.4.0 of mocha just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As mocha is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

It would be great to have promise support in addition to traditional callback support

The lowest version we support is Node 8 now, which means native Promise support is pretty good. We might not need to use bluebird anymore. Bluebird is great but this could clear up a dependency which is always a perk!