Giter VIP home page Giter VIP logo

Comments (7)

cleydyr avatar cleydyr commented on July 21, 2024 1

Hey, @NicolaIsotta, @arnis87 . I've released version 0.1.1. Can you check it out?

from dart-sass-maven-plugin.

NicolaIsotta avatar NicolaIsotta commented on July 21, 2024 1

Hi @cleydyr , it's working now in my project. Thanks!

from dart-sass-maven-plugin.

arnis87 avatar arnis87 commented on July 21, 2024 1

Hi,
Yes, it works for me also. Thank you very much!

from dart-sass-maven-plugin.

cleydyr avatar cleydyr commented on July 21, 2024

Hey, @arnis87 . Thanks for reporting this issue.

Can you share a repo where you can reproduce this behavior along with additional steps (if needed) to reproduce it?

from dart-sass-maven-plugin.

NicolaIsotta avatar NicolaIsotta commented on July 21, 2024

Got the same error code, I'm not sure if it is for the same reason though.
I have a complex folder structure and the plugin currently does not handle subfolders:

dart-sass-maven-plugin/src/main/java/com/github/cleydyr/maven/plugin/CompileSassMojo.java

Lines 256 to 278 in 9833835

Path inputFolderPath = inputFolder.toPath();
try {
fileCount = Files.list(inputFolderPath).count();
Files.list(inputFolderPath)
.forEach(
inputFilePath -> {
Arrays.stream(ALLOWED_EXTENSIONS)
.filter(inputFilePath.toString()::endsWith)
.forEach(
extension -> {
Path outputFilePath =
_createHomonymousFile(
inputFilePath, extension);
sassCommandBuilder.withPaths(
inputFilePath, outputFilePath);
});
});
} catch (IOException e) {
throw new MojoExecutionException("Can't list folder " + inputFolderPath, e);
}

I replace all that code with a single line:

        sassCommandBuilder.withPaths(inputFolder.toPath(), outputFolder.toPath());

And now it works flawlessly.
I do not think there's need to check each file, Dart Sass already does that.

from dart-sass-maven-plugin.

NicolaIsotta avatar NicolaIsotta commented on July 21, 2024

PS: you should add the source enconding to the pom, otherwise build on windows fails.

from dart-sass-maven-plugin.

cleydyr avatar cleydyr commented on July 21, 2024

Hey, @NicolaIsotta . Thanks for adding this issue. I agree that the behavior should be as close as possible to the one we find in the CLI and the code excerpt that you mentioned is unnecessary if we just pass the inputFolder and outputFolder to the executable. I'll make a PR for that.

from dart-sass-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.