Giter VIP home page Giter VIP logo

Comments (7)

crsh avatar crsh commented on September 24, 2024

Thanks for the excellent reproducible example. This should now be fixed. Let me know if you find other examples where it doesn't work as expected.

from citr.

Robinlovelace avatar Robinlovelace commented on September 24, 2024

Confirmed: it now works again. Great work!

devtools::install_github("crsh/citr")
#> Skipping install of 'citr' from a github remote, the SHA1 (aab8006e) has not changed since last install.
#>   Use `force = TRUE` to force installation
download.file("https://github.com/ITSLeeds/stats19/raw/master/README.Rmd", "test.Rmd")
download.file("https://github.com/ITSLeeds/stats19/raw/master/vignettes/references.bib", "references.bib")
citr::tidy_bib_file(rmd_file = "test.Rmd", messy_bibliography = "references.bib")
#> Warning in do_read_bib(file, encoding = .Encoding, srcfile): encoding
#> 'native.enc' will be ignored
#> Removing 4 unneeded bibliography entries.
#> Writing 2 Bibtex entries ... OK
#> Results written to file 'references.bib'

Created on 2019-02-06 by the reprex package (v0.2.1)

from citr.

Robinlovelace avatar Robinlovelace commented on September 24, 2024

Heads-up @crsh, sorry, but I've just found another edge case. Please try this:

devtools::install_github("crsh/citr")
#> Skipping install of 'citr' from a github remote, the SHA1 (aab8006e) has not changed since last install.
#>   Use `force = TRUE` to force installation
download.file("https://github.com/ITSLeeds/TDS/blob/master/slides/2-software.Rmd", "test.Rmd")
download.file("https://github.com/ITSLeeds/stats19/raw/master/vignettes/references.bib", "references.bib")
citr::tidy_bib_file(rmd_file = "test.Rmd", messy_bibliography = "references.bib")
#> Error in citr::tidy_bib_file(rmd_file = "test.Rmd", messy_bibliography = "references.bib"): Found no references in test.Rmd

Created on 2019-02-06 by the reprex package (v0.2.1)

Note: if I move the reference from line 105 to line 30, for example, it no longer claims there are no references in there. Please try to reproduce and let me know. Thanks!

from citr.

crsh avatar crsh commented on September 24, 2024

Thanks, I'll take a look.

from citr.

Robinlovelace avatar Robinlovelace commented on September 24, 2024

Great. I realised the file was changing. Have re-added a reference that is not found - the test should work now. Thanks!

from citr.

crsh avatar crsh commented on September 24, 2024

This was due to overly aggressive sanitizing of the R Markdown file. I had not come across this issue because I hadn't tried it on xaringan slides. It should work now, but I get an error that reference was not found in the look-up bibliography. Thanks again for the excellent reports. They made debugging a breeze. 👍

from citr.

Robinlovelace avatar Robinlovelace commented on September 24, 2024

Great fixes. They teach me lots about regex!

from citr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.