crystal-nest / soul-fire-d Goto Github PK

Hello, I am on Forge 43.2.4 for 1.19.2. Mod version soulfired- 1.19.2-3.0.0.0.
I believe there is an issue with the bow enchantment or I am misunderstanding its use.
I am playing with mods however there are no compatibility issues.
When a bow has the soul_flame enchantment on it, the arrow burns red and does not seem to benefit from being fired through soul fire. Mobs hit also do not burn blue but instead ignite as if hit with normal flame.
Arrows fired from an unenchanted bow through soul fire take on the blue hue and deal additional damage. Mobs hit with these arrows burn blue.
Mobs or the player that walk into soul fire burn blue and take additional damage.
The sword enchantment soul_flame_aspect works perfectly with no issues.

Describe the bug

• Entity drops do not appear.
• Villagers "rotate" in their beds, as if the head movement they are supposed to do was affected to the whole body
• The second layer of any player's skin is completely absent.

To Reproduce
Steps to reproduce the behavior:

1. Start (or try to connect to) a server that does not have Soul Fire'd installed WITH the client having it installed.
2. Take a look at entity drops, villagers trying to sleep and other people's skins.
   ... That's pretty much it. I have been able to single it out because I have been re-enabling mod by mod on a debug server to find 2 problematic mods, and unfortunately Soul Fire'd was one.

Expected behavior
We should be able to percieve the world with its entities and correct rendering.

Screenshots
Those 3 pictures were taken with Soul Fire'd enabled on the Client, but not the server.



Once it has been properly installed, stuff returns to normal (notice the skin layers and wood drops)

System information:

• Minecraft version: 1.19.2, Tested with 1.20.1 too!
• Mod version: 3.2.0.0, Fabric (Forge Config API Port was at its max version for 1.19.2)

Additional context
here are some 1.20.1 screenshots

Aaaaaand here it is after installing Soul Fire'd.

Thank you for your work and your mod and have a very nice day!!

Is your feature request related to a problem? Please describe.
Blaze+soul fire=soul fire blaze, soul fire blaze+fire=blaze. That would be cool.

Describe the solution you'd like

1. Blaze takes soul fire damage, but it would turn into soul fire blaze after few seconds(with item.firecharge.use effect). Soul fire blazes are immune to soul fire damage, but takes vanilla fire damage. So when it takes vanilla fire damage, it would turn back to normal blaze shortly after.
2. Soul blazes replace blazes in soul sand valley.
3. Doesn't affect blaze that has nametag or custom nbt tags.

Describe alternatives you've considered
Soul fire blaze spawns naturally(turned off by default) with configurable weight. Could be seen as an elite blaze.

Additional context
Fun and resonable, but may be a bit too much?

Add the list of compatible mods both in the readme and in the wiki.
Invite authors to open PRs to add their mod to the list.

• BYG
• DangerClose
• Decorative Blocks

See https://www.curseforge.com/minecraft/mc-mods/soul-fired?comment=9

LodestarMC/Aileron#13

Attempting to start the two as of late causes the game to crash really early on.

Describe the bug

• Items are not render in the Item Frame
• Entities have a default texture instead of a variant texture
• Entities do not have a baby model

To Reproduce
Steps to reproduce the behavior:

1. Launch world
2. Look at the entities

Expected behavior

• Normal visual

Screenshots

ain(Main.java:253) ~[1.20.2-0.15.2.jar:?]

System information:

• Minecraft version: 1.20.2 Fabric [Loader 0.15.2]
• Mod version:
  [soulfired-1.20.2-3.2.1.0-fabric]
  [ForgeConfigAPIPort-v9.1.2-1.20.2-Fabric]
  [fabric-api-0.91.2+1.20.2]

Additional context
[19:39:10] [Render thread/ERROR]:
Error executing task on Client
java.lang.IllegalStateException: Invalid entity data item type for field 17 on entity class_1472['����'/119389, l='ClientLevel', x=1272.45, y=85.00, z=1160.55]: old=false(class java.lang.Boolean), new=17(class java.lang.Byte)
at net.minecraft.class_2945.method_12785(class_2945.java:204) ~[client-intermediary.jar:?]
at net.minecraft.class_2945.method_12779(class_2945.java:191) ~[client-intermediary.jar:?]
at net.minecraft.class_634.method_11093(class_634.java:516) ~[client-intermediary.jar:?]
at net.minecraft.class_2739.method_11808(class_2739.java:46) ~[client-intermediary.jar:?]
at net.minecraft.class_2739.method_11054(class_2739.java:10) ~[client-intermediary.jar:?]
at net.minecraft.class_2600.method_11072(class_2600.java:23) ~[client-intermediary.jar:?]
at net.minecraft.class_1255.method_18859(class_1255.java:156) ~[client-intermediary.jar:?]
at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[client-intermediary.jar:?]
at net.minecraft.class_1255.method_16075(class_1255.java:130) ~[client-intermediary.jar:?]
at net.minecraft.class_1255.method_5383(class_1255.java:115) ~[client-intermediary.jar:?]
at net.minecraft.class_310.method_1523(class_310.java:1231) ~[client-intermediary.jar:?]
at net.minecraft.class_310.method_1514(class_310.java:856) ~[client-intermediary.jar:?]
at net.minecraft.client.main.Main.main(Main.java:253) ~[1.20.2-0.15.2.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) ~[fabric-loader-0.15.2.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.15.2.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.15.2.jar:?]

Soul flame, acts like regular flame on crossbows.

Would realy like it if the soul flame enchantment worked correctly on crossbows, making the flame blue and causing soul burning. I'm not asking for soul flame to be compatible with crossbows, I already have a mod for that.

I'm using universal enchants to get the soulflame enchantment on the crossbow.

I'm thinking that every minecraft enchantment seems pretty balanced, so why soul flame enchant will damage more but also doesn't have a negative stat.

Here my ideas:

• Released arrows can't be pick-able
• Released arrows can set you on soul fire after you pick them / regular flammable arrows could do this too
• Soul fire burning can be half duration compare to regular flame (you be able to choose between fast high damage or slow but longer damage)
  (I prefer this one) ↑
• Soul fire arrows fly only half a distance

CurseForge comment
https://www.curseforge.com/minecraft/mc-mods/soul-fired?comment=14

Vanilla (withou mod)
https://youtu.be/dlMtqTkAeEA

Fabric (with mod)
https://youtu.be/MmcXnd_dqlE

I have confirmed no other issue asks for this

• I have searched for existing issues

Desired behavior

• Rewrite to comply with Cobweb Mod Template.
• Add Cobweb API dependency.
• Update NeoForge version.

Current behavior

No response

Additional context

No response

Greetings! I made a Russian localization for you mod <3

{
  "enchantment.minecraft.soul_fire_aspect": "Заговор души",
  "enchantment.minecraft.soul_flame": "Воспламенение души",
  "enchantment.minecraft.soul_fire_aspect.desc": "Поджигает душу цели и наносит ей дополнительный урон.",
  "enchantment.minecraft.soul_flame.desc": "Выпущенные стрелы поджигают душу цели и наносят ей дополнительный урон."
}

Describe the bug
I am using a mod called Ultris as well as your mod Soul Fire'd, the Ultris mod generates new dungeons and bosses, one of which places a boss on top of a Soul Sand block which has Soul Fire on top of it. This boss is "immune" until you snuff out the Soul Fire and then the boss fight actually begins.

The thing is, I think that your mod has an issue whenever there is a mob standing on top of Soul Fire indefinitely without receiving damage, which causes a lot of Area of Effect Cloud entities to start spawning in a never ending loop.

In this scenario, until the boss is disturbed, the Soul Fire'd mod is creating an infinite amount of Area of Effect Clouds that causes my server to overload and eventually crash because of the Server Watchdog that gets called in response of a tick loop. (I think the latter might be caused by this incompatibility)

To Reproduce
Steps to reproduce the behavior:

1. Install the latest version of Soul Fire'd (3.1.0.0) for Forge 45.0.64 and Minecraft 1.19.4
2. Have an immune mob standing still on top of Soul Fire and for an indefinite amount of time
3. Use F3 and look directly in the direction of the Soul Fire and check on the number of entities that are present in front of you.

Expected behavior
There should be a constant increasing amount of entities spawning, in this case, they should be Area of Effect Cloud entities.

Screenshots
If applicable, add screenshots to help explain your problem.

1. https://github.com/Nyphet/soul-fire-d/assets/96800456/90689e44-a366-4a1c-ad31-8e9e4d24a79d
2. https://github.com/Nyphet/soul-fire-d/assets/96800456/0f2153f9-6357-4e84-b798-0e7cb94f9963

Video I recorded showcasing the bug:

1. https://youtu.be/cJiB4LOtg94

System information:

• Minecraft version: 1.19.4
• Mod version: 3.1.0.0

Additional context
The screenshots I am adding were taken while troubleshooting with another mod called Spark.

Could this mod please be designed to work server-side? Allowing vanilla clients to connect to the server.

I see no problem to display players without the mod just the normal fire animation.

My games crashes with no crash report
i got soulfired along with a bunch of other mods
here is the log:
2023-11-19-1.log

Describe the bug
When using a tetra bow with soul flame, the bow fires normal fire and ignites normal fire
To Reproduce
soul flame on a tetra mod bow
Expected behavior
it should fire soul flames
System information:

• Minecraft version: 1.19.2
• Mod version: 3.2.0.1 forge

Additional context
this only happens with tetra bows and not vanilla bows.

Description
The bug makes items of any kind become invisible but
still be able to be interacted with, it only occurs on multiplayer
but in single player you're able to see the items normally.

How to Reproduce
-install the mod normally
-join any vanilla or vanilla like server
-then drop a item into the ground
-it should be invisible and you should be able to pick it up but not see it.

System information:

• Minecraft version: 1.19.2 (Fabric loader 0.14.21)
• Mod version: soulfired-1.19.2-3.1.0.0-final-fabric

Extra info
The servers that it happened to me where:

5b5t.org
mc.hypermine.net

Is your feature request related to a problem? Please describe.
I'd like to use this mod but I don't want the enchantments.

Describe the solution you'd like
It'd be great if there were a config to disable the adding of enchantments.

Additional context
I'd like to add the mod to a mod set that only adds mechanics, but no 'content' to vanilla.

Describe the bug
Game crashes every time with Soul Fire'd loaded. It used to work just fine, but somewhere along the line it has simply stopped launching as long as Soul Fire'd is enabled. I'm sure it's a mixin conflict somewhere, but I don't have the knowledge to be able to read the logs to tell me exactly which mod or mods it's conflicting with.
Yes I know I'm heavily modified, but everything was working. I had some issues with quilt loader which i fixed by updating, but even rolling back all changes, the game still crashes.
Any assistance would be greatly appreciated!

System information:

• Minecraft version: 1.19.2
• Mod version: 3.2.10

MC Logs
Log Link

Describe the bug
I've seen this has happened before, but cannot know the reason. On latest Fabric 1.18.2 version (and previous one), 1.1.0.0 (and 1.0.0.2), if I add the mod i cannot launch minecraft.

Describe the bug
Mobs on soul campfire will take damage slower than vanilla.

To Reproduce
Steps to reproduce the behavior:

1. Install mod.
2. Summon a husk on soul campfire, it will take damage 1 time per second (1Hz).
3. Uninstall mod.
4. Husk on campfire or soul campfire will take damage 2 times per second (2Hz).

Expected behavior
The damage frequency of mobs on soul campfire is as same as vanilla (2Hz).

System information:

• Minecraft version: 1.16.5
• Forge version: 36.2.35
• Mod version: 3.2.0.0

Describe the bug
removes 2nd skin layer when playing on any minecraft server

To Reproduce
Steps to reproduce the behavior:

1. play on a server with soulfired installed

Expected behavior
not do this shit

Screenshots
before - https://femboy.beauty/_EGD3
after - https://femboy.beauty/gBVyL

System information:

• Minecraft version: 1.20.1 Quilt
• Mod version: v3.2.0.0

Additional context
doesn't do this in private world
:3 thanks

https://femboy.beauty/_y6NR only mods i have installed

Describe the bug

Crash on initialization.

Logs: https://gist.github.com/Footage2-Amply-Pounce/9395665568a0610ffc20b2b6113aef31

To Reproduce

1. Simply install Soul fire'd 1.0.0.1 and launch the game
2. Crash on startup

Expected behavior

No crash.

Screenshots

System information:

• Minecraft version: 1.19.2
• Mod version: 1.0.0.1

Additional context

Version 1.0.0.0 doesn't crash.

Add a clear dependencies section in the readme.

Describe the bug
1 -Soul Fire Aspect doesn't spawn in Bastions, while Soul Flame does.

2 -Soul Flame and Soul Fire Aspect aren't marked as Treasure enchants (like Mending, Frost Walker etc.). I appreciate that they show up in the enchanting table, but considering they're pretty strong and are supposed to be found in Bastions (mid to late game structures), I feel like they're better suited to be treasure-only by default.

To Reproduce
Steps to reproduce the behavior (1):

1. Go to bastion_other_loot_modifier.json in data.

Expected behavior
I'd expect to find entries for both Soul Flame and Soul Fire Aspect. Only the former has one.

Screenshots
Adding the below enables both to spawn, albeit very rarely imo.

System information:

• Minecraft version: 1.16.5 Forge
• Mod version: 3.1.0.0

Additional context
Not really context but more a thank you for making this mod, I love the attention to detail and compatibility this has with other mods ^^

I have a couple of enchantments / curses I believe would be a great feature for this mod.

Weapon Curse: Soul Ignition - Upon dealing damage to a mob your soul ignites dealing damage to you, however any
additional attacks on mobs (while on fire) do increased damage. [Ignites with soul_fire and deals
soul_fire damage]

Armor Enchantment: Spontaneous Blaze - Upon receiving damage the blocks around you are set on fire.

Armor Curse (boots): Wildfire - Everywhere you step ignites the block beneath you.

Instead of using always the Vanilla fire damage as default when no damage value is provided during building a fire, when no damage is specified but a source block is, let the default damage be the damage provided by the source block.
Only if neither damage nor source block are specified fallback to Vanilla fire damage.

Wiki page: Tweaking enchantments

Describe your suggestion/ask your question:
Explain better all the options for the enchantments builder and fix the configuration options descriptions.

it would be cool if soulfork sets enemies on soulfire instead of normal fire

impaled mod: https://www.curseforge.com/minecraft/mc-mods/impaled

Mod appears to crash with Quilt 1.19.2 when using Fabric 1.19.2 builds of the mod. I am using 1.19.2 due to the decisions of some mod authors that I cannot control.

https://gist.github.com/Sunconure11/e82776e6ff8b7a1a136bbfcc4e7074e1

Describe the bug
On servers using firework rockets while flying doesn't boost you forward

To Reproduce
Steps to reproduce the behavior:

1. Join a server
2. Fly with an elytra
3. Use a firework rocket

Expected behavior
For the firework to boost you forward in the air

System information:

• Minecraft version: 1.20.1
• Mod version: Fabric 1.20.1 v3.2.0.0

Describe the bug
soul fire aspect and fire aspect can be put on the same weapon.

To Reproduce
get anvil, put soul fire and fire aspect onto the same weapon, no issues. it's also happened to me via regular enchanting.

Expected behavior
nothing breaks, but it doesn't make a whole lot of sense? soul fire overwrites fire aspect, so it does more damage, but it doesn't make sense why it could happen.

Screenshots

System information:

• Minecraft version: 1.18.2
• Mod version: 2.0.0.1

Additional context
along with this, exclusivity with Ensorcellation's frost aspect would be nice!

To Reproduce
Steps to reproduce the behavior:

1. Go into a world with "Mobz" and Soul Fired loaded.
2. Spawn the zombie, (or wait for it to spawn, your choice, haha), you can use /summon mobz:fast, not sure if it has a spawn egg.
3. Set the zombie on fire. Both soul fire and normal fire make the game crash.

Expected behavior
Game freezes approx 3 seconds after zombie is set on fire and then crashes with the error message below.

Screenshots

System information:

• Minecraft version:1.19.2
• Mod version: 3.2.1.0

Additional context
This crash report from my server mentions a Herobrine mod I have installed, so it might also have something to do with it. Not sure though, as I had soul fired and that mod installed way before I installed "Mobz", and it never crashed. Just disabling soul fired also fixes the issue.
crash-2024-01-29_19.26.30-server.txt

Allow modpack creators to add support for modded fire from other mods by using a datapack & resourcepack combo

idk why but soul flame doesnt make blue flame arrows for some reason but it works when i shoot through a soul fire block
doesnt work with vanilla bow and modded ones

Describe the bug
A clear and concise description of what the bug is.

Game crashes on startup, when installed alongside Spiders 2.0

To Reproduce
Steps to reproduce the behavior:

1. Install both this mod and spiders 2.0
2. launch the game.
3. Game crashes.

Expected behavior
A clear and concise description of what you expected to happen.

Game should not crash.

Screenshots
If applicable, add screenshots to help explain your problem.

System information:

• Minecraft version: 1.16.5
• Forge 36.2.39
• Mod version: 2.0.0.0 & 1.1.0.0 (tested both)

Additional context
Add any other context about the problem here.

latest.log here: https://pastebin.com/mJpaqG9m

No crash logs were generated.