Giter VIP home page Giter VIP logo

bidsme's People

Contributors

aardkronkel avatar chrisgorgo avatar ghammad avatar marcelzwiers avatar nbeliy avatar roscha avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

bidsme's Issues

JOSS Review — Quality of writing

As part of the JOSS review: openjournals/joss-reviews#5575

Suggestions:

  1. Please consider splitting the source code over more lines, ideally one line per sentence to make things easier to reference.
  2. Please consider using the term “directories” instead of “folders”. Directories are file system entities, whereas folders are graphical interface features.

Minor issues:

  1. Python is a proper noun and should be capitalized, at least in formal writing; python is a type of snake.

Major issues:

  1. “imposing only the core of BIDS -- the folder structure, the file naming style and the global metadata”. The term “global metadata” is unclear so you would need to introduce and explain it. To my knowledge, “global metadata” is not a core concept in BIDS. I would guess you mean simply dataset_description.json — but then again, you do not show this file, but you show e.g. participants.tsv, a different metadata file, in the figure.

JOSS review - examples

Ahoi hoi @nbeliy & co-authors,

this is in reference to the review I'm currently conducting for JOSS here .

First of all, thank you very much for your dedicated work on this tool and your respective submission to JOSS.
Based on the review process and included checkboxes, I would like to suggest a few things.

Concerning the examples, I would like to suggest streamlining the existing example and maybe splitting it across fewer files to make it easier for interested users to follow and add examples for the other modalities you support. Both points target utilization and adaptation by the community.

I'm very sorry if I missed something obvious, misunderstood something or assumed something wrong. Please let me know if that is the case, as well as if you have any questions. Thanks again for creating this important software tool.

Cheers, Peer

JOSS Review — Test suite

As part of the JOSS Review → openjournals/joss-reviews#5575

This is analogous with the issue raised here #7

I fully appreciate that it can be difficult to formulate exhaustive or even just comprehensive tests for scientific software, but without a test suite it is impossible for me to determine whether the software can do anything at all.

The other reviewer has mentioned github workflows, which are a very useful feature. However if for some reason you don't want to do that, I'd be satisfied with just a few tests I can run locally, covering some of the functionalities mentioned in the article.

`bidsme map` raises no error but `bidsme bidsify` does

While building the bidsmap for a dataset, I ended up with bidsme map raising no error at all but once I run bidsme bidsify, I get FileExistsError.

This means that bidsme map does not capture some existing conflicts. Maybe this should be fixed to make the process of creating the bidsmap less frustrating. It looks to me like one of the sanity checks performed during bidsme map should handle this.

JOSS Review — Installation Proof

As part of the JOSS review: openjournals/joss-reviews#5575

Could you confirm that the following files constitute a successful installation of the package?

decohost ~ # equery f bidsme
 * Searching for bidsme ...
 * Contents of dev-python/bidsme-1.4.4:
/usr
/usr/bin
/usr/bin/bidsme -> ../lib/python-exec/python-exec2
/usr/bin/bidsme-pdb -> ../lib/python-exec/python-exec2
/usr/lib
/usr/lib/python-exec
/usr/lib/python-exec/python3.11
/usr/lib/python-exec/python3.11/bidsme
/usr/lib/python-exec/python3.11/bidsme-pdb
/usr/lib/python3.11
/usr/lib/python3.11/site-packages
/usr/lib/python3.11/site-packages/bidsme
/usr/lib/python3.11/site-packages/bidsme-1.4.0.post4.dist-info
/usr/lib/python3.11/site-packages/bidsme-1.4.0.post4.dist-info/METADATA
/usr/lib/python3.11/site-packages/bidsme-1.4.0.post4.dist-info/RECORD
/usr/lib/python3.11/site-packages/bidsme-1.4.0.post4.dist-info/WHEEL
/usr/lib/python3.11/site-packages/bidsme-1.4.0.post4.dist-info/entry_points.txt
/usr/lib/python3.11/site-packages/bidsme-1.4.0.post4.dist-info/top_level.txt
/usr/lib/python3.11/site-packages/bidsme/Modules
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/BrainVision.py
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/EDF.py
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/EEG.py
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/_EDF.py
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/_EEG.py
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/_MNE.py
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__init__.py
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/BrainVision.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/BrainVision.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/BrainVision.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/EDF.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/EDF.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/EDF.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/EEG.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/EEG.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/EEG.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/_EDF.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/_EDF.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/_EDF.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/_EEG.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/_EEG.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/_EEG.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/_MNE.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/_MNE.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/_MNE.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/EEG/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/DICOM.py
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/MRI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/NIFTI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/_DICOM.py
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/_MRI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__init__.py
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/DICOM.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/DICOM.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/DICOM.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/MRI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/MRI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/MRI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/NIFTI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/NIFTI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/NIFTI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/_DICOM.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/_DICOM.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/_DICOM.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/_MRI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/_MRI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/_MRI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/_hmriNIFTI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/_hmriNIFTI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/_hmriNIFTI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/bidsmeNIFTI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/bidsmeNIFTI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/bidsmeNIFTI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/hmriNIFTI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/hmriNIFTI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/hmriNIFTI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/jsonNIFTI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/jsonNIFTI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/__pycache__/jsonNIFTI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/_hmriNIFTI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/bidsmeNIFTI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/hmriNIFTI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/MRI/jsonNIFTI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/DICOM.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/ECAT.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/NIFTI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/PET.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/_DICOM.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/_ECAT.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/_PET.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__init__.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/DICOM.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/DICOM.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/DICOM.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/ECAT.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/ECAT.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/ECAT.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/NIFTI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/NIFTI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/NIFTI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/PET.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/PET.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/PET.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/_DICOM.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/_DICOM.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/_DICOM.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/_ECAT.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/_ECAT.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/_ECAT.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/_PET.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/_PET.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/_PET.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/bidsmeNIFTI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/bidsmeNIFTI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/bidsmeNIFTI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/jsonNIFTI.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/jsonNIFTI.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/__pycache__/jsonNIFTI.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/bidsmeNIFTI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/PET/jsonNIFTI.py
/usr/lib/python3.11/site-packages/bidsme/Modules/__init__.py
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/_constants.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/_constants.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/_constants.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/_dicom_common.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/_dicom_common.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/_dicom_common.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/_nifti_common.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/_nifti_common.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/_nifti_common.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/abstract.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/abstract.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/abstract.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/base.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/base.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/base.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/common.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/common.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/common.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/exceptions.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/exceptions.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/exceptions.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/selector.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/selector.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/__pycache__/selector.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_constants.py
/usr/lib/python3.11/site-packages/bidsme/Modules/_dicom_common.py
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/MNE.py
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/_MNE.py
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__init__.py
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/MNE.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/MNE.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/MNE.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/_MNE.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/_MNE.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/_MNE.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/dummy.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/dummy.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/__pycache__/dummy.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/Modules/_formats/dummy.py
/usr/lib/python3.11/site-packages/bidsme/Modules/_nifti_common.py
/usr/lib/python3.11/site-packages/bidsme/Modules/abstract.py
/usr/lib/python3.11/site-packages/bidsme/Modules/base.py
/usr/lib/python3.11/site-packages/bidsme/Modules/common.py
/usr/lib/python3.11/site-packages/bidsme/Modules/exceptions.py
/usr/lib/python3.11/site-packages/bidsme/Modules/selector.py
/usr/lib/python3.11/site-packages/bidsme/__init__.py
/usr/lib/python3.11/site-packages/bidsme/__pycache__
/usr/lib/python3.11/site-packages/bidsme/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/bidsify.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/bidsify.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/bidsify.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/main.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/main.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/main.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/mapper.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/mapper.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/mapper.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/prepare.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/prepare.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/prepare.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/process.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/process.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/__pycache__/process.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/BidsMeta.py
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/BidsSession.py
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/BidsTable.py
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__init__.py
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/BidsMeta.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/BidsMeta.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/BidsMeta.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/BidsSession.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/BidsSession.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/BidsSession.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/BidsTable.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/BidsTable.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/BidsTable.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsMeta/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsify.py
/usr/lib/python3.11/site-packages/bidsme/bidsmap
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__init__.py
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__/_bidsmap.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__/_bidsmap.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__/_bidsmap.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__/_run.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__/_run.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsmap/__pycache__/_run.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/bidsmap/_bidsmap.py
/usr/lib/python3.11/site-packages/bidsme/bidsmap/_run.py
/usr/lib/python3.11/site-packages/bidsme/bidsversion.txt
/usr/lib/python3.11/site-packages/bidsme/exceptions
/usr/lib/python3.11/site-packages/bidsme/exceptions/__init__.py
/usr/lib/python3.11/site-packages/bidsme/exceptions/__pycache__
/usr/lib/python3.11/site-packages/bidsme/exceptions/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/exceptions/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/exceptions/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/exceptions/__pycache__/exceptions.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/exceptions/__pycache__/exceptions.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/exceptions/__pycache__/exceptions.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/exceptions/exceptions.py
/usr/lib/python3.11/site-packages/bidsme/heuristics
/usr/lib/python3.11/site-packages/bidsme/heuristics/bidsmap_template.yaml
/usr/lib/python3.11/site-packages/bidsme/main.py
/usr/lib/python3.11/site-packages/bidsme/mapper.py
/usr/lib/python3.11/site-packages/bidsme/plugins
/usr/lib/python3.11/site-packages/bidsme/plugins/__init__.py
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/entry_points.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/entry_points.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/entry_points.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/exceptions.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/exceptions.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/exceptions.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/plugins.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/plugins.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/plugins.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/template.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/template.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/__pycache__/template.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/entry_points.py
/usr/lib/python3.11/site-packages/bidsme/plugins/exceptions.py
/usr/lib/python3.11/site-packages/bidsme/plugins/plugins.py
/usr/lib/python3.11/site-packages/bidsme/plugins/template.py
/usr/lib/python3.11/site-packages/bidsme/plugins/tools
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/General.py
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/Nibabel.py
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__init__.py
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__/General.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__/General.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__/General.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__/Nibabel.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__/Nibabel.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__/Nibabel.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/plugins/tools/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/prepare.py
/usr/lib/python3.11/site-packages/bidsme/process.py
/usr/lib/python3.11/site-packages/bidsme/table_templates
/usr/lib/python3.11/site-packages/bidsme/table_templates/EEG_channels.json
/usr/lib/python3.11/site-packages/bidsme/table_templates/EEG_electrodes.json
/usr/lib/python3.11/site-packages/bidsme/table_templates/EEG_events.json
/usr/lib/python3.11/site-packages/bidsme/table_templates/participants.json
/usr/lib/python3.11/site-packages/bidsme/tools
/usr/lib/python3.11/site-packages/bidsme/tools/__init__.py
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/__init__.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/__init__.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/__init__.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/appdirs.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/appdirs.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/appdirs.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/config.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/config.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/config.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/config_default.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/config_default.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/config_default.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/info.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/info.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/info.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/paths.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/paths.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/paths.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/tools.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/tools.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/tools.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/yaml.cpython-311.opt-1.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/yaml.cpython-311.opt-2.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/__pycache__/yaml.cpython-311.pyc
/usr/lib/python3.11/site-packages/bidsme/tools/appdirs.py
/usr/lib/python3.11/site-packages/bidsme/tools/config.py
/usr/lib/python3.11/site-packages/bidsme/tools/config_default.py
/usr/lib/python3.11/site-packages/bidsme/tools/info.py
/usr/lib/python3.11/site-packages/bidsme/tools/paths.py
/usr/lib/python3.11/site-packages/bidsme/tools/tools.py
/usr/lib/python3.11/site-packages/bidsme/tools/yaml.py
/usr/lib/python3.11/site-packages/bidsme/version.txt
/usr/share
/usr/share/doc
/usr/share/doc/bidsme-1.4.4
/usr/share/doc/bidsme-1.4.4/README.md.bz2

JOSS review - community guidelines

Ahoi hoi @nbeliy & co-authors,

this is in reference to the review I'm currently conducting for JOSS here .

First of all, thank you very much for your dedicated work on this tool and your respective submission to JOSS.
Based on the review process and included checkboxes, I would like to suggest a few things.

Could you maybe add information concerning

1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

for interested users?

I'm very sorry if I missed something obvious, misunderstood something or assumed something wrong. Please let me know if that is the case, as well as if you have any questions. Thanks again for creating this important software tool.

Cheers, Peer

JOSS review - installation & general structure

Ahoi hoi @nbeliy & co-authors,

this is in reference to the review I'm currently conducting for JOSS here .

First of all, thank you very much for your dedicated work on this tool and your respective submission to JOSS.
Based on the review process and included checkboxes, I would like to suggest a few things.

When I tried to install bidsme following the provided installation guide, I ran into an error saying:

ModuleNotFoundError: No module named 'ruamel'

and thus, I could not evaluate the other tutorials and performance. It might also be nice to add your package to pypi.

Furthermore, it might be beneficial to have everything, ie the software, documentation and examples, in the same github repository and split between github and gitlab as this potentially complicates things for interested users (ie finding information, etc.).
Related to that: the README file could be enhanced by adding more information, e.g. regarding the installation, etc. .

I'm very sorry if I missed something obvious, misunderstood something or assumed something wrong. Please let me know if that is the case, as well as if you have any questions. Thanks again for creating this important software tool.

Cheers, Peer

JOSS Review — Versioning scheme

As part of the JOSS review: openjournals/joss-reviews#5575

decohost_2023-07-27T00:44:36

I would recommend a versioning scheme that is somewhat cleaner. major.minor.patch is best. While I have seen the post and pre suffixes before, they usually reference a date or some more meaningful information that couldn't otherwise be expressed in the major-minor-patch format. post4 sound like it should have been a patch, i.e. 1.4.4.

Not least of all it causes problems for semantic parsing of the version number.

`bidsme map` command should not remove comments from `bidsmap.yaml`

Building the bidsmap.yaml file is a tedious and repetitive task. The template and checked flags are great to have a broad view of what remains to do. Considering the number of fields to fill in, I'd like to be able to add comments to the bidsmap so that I can remember why I made some choices.

For now, adding comments to the bidsmap does not prevent the bidmse map command from running but the comments are removed by the program.

JOSS review - automated tests

Ahoi hoi @nbeliy & co-authors,

this is in reference to the review I'm currently conducting for JOSS here .

First of all, thank you very much for your dedicated work on this tool and your respective submission to JOSS.
Based on the review process and included checkboxes, I would like to suggest a few things.

It would be great if you could add a few automated tests/CI to the repository, e.g. a little github workflow that tests the installation and follows/implements the example you provide.

I'm very sorry if I missed something obvious, misunderstood something or assumed something wrong. Please let me know if that is the case, as well as if you have any questions. Thanks again for creating this important software tool.

Cheers, Peer

JOSS review - documentation

Ahoi hoi @nbeliy & co-authors,

this is in reference to the review I'm currently conducting for JOSS here .

First of all, thank you very much for your dedicated work on this tool and your respective submission to JOSS.
Based on the review process and included checkboxes, I would like to suggest a few things.

IMHO, it would be great if you could add a small documentation (e.g. via ReadTheDocs, as the current state of the repository and split between github/gitlab complicates navigation and finding information a bit. Additionally, this would allow to add API method documentation and integrating the examples.

I'm very sorry if I missed something obvious, misunderstood something or assumed something wrong. Please let me know if that is the case, as well as if you have any questions. Thanks again for creating this important software tool.

Cheers, Peer

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.