danielmschmidt / zipkin-javascript-opentracing Goto Github PK
View Code? Open in Web Editor NEWOpentracing implementation for Zipkin in Javascript
License: MIT License
Opentracing implementation for Zipkin in Javascript
License: MIT License
Hi,
I'm testing your module in one of our "API gateways", acting like "smart HTTP proxies", and I'm curious if it's possible to log some spans as server and some spans as client?
As I understand now the "kind" option is only set per tracer object, so HTTP requests the api gateway is making itself are also marked as "server". But they should be marked as "client".
Is it currently possible?
We currently have flaky E2E tests, because zipkin is an external system we interact with. There are some ways to imrpove this situation:
firstSpan-${+new Date()}
.type
Currently jenkins is red on master, we need to fix this by adding the right environment variables.
I'm having issues using this library as a transport for the opentracing
package via opentracing.initGlobalTracer(tracer);
due to a mismatch in the values of the transport constants.
The result is Error: extract called with unsupported format
when trying to use the tracer to extract
or inject
.
The opentracing
packages has export const FORMAT_HTTP_HEADERS = 'http_headers';
This packages has Tracing.FORMAT_HTTP_HEADERS = "FORMAT_HTTP_HEADERS";
We already have method SetTag which add tags as key value and send it back to collector. I found that you have log method which rather than logging message string sends them as tag which i found is wrong. one way we already have a method which can add tags so log should be doing actual logging.. not adding tags again. that way library will have both way to add tags and add logs separately. however i found that the core tracer which you are using here has already method to log separately. the method is recordMessage. so if you can use that when log is being called, then you would have support for logs as well.
I'll anyway raise PR for it. but you can comment here your thoughts.
Hello,
I am using this library in a react project and i am trying to work it in client side. But i can not apply sampler rate for my requests. When i am searching for the library i see these lines.
this._zipkinTracer = new Tracer({
ctxImpl: new ExplicitContext(),
recorder: options.recorder
});
this._Span = SpanCreator({
tracer: this._zipkinTracer,
serviceName: this._serviceName,
kind: options.kind,
sampler: options.sampler
});
Here, sampler is only applied for span, not for tracer. Why ?
Thanks for your help.
Kerim
This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
These updates are currently rate-limited. Click on a checkbox below to force their creation now.
react
, react-dom
)These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.
react
, react-dom
)These updates have all been created already. Click a checkbox below to force a retry/rebase of any.
e2e-tests/react/package.json
opentracing 0.14.3
react 16.3.1
react-dom 16.3.1
react-scripts 1.1.4
zipkin 0.10.1
zipkin-transport-http 0.10.1
babel-polyfill 6.26.0
cypress 3.8.2
node-fetch 2.1.2
serve 6.5.5
package.json
babel-cli 6.26.0
babel-preset-env 1.6.1
coveralls 3.0.0
express 4.16.3
husky 0.14.3
jest 22.4.3
lint-staged 7.0.4
nodemon 1.17.3
opentracing 0.14.3
prettier 1.12.0
zipkin 0.10.1
zipkin-transport-http 0.10.1
opentracing *
zipkin >=0.10.1
zipkin-transport-http >=0.10.1
website/package.json
docusaurus 1.0.10
Or export them to it
The method Span.addTags
is not supported.
Its documented here:
https://opentracing-javascript.surge.sh/classes/span.html#addtags
I just plugged this library into our project and noticed that it raises an error when setTags is called with a tag not contained within opentracing etx/tags.ts. From my understanding of the open tracing docs, tags can be arbitrary string/any
pairs. Why the enforcement?
According to the spec all opentracing implementations are required to support the text_map
and binary
carrier format. This implementation seems to support only its internally-defined FORMAT_HTTP_HEADERS
format. It turns out this is good enough for me, but the value defined for this constant differs from that in the standard javascript library.
To avoid explicit dependencies on Zipkin in my application code, I'm using the constants defined in the reference library. For my purposes it would be sufficient if the value you define for this constant matches that in the standard library (http_headers
)
Thanks for the great work on this repo. Currently I use typescript, webpack and when using the lib it generates the two following warning.
WARNING in ./node_modules/zipkin/lib/InetAddress.js 62:23-30 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted @ ./node_modules/zipkin/lib/index.js @ ./node_modules/zipkin-javascript-opentracing/lib/index.js @ ./src/index.tsx
WARNING in ./node_modules/zipkin-transport-http/lib/HttpLogger.js 17:27-34 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted @ ./node_modules/zipkin-transport-http/lib/index.js @ ./node_modules/zipkin-javascript-opentracing/lib/index.js @ ./src/index.tsx
Everything seems working fine though, traces are sent to zipkin and no crash when running the app. Because there is no .d.ts contains I neeeded to do const ZipkinOpentracing = require('zipkin-javascript-opentracing')
instead of import ZipkinOpentracing from 'zipkin-javascript-opentracing'
. Not an expert and don't know if it will resolve the issue and make the warnings dissaper but I read a lot about webpack and errors with require().
Hi,
Method span.context()
from the OpenTracing API reference does not seem to be supported. Is there any plan on supporting it anytime soon ?
The goal ultimately is to use it to get the span's id and trace id through span.context().toSpanId()
and span.context().toTraceId()
. Is there maybe another way to get them ?
Thanks a lot,
Antoine
There is a type of span in zipkin that does not resemble a client request or a server request. We should therefore introduce the kind "local" to do this. The current implementation is documented here: openzipkin/zipkin-js#104
Hi,
In the Javascript API of OpenTracing, function followsFrom
allows to create a reference that can be passed as SpanOption
when starting a span.
However, in this repo, references
do not seem to be supported. Is there any plan on supporting them in the future ?
Thanks,
Antoine
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.