davekram / coord_transforms Goto Github PK

Hi there,

Thanks for making this crate! Would you be open to supporting f32's as well as just f64?

ie: https://docs.rs/coord_transforms/1.3.0/coord_transforms/d2/fn.cartesian2polar.html is hardcoded for f64.

Right now I'm doing a bunch of unnecessary casts because my engine uses f32's atm. I'm still learning rust, but if your knowledgeable about a good method for doing so (maybe something like rust's Into trait?) I would be happy to put together a PR, if your open to merging/discussing it.

Thanks!

Are there any plans to support these conversions?

this line in geo.rs let lambda0 = (((z - 1) * 6 - 180 + 3) as f64).to_radians(); fails for all UTM zones < 31

it should be let lambda0 = (((z as i32 - 1) * 6 - 180 + 3) as f64).to_radians(); or zone could be i32