denisoed / obsidian-orthography Goto Github PK

View Code? Open in Web Editor NEW

112.0 112.0 3.0 1.61 MB

The Obsidian plugin for checking grammar and correcting spelling errors in text.

License: MIT License

TypeScript 79.69% JavaScript 1.53% CSS 18.78%

obsidian-orthography's Introduction

Hello, I'm Denisoed!

My resume: https://denisoed.com

obsidian-orthography's People

Contributors

Stargazers

Watchers

Forkers

vidathd scottylectronica edgardleal

obsidian-orthography's Issues

WIP:editor.eachLine is not a function

Hi,

first of all I want to thank you for making this. I've been copy pasting things between Obsidian and Grammarly manually and can't wait to get it working inside the app itself.

However I get a following error in the console when I run the checks:

VM117:676 Uncaught (in promise) TypeError: editor.eachLine is not a function
    at OrthographyEditor.getColRow (eval at <anonymous> (app.js:1), <anonymous>:676:16)
    at OrthographyEditor.highlightWord (eval at <anonymous> (app.js:1), <anonymous>:640:27)
    at eval (eval at <anonymous> (app.js:1), <anonymous>:636:19)
    at Array.forEach (<anonymous>)
    at OrthographyEditor.highlightWords (eval at <anonymous> (app.js:1), <anonymous>:629:16)
    at OrthographyPlugin.eval (eval at <anonymous> (app.js:1), <anonymous>:871:41)
    at step (eval at <anonymous> (app.js:1), <anonymous>:68:23)
    at Object.eval [as next] (eval at <anonymous> (app.js:1), <anonymous>:49:53)
    at fulfilled (eval at <anonymous> (app.js:1), <anonymous>:39:58)

The popup is of course stuck on "Checking…" and nothing happens afterwards.

SYSTEM INFO:
	Obsidian version: v0.14.2
	Installer version: v0.13.23
	Operating system: Darwin Kernel Version 21.4.0: Mon Feb 21 20:35:58 PST 2022; root:xnu-8020.101.4~2/RELEASE_ARM64_T6000 21.4.0
	Login status: logged in
	Catalyst license: vip
	Insider build toggle: on
	Live preview: on
	Legacy editor: off
	Base theme: light
	Community theme: Primary
	Snippets enabled: 1
	Safe mode: off
	Plugins installed: 8
	Plugins enabled: 8
		1: System Dark Mode
		2: Sliding Panes (Andy's Mode)
		3: Dataview
		4: Kindle Highlights
		5: Style Settings
		6: Footnote Shortcut
		7: Advanced Tables
		8: Obsidian Orthography

plugin does nothing

hi denisoed extremely sorry to say but this plugin is not working i have tried both by using stor and also building by source but i doesnt work the button just keep spining,
looking forword for ur reponse

Extend the feature to Antidote

Hello,
May I ask if you could also extend this plugin for antidote (in addition to grammarly)?
https://www.antidote.info/en
https://antidote.readthedocs.io/en/stable/reference.html

Cant install from store

The version scheme of your release is wrong. See https://github.com/obsidianmd/obsidian-sample-plugin#releasing-new-releases
Just use 1.0.1

Click 'suggestion' doesn't points to text in doc

This is a very promising plugin that is already proving quite effective but I work with very long articles and see that once the plugin processes with suggestions — those suggestions are not clickable. Two ways to skin the cat would be to click and have the cursor point to the issue within the document. Or at least provide the line number. That way I can ensure that the issue was addressed.

Hopefully this isn't too difficult to implement.

New plugin name requirements

Hi @denisoed

Per our developer policies,
please ensure that your plugin's name does not include the word "Obsidian".
In addition, the plugin name should not include the word "Plugin", as that is unecessary duplication.
We have already modified the name of your plugin to "Orthography" in our records.

To maintain compliance, take the following actions:

Modify the manifest.json file in your plugin repository.
Generate a new release for your plugin to ensure users download the updated manifest.

If you have a idea for a different plugin name, you may also submit a pull request to the obsidianmd/obsidian-releases repository.

Thank you for your cooperation.
— the Obsidian team

WIP:Add integration to Grammarly

Variants:
Unofficial Grammarly API Client
https://github.com/stewartmcgown/grammarly-api

Problem with selection clicking

I quite like this plugin! When I first started using it, I really enjoyed being able to correct my (many) spelling mistakes in my notes. It's a much better option than Obsidian's Spell check. Though, in the last few weeks, the plugin just hasn't been working that well. Sometimes I'll turn it on, and when I click the selection, nothing happens. I do have a good amount of plugins installed, so this might be an issue on my end. If it helps, I've included a video of my console when I click to replace a word. Thanks!

Orthography.Plugin.Issue.mov

Orthography.in.Console.mov

Can't select translation

I love and hate this plugin right now. Usually the spell check works and underlines the misspelled words and correctly shows the dropdown for possible spellings. The problem is often clicking on the correct spelling does nothing. That said there are other times it does work correctly. It seems like it just breaks randomly and IDK what exactly is causing it.

I do run some custom css and plugins but turning them on and off as far as I can tell hasn't fixed the issue. That said If anything on my end is causing issue I would expect it to be other plugins or the version of obsidian I'm on.

Are these issues present for others or is it just me? What plugins if any do you think might interfere with this plugin.

I also had a thought that maybe it has something to do with the layout of windows and or linked windows. Is there any chance a weird mixture of windows could cause this issue. I generally have the following layout where all windows are on top of a backlinks window. the top leftmost is local graph and middle top is editing page, next is preview. All of them are linked. Then anything further to the right is unlinked pages but all are still on top of the backlinks panel.

[BUG] Can't close the window about plugin

Hi, thanks for you make the plugin.
I have a probrom when I use it.

I can't close the window about plugin.
What's wrong with it?

Do not deselect words when updating text

Steps for playback:

Insert text with spelling errors
Press the button in the bottom right corner or hotkey ctrl+shift+l
Selected words with spelling errors will appear.
Refresh the text

Result:

The highlighted words with spelling errors will be reset.

Expected result:

Highlighting words with spelling errors should not reset.

WIP:Stuck on "Checking"

After clicking on the icon and "Run orthography check", the popup is stuck on "Checking" state.
The icon is spinning and I can't close the popup with the X mark. I was able to get out of "Checking" state by clicking on the icon twice, but I can't close the popup and "Run orthograpy check" button is not responding.

The errors I'm getting in the developer console:

Uncaught TypeError: _this.activeEditor.on is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1), <anonymous>:759:48)
2main.ts:52 Uncaught TypeError: _this.activeEditor.off is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1), <anonymous>:757:52)
orthographyEditor.ts:99 Uncaught (in promise) TypeError: editor.eachLine is not a function
    at OrthographyEditor.getColRow (eval at <anonymous> (app.js:1), <anonymous>:656:16)
    at OrthographyEditor.highlightWord (eval at <anonymous> (app.js:1), <anonymous>:620:27)
    at eval (eval at <anonymous> (app.js:1), <anonymous>:616:19)
    at Array.forEach (<anonymous>)
    at OrthographyEditor.highlightWords (eval at <anonymous> (app.js:1), <anonymous>:609:16)
    at OrthographyPlugin.eval (eval at <anonymous> (app.js:1), <anonymous>:841:41)
    at step (eval at <anonymous> (app.js:1), <anonymous>:68:23)
    at Object.eval [as next] (eval at <anonymous> (app.js:1), <anonymous>:49:53)
    at fulfilled (eval at <anonymous> (app.js:1), <anonymous>:39:58)
main.ts:52 Uncaught TypeError: _this.activeEditor.off is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1), <anonymous>:757:52)
app.js:1 Uncaught TypeError: Cannot read property 'getAllMarks' of undefined
    at OrthographyPlugin.onPopupClose (eval at <anonymous> (app.js:1), <anonymous>:862:35)
    at e.tryTrigger (app.js:1)
    at e.trigger (app.js:1)
    at HTMLDivElement.OrthographyPopup.onClose (eval at <anonymous> (app.js:1), <anonymous>:470:24)
3main.ts:52 Uncaught TypeError: _this.activeEditor.off is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1), <anonymous>:757:52)
app.js:1 Uncaught TypeError: Cannot read property 'getAllMarks' of undefined
    at OrthographyPlugin.onPopupClose (eval at <anonymous> (app.js:1), <anonymous>:862:35)
    at e.tryTrigger (app.js:1)
    at e.trigger (app.js:1)
    at HTMLDivElement.OrthographyPopup.onClose (eval at <anonymous> (app.js:1), <anonymous>:470:24)
9main.ts:52 Uncaught TypeError: _this.activeEditor.off is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1), <anonymous>:757:52)
app.js:1 Uncaught TypeError: Cannot read property 'getAllMarks' of undefined
    at OrthographyPlugin.onPopupClose (eval at <anonymous> (app.js:1), <anonymous>:862:35)
    at e.tryTrigger (app.js:1)
    at e.trigger (app.js:1)
    at HTMLDivElement.OrthographyPopup.onClose (eval at <anonymous> (app.js:1), <anonymous>:470:24)
main.ts:52 Uncaught TypeError: _this.activeEditor.off is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1), <anonymous>:757:52)
app.js:1 Uncaught TypeError: Cannot read property 'getAllMarks' of undefined
    at OrthographyPlugin.onPopupClose (eval at <anonymous> (app.js:1), <anonymous>:862:35)
    at e.tryTrigger (app.js:1)
    at e.trigger (app.js:1)
    at HTMLButtonElement.OrthographyToggler.toggle (eval at <anonymous> (app.js:1), <anonymous>:546:32)
7main.ts:52 Uncaught TypeError: _this.activeEditor.off is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1), <anonymous>:757:52)
app.js:1 Uncaught TypeError: Cannot read property 'getAllMarks' of undefined
    at OrthographyPlugin.onPopupClose (eval at <anonymous> (app.js:1), <anonymous>:862:35)
    at e.tryTrigger (app.js:1)
    at e.trigger (app.js:1)
    at HTMLButtonElement.OrthographyToggler.toggle (eval at <anonymous> (app.js:1), <anonymous>:546:32)
2main.ts:52 Uncaught TypeError: _this.activeEditor.off is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1), <anonymous>:757:52)
app.js:1 Uncaught TypeError: Cannot read property 'getAllMarks' of undefined
    at OrthographyPlugin.onPopupClose (eval at <anonymous> (app.js:1), <anonymous>:862:35)
    at e.tryTrigger (app.js:1)
    at e.trigger (app.js:1)
    at HTMLButtonElement.OrthographyToggler.toggle (eval at <anonymous> (app.js:1), <anonymous>:546:32)
5main.ts:52 Uncaught TypeError: _this.activeEditor.off is not a function
    at HTMLDocument.eval (eval at <anonymous> (app.js:1), <anonymous>:757:52)

SYSTEM INFO:
	Obsidian version: v0.13.31
	Installer version: v0.12.19
	Operating system: #1-NixOS SMP Tue Feb 8 17:30:41 UTC 2022 5.10.99
	Login status: not logged in
	Insider build toggle: off
	Live preview: on
	Legacy editor: off
	Base theme: dark
	Community theme: none
	Snippets enabled: 4
	Safe mode: off
	Plugins installed: 17
	Plugins enabled: 14
		1: Tasks
		2: Hypothes.is
		3: Typewriter Scroll
		4: Remember cursor position
		5: Jump to link
		6: Emoji Toolbar
		7: Editor Syntax Highlight
		8: Advanced Appearance
		9: Advanced Tables
		10: Code Annotation
		11: Natural Language Dates
		12: Admonition
		13: Embedded Note Titles
		14: Obsidian Orthography

Change the way get the CodeMirror instance

Link obsidianmd/obsidian-releases#130

Unable to "correct a word mistake in one click," nor close the checking window

Denis, first of all, thank you so very much for the plugin. Grammarly not integrated into Obsidian is really a pain in the ass! Your work gives me hope of solving it. I work on Win 11 and the source mode as you suggest. The plugin works well for identifying the errors in the separate window, but when I click it, nothing changes in the text while the error disappears in the separate window. So, basically, no "Correct a word mistake in one click." I also have the problem mentioned in #17.

As one who also develops software, I know it takes time to fix bugs, especially for an open-source piece. So I would like to appreciate the attention and all the efforts to fix these problems ahead! Thank you again for contributing to integrating Grammarly into obsidian!