denniszielke / phoenix Goto Github PK

Hi Dennis,

in the build script, for example here:

There is no return of the docker build / docker push return code. When the docker build fails, the pipeline still passes, which leads to unexpected results when the deployment to kubernetes happens.

Should i do a pull request, or do you think it would make the example too complicated? Maybe just a comment about the problem in the code, so anybody using something like this in production cough would have less pain :D

This repo has been very helpful, thank you for that!

Documentation tip :
Could be good to describe one has to to define the artifact from the build def, when defining the release definition. Page is @ https://github.com/denniszielke/phoenix/blob/master/hints/TeamServicesToACI.md .
Might be confusing to newbies 😄 .

Currently there are instructions to create the rel. def. but you dont say the artifact produced from the build has to be used.

We tried to build a zero-downtime deployment with your nginx canary example.

While we test the whole thing, we found out, that between the following two commands the application is not available and the nginx responds with a 404 - not found.
Between this two commands there is no nginx config within the nginx.conf for the specific hosts.

helm delete $RELEASE --namespace $DEPLOY_NAMESPACE

|
| Downtime (404)
|

helm upgrade $RELEASE $AZURE_CONTAINER_REGISTRY_NAME/multicalculatorcanary --namespace $DEPLOY_NAMESPACE --install --set replicaCount=4 --set image.frontendTag=$BUILD_BUILDNUMBER --set image.backendTag=$BUILD_BUILDNUMBER --set image.repository=$AZURE_CONTAINER_REGISTRY_URL --set dependencies.useAppInsights=true --set dependencies.appInsightsSecretValue=$APPINSIGHTS_KEY --set dependencies.useAzureRedis=true --set dependencies.redisHostValue=$REDIS_HOST --set dependencies.redisKeyValue=$REDIS_AUTH --set slot=$CANARY_SLOT --set ingress.class=nginx --set ingress.host=$INGRESS_FQDN --set canary=false --wait --timeout 45s

|
| NGINX OK (200)
|

While creating the execution plan in Terraform from Azure CLI, it is not working. Attached screenshot below. Azdo Object ID is coming as Null