Giter VIP home page Giter VIP logo

shiori-android-client's Introduction

EhViewer
Shiori

GitHub Actions License Release Issues Commit Activity

Description

Shiori is an innovative bookmark management application that revolutionizes the way users save, organize, and access their favorite web pages. Built upon the robust Shiori platform, Shiori offers a seamless experience across all devices.

Screenshots

Screenshot 1 Screenshot 2 Screenshot 3 Screenshot 4
Screenshot 5 Screenshot 6 Screenshot 7 Screenshot 8

Features

  • Save Pages Easily: Instantly capture and access web pages at any time, even offline.
  • Superior Organization: Custom labels, descriptions, and thumbnails for efficient bookmark sorting.
  • Cloud Synchronization: Sync your bookmarks across all devices.
  • Intuitive Interface: User-friendly navigation for a seamless experience.

Technologies Used

Shiori is built using a variety of modern and robust technologies to ensure scalability, maintainability, and performance:

  • Clean Architecture: Ensuring separation of concerns and modular design.
  • Dependency Injection (DI): For managing dependencies effectively.
  • Model-View-ViewModel (MVVM): For a responsive and powerful user interface.
  • Use Cases: Defining clear business logic.
  • Repository Pattern: For efficient data handling and abstraction.
  • Protobuf (Proto): For efficient data serialization.

Download

Shiori is available for download on various platforms:

Get it on GitHub Get Shiori on Google Play Get Shiori on IzzyOnDroid Get it on F-Droid

License

This project is licensed under the Apache License - see the LICENSE file for details.

shiori-android-client's People

Contributors

desarrolloantonio avatar monirzadeh avatar

Stargazers

LUXUSFORMAT avatar  avatar  avatar  avatar Matt avatar Andre Kotake avatar Vasiliy Bukharev avatar  avatar  avatar Felipe Martin avatar Vishnu Sanal T avatar jdickman avatar qiufeng avatar Niraj D avatar Dario Vladović avatar Ert0v0 avatar  avatar Abhishek Nair avatar  avatar  avatar Vaibhav Malaviya avatar Marc Rentschler avatar SneakyMthrFckr avatar mwiu avatar  avatar Idan Shulman avatar Darkham avatar Moritz Ruth avatar ConfusedAlex avatar Stephen Karl Larroque avatar Matthias Hester avatar  avatar A.s. avatar  avatar  avatar  avatar  avatar erik lundstedt avatar Jules Amonith avatar Bruno avatar vdbhb59 avatar Daniel Intempesta avatar Six avatar Guillaume Michaud avatar  avatar  avatar  avatar  avatar Matthias Wichert avatar Tinker avatar Mudkip avatar  avatar Ethan Yoo avatar Super12138 avatar  avatar  avatar  avatar Temka avatar  avatar  avatar Yonas Yanfa avatar  avatar  avatar Tobias Strobel avatar  avatar _l2eused avatar  avatar  avatar David Duschek avatar Dhruvin Shah avatar  avatar ajd441 avatar  avatar Muntasim Fuad avatar William Marques avatar  avatar Silke Strandvogt avatar  avatar  avatar Arshid avatar Alexander Sekkas avatar  avatar Ralaud avatar  avatar Francois avatar Coool (github.com/Coool) avatar Nick avatar Bastian avatar RoestVrijStaal avatar AgentofPhoenix avatar  avatar Banana avatar  avatar Ahmed M. Ghazi avatar Phamous avatar  avatar  avatar ⭐ 🐾 avatar Lokesh Krishna avatar Mark F. avatar

Watchers

 avatar OpenApk avatar

shiori-android-client's Issues

Batch functionality

it can make things easier if we have batch option in app to user can add tags or delete, etc... in batch,
user can select with long press.

No bookmarks listed past the first page of Shiori

Bug Description
If I scroll to the bottom of the listed bookmarks on the main page of the app, it does not show any bookmarks beyond the ones listed on the first page in Shiori.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Go to the main page of the app
  2. Scroll to the bottom and notice the last bookmark
  3. Compare to the last bookmark of page 1 in Shiori

Expected Behavior
All bookmarks from Shiori should appear.

Device Information

  • Brand and Model: Pixel 7
  • Android Version: Android 14
  • App Version: 1.19.1

Bookmark Update Cache broken

As the title says, when you try to update cache for selected bookmark, it shows an error (Unknown error) and then the app logs out. This happening with the last 1.11 version. Server 1.6.0rc7

[feat] allow to filter tags as well

Hi, if we can filter the tags along with url search that would be great.
Use case is sometimes I like to search in tags and set filter based on that.

[Feature Request] Startup explanation with links to Shiori docs

When someone downloads PageKeeper, it just comes up with a connect and log-in window.
There should be explanation for how it works, explaining you need to host your own server and also linking to the Shiori documentation so people can know how to set it up.
There should also be a button in settings to allow already logged-in people to view the explanation again.

Shiori ignores user installed root certificates

Bug Description
I'm running the shiori server in my lan with a certificate of my own certificate authority. I install the root certificate in Android. I can verify this under Settings -> Security and privacy -> More security and privacy -> Encryption and Credentials -> Trusted credentials -> User. There is my root certificate listed. When I use chromium (on this Androiddevice) I can connect to my instance and the connection is shown green (secure).

But when I try to connect with shiori-android-client it says:

Error
java.security.cert.CertPathValidatorException: Trust anchor for certification path not found.

and I can't connect right after startup and fill in "Server url", "UserName" and "Password".

Steps to Reproduce
Use shiori-android-client with a installed root certificate of your own certificate authority.

Expected Behavior
shiori-android-client should connect to the server.

Device Information

  • Brand and Model:
  • Android Version: 14
  • App Version: 1.31

Hi. thanks to add option. i test that today and it work fine.

          Hi. thanks to add option. i test that today and it work fine.

maybe some small improvement can make it better too.

  1. check box Make archive publicly available maybe a little misleading something like Make bookmark publicly available could be more clear. that you know shiori make bookmark available that mean archive, readable version and ebook will be publicly available not jusr archive.
  2. i try to make that two option disable by default but i can't and each time i should tap on them. is it possible to add default settings for them to the settings menu so user can define default once there if user want change specific bookmark settings than can change them?(less tap each time)
  3. we can add automatically create ebook to the settings menu too? or add that to add bookmark page make things clutter? what do you think?

one more extra that i like know your view point
I like current adding menu. simple and pleasant specialty save Bookmark has prefect place for thumb . is it possible keep things simple like current setup but more reachable to the thumb? it make things clutter or complicated if just move things to the bottom of screen (without force user to tap more that need) but you have more experience than me in design android app.
i personally prefer current setup instead of make things complicated (if move things to the bottom of screen make things clutter or complicated or increase user tap)

dose it need a discussion in discussion section (repository currently don't have discussion section ) or a separate issue for better conclusion?

Originally posted by @Monirzadeh in #4 (comment)

First time run not follow theme settings in android

app theme not follow system them automatically. if you active dark mode in android than open app for first time PageKeeper open in light mode.
It can be good if we have 3 option (default Follow System Settings)

  • Follow system settings
  • Light Mode
  • Dark Mode

When logging out of your account, the database is not cleared

How to reproduce:

  1. Log in and load the list of articles.
  2. Log out of your account.
  3. Stop the Shiori server, delete (or rename) the database so that the next time it starts it will be empty.
  4. Launch the Shiori server.
  5. Log in to your account via PageKeeper.
  6. We see that a cached list of articles remains.

This may have potential security issues if the application user decides to change servers.

[FEATURE] iOS version

Is your feature request related to a problem? Please describe.
Hey, I tested the application in an old Android phone I had laying around and it's looking awesome, sadly my main device is an iPhone so I cannot enjoy it in my daily life (unless I carry a second phone, which is not what I do).

I checked and Kotlin seems to be cross-platform, so I'm wondering how much effort would it be having an iOS build of the application and maybe distributing it with something like altstore.

I'm opening this just to have the discussion here, if this is completely out of scope that's fine too. And of course I could help bringing this forward.

Describe the solution you'd like
The ideal solution would be to have an iOS build distributed by the App Store, but since that costs money, I'd say we can just start with having iOS build instructions on the documentation or even en ipa file on release if that can be automated.

Describe alternatives you've considered
n/a

Additional context
n/a

Potential UI/UX Design Sketches
n/a

[feat] longer/permanent login session

Thank you dor the great app. I have one suggestion for the login session. If possible, can login session be a longer/permanent?

It is keep experience and if try to share link with past logged in session, pressing save bookmark does nothing. To fix that you have to open the app manually l, click on session expired message and then login again. Only after that if any link shared would work.

Screenshot_20240228-060716

you can't do some of action in offline mode

if you in offline mode and try to remove a bookmark you will get error and back to login page
it can be better that it remove from bookmark list in app and if it can't connect to the server keep it in the Queue . next time user connect and has accesses to the server send that delete (or edit or anything else) request to the server.
(maybe an undo option if app not send request yet)

New with a dumb question

Hi! I'm new in the app and this is probably the dumbest question I would do: where do I have to create an account to use the app?

infinit loading

if you add bookmark in pagekeeper and than delete that(not bookmark remain in shiori) an infinit loading happen.
you should just close app and open that to things back to normal

[FEATURE] Use completely offline on Android without an account

Is your feature request related to a problem? Please describe.
I don't know how to create a self-hosted account, I don't have any PC running 24/7 to act as a host.

Describe the solution you'd like
We could go direct to the app and all is completely bookmarked in Android's memory, no need to worry about account and other annoying things.

[FEATURE] Close the interface if bookmark saving was successful.

Is your feature request related to a problem? Please describe.
After pressing save to add a bookmark to the server, the user receives a success dialog. Upon closing that dialog, the previous view remains open to add the bookmark (even though it was already added). This is a lot of unneeded friction to use the application.

Describe the solution you'd like
Upon pressing save, if the transaction is successful, the user should be brought back to their previous application automatically, and there should be no dialog shown. You only need to show popup dialogs for exceptions or failures. This would lead to a much smoother user experience.

Readable version

it can be good if app will show readable version of bookmarks too.

[FEATURE] After login error, have button to go straight to the login screen

Is your feature request related to a problem? Please describe.
A problem relating to the share to PageKeeper functionality. If the session has been reset and the login has error, one presses 'save' then gets a pop-up error. Pressing accept from that screen quits the dialog and then one has to manually open the app again.

Describe the solution you'd like
On that pop-up error, instead of just having 'accept', there should also be a button 'go to login' which opens the login screen.

Describe alternatives you've considered
It's an inconvenience, but currently I just manually open the app.

Additional context
n/a

Potential UI/UX Design Sketches

| ----------------------------------------- |
|        session expired error              |
|                                           |
|  Go to login                    Accept    |
| ----------------------------------------- |

Those bottom bits being buttons, and of course there is still the detailed info in the middle.

[Feature Request] Compact View

Thank you so much for creating such a gorgeous app!
Could you consider a compact view, that drops the images? Would be nice to be able to view more links at once.

[FEATURE] Show URL after it has been shared to PageKeeper

Is your feature request related to a problem? Please describe.
I get annoyed when I am bulk sharing a lot of bookmarks to Shiori/PageKeeper, and adding tags, and then I forget what it is for and have to re-do a specific one.

Describe the solution you'd like
When a URL is shared to the app, at the top of that UI it should display the URL. As a bonus, it could be a text field and allow the user to tweak the URL before adding it, e.g. removing UTM trackers.

Describe alternatives you've considered
I have to exit the dialog, find the one I was up to and then re-share it once I know what tags I want to put on it.

Additional context
I see that recent versions have updated the 'add' screen, so hopefully this will be considered.

Potential UI/UX Design Sketches
Right below the Add title, there should be a box where the URL is displayed.

Log in 404 error

20240217_imgpipe_0

Log in with pagekeeper gives this error.

Log in is working fine via regular browser.

[BUG] Not all tags automatically load from web instance of Shiori

Bug Description
If I open the android app and click on the filter icon at the top right, not all the tags show up in the slide-up card.

However, if I scroll through all the bookmarks before selecting the filter, then all the tags show up.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Close the app
  2. Open the app and immediately tap the filter button in the top right-hand corner.
  3. Observe that not all the tags show up.
  4. Now close the filter and scroll to the bottom of all the bookmarks
  5. Open up the filter again and you will see all of the tags appear

Expected Behavior
All the tags should appear when tapping the filter button, without needing to scroll through all the bookmarks.

Screenshots
Screenshot_20240506-133052

Device Information

  • Brand and Model: Pixel 7
  • Android Version: Android 14
  • App Version: 1.30

Additional Context

[BUG] Error Opening URL into other apps (not browser)

Bug Description
Hi, I'm having an issue and Android where certain links that have a scheme to open in a specific app (GitHub link into the GitHub app for example) will just show "Error Opening URL". This also notably happens in the Settings of the app under "Server Settings Guide" (which I believe is a link to GitHub)

Steps to Reproduce
Steps to reproduce the behavior:

  1. Add a GitHub link to PageKeeper
  2. Ensure GitHub app can open supported links on Android through the settings
  3. Click on the link through pagekeeper
  4. See error "Error opening URL"

Expected Behavior
The link opens the related app instead of showing an error. Or at least opens in browser.

Screenshots
photo_2024-04-20 09 57 40
photo_2024-04-20 09 57 45

Device Information

  • Brand and Model: Google Pixel 6a
  • Android Version: 14
  • App Version: 1.2.0

Additional Context
App is great! Thanks for the work on it.

Migrate to new API

as you can see shiori most of the API change in next release it can be helpful if we make app ready for that (for example another branch) and merge that after next stable release be ready.

Share menu

please give an option to use add links to the shiori from share menu in android

Thumbnail not show in app

app not show thumbnail of bookmarks.
in screenshot it is work but in my test not working. is it a bug or this feature not merge yet?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.