dgraph-io / hugo-dgraph-theme Goto Github PK

Hello,

Your recent commit e903176 broke the Dgraph theme demo at https://themes.gohugo.io/hugo-dgraph-theme/

Basically the problem is the hardcoded PATH i.e. readFile "themes/hugo-dgraph-theme/static/js/runnable.js" that throws a 404 on the theme site.

A theme should not have hardcoded PATHs since it may be used in different architectures like the one that is used in the Themes Showcase.

Please note that we offer instructions about testing a theme demo locally with the Hugo Themes website Build Script

Also note that once gohugoio/hugoThemes#668 is addressed you will need to keep an eye on whether the Dgraph theme demo generates on the Hugo website.

We are a very small team and we just cannot keep up opening issues in the various theme repositories. Whenever a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning.

Thank you.

cc: @digitalcraftsman

Hello @paulftw

I am one of the maintainers of the Hugo Themes repository.

In commit cb69c26 you deleted the exampleSite of your theme and as a result your theme demo no longer generates.

If you no longer wish to have an exampleSite then you need to test your theme with the HugoBasicExample

ref: gohugoio/hugoThemes#531

cc: @digitalcraftsman

Hello @paulftw

I noticed that you updated the theme's images recently.

However now the screenshot has the wrong dimensions, it should be 1500×1000 in pixels. Also it should feature only the theme's layout (not the browser chrome) and it shouldn't have transparency.

For future reference please use the Hugo Themes README

Can you please fix the screenshot's dimensions?

Thanks

There is no option for searching the blogs for a required post. Could you please add this feature.?

Cloned this theme today, exampleSite directory doesn't build a working site with the hugo command.