Giter VIP home page Giter VIP logo

Comments (8)

AOx0 avatar AOx0 commented on June 12, 2024 1

Oh, I see it now. I'm looking into it.

Edit. If you get a working branch make a PR targeting branch v0.39.1-dev

from digital-logic-sim-ce.

AOx0 avatar AOx0 commented on June 12, 2024

It should be disabled for groups, and enabled for single pins.
Does it work for single pins?

from digital-logic-sim-ce.

AOx0 avatar AOx0 commented on June 12, 2024

NVM, I see the problem. Thanks for the feedback :/

from digital-logic-sim-ce.

crispeeweevile avatar crispeeweevile commented on June 12, 2024

NVM, I see the problem. Thanks for the feedback :/

Thanks for getting back to me so quickly :) Hopefully it will be a really quick solution without much to do.

from digital-logic-sim-ce.

AOx0 avatar AOx0 commented on June 12, 2024

@VitoBarra I think tracked down the issue to commit c2dbe38 in file Assets/Scripts/Interaction/ChipInterfaceEditor.cs

Here:

-        if (selectedSignals.Count == 0)
+        if (IsSomethingSelected)

IsSomethingSelected (always?) returns early

if (IsSomethingSelected)
return;

I think it should be:

-        if (IsSomethingSelected)
+        if (!IsSomethingSelected)

Any comments? So I can commit the fix on branch v0.39.1-dev

Edit: Wrong file link, updated it

from digital-logic-sim-ce.

VitoBarra avatar VitoBarra commented on June 12, 2024

yes that definitely is a correct fix, but I’m testing it and even so it seems not to work.
I’m trying to find out what’s going on.

I think it is just a visualization problem now

from digital-logic-sim-ce.

AOx0 avatar AOx0 commented on June 12, 2024

Hm, it does work fine for me with 87e367c. By fine I mean now wires do connect to same Pin types, both out and in

Screenshot 2022-12-04 at 9 38 46 p m

Screenshot 2022-12-04 at 9 41 20 p m

from digital-logic-sim-ce.

VitoBarra avatar VitoBarra commented on June 12, 2024

yep, that works for me too. I was referring to the fact that if you change the wire type and then try to edit again it will show as it is still simple, I don't know if it was the case also earlier tho

from digital-logic-sim-ce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.