I'd like to contribute to the overall usage documentation. @grahammiln I'd like start documenting things over in the github wiki -- you ok with that? I was thinking use that as a draft/adhoc place before moving it into the "official" documentation (under DrawKit/Documentation). It's also easier to contribute to the wiki with a lower barrier to entry overall.

When you draw a shape with Bezier Pen, the path is open at the end. It would be better to close the path when you bring the mouse to the starting point, because all vector illustration software has this feature. Bezier pen is supposed to work like this. Is there any way to add this feature?

Hello

I want to load styles from .styles file when button is clicked, but the result is nothing. Here is my code, can you help me to find my errors please?

NSString *path = @"/Users/Mediajon/Documents/colors.styles";    
[[DKStyleRegistry sharedStyleRegistry] readFromFile:path mergeOptions:kDKReplaceExistingStyles     mergeDelegate:self];

Thanks

Question: Is there a better way to set an NSAttributedString on a DKTextShape?

Background & Code:

I was trying to implement strikethrough via the following:

    let strokeEffect: [NSAttributedStringKey : Any] = [
      NSAttributedStringKey.strikethroughStyle: NSUnderlineStyle.styleSingle.rawValue,
      NSAttributedStringKey.strikethroughColor: NSColor.black,
    ]

    if let textShape = selectedObject as? DKTextShape {
      let text = textShape.string
      let newStrokeString = NSAttributedString(string: text, attributes: strokeEffect)
      selectedObject?.setOriginalText(newStrokeString)
    }

via debugging, it's definitely getting into selectedObject?.setOriginalText(newStrokeString) and is getting into [self setMetadataItem:[DKMetadataItem metadataItemWithAttributedString:text] forKey:kDKPrivateShapeOriginalText]; (see below for reference)

however it doesn't seem like the attribute string is getting applied.

- (void)setOriginalText:(NSAttributedString*)text
{
#if USE_107_OR_LATER_SCHEMA
	[self setMetadataItem:[DKMetadataItem metadataItemWithAttributedString:text]
				   forKey:kDKPrivateShapeOriginalText];
#else
	[self setMetadataObject:text
					 forKey:kDKPrivateShapeOriginalText];
#endif
}

I can not find the implementation of DKSecretSelectorsDrawingLayer, exist or I need work on them to implement.

I'm getting a black rendering for my view on something that was previously working after upgrading to:

• Xcode 10 (app store version)
• Mojave
• Swift 4.2

I'm downloading Xcode 9.4.1 to see if that's the issue and am going to step through it.

Anyone else seeing this?

I'm trying to figure out which notification fires for when the selected object changes? It doesn't seem to be kDKDrawableSubselectionChangedNotification.

Example:

1. Draw 2 rectangles A & B
2. select A
   Expect to receive a notification that a selection was made. I've got kDKDrawableDoubleClickNotification working correctly but essentially I'm looking for "kDKDrawableClickNotification"

Hello

How can we add shift key to the tool shortcuts? For example we want to make Rectangle Tool with Shift+R keys, what key code should be changed?

Thanks

Hello

What is the best way to add sag support to this framework?

Thanks

In GCZoomView.m

• (void)scrollWheel:(NSEvent*)theEvent

  CGFloat deltaX = [theEvent deltaX], deltaY = [theEvent deltaY], deltaZ = [theEvent deltaZ];

  double totalDelta = deltaX + deltaY + deltaZ;
  //printf( "deltaX %f deltaY %f deltaZ %f totalDelta %f", deltaX, deltaY, deltaZ, totalDelta );
  //NSLog( @"%@", [event description] );
  if ( totalDelta == 0 )
  return; // this is the indication that a trackpad gesture has 'finished'... on the iphone, i think it means 'stop animate scroll now'

diff --git a/framework/Code/GCZoomView.m b/framework/Code/GCZoomView.m
index e78be1c..ef81021 100644
--- a/framework/Code/GCZoomView.m
+++ b/framework/Code/GCZoomView.m
@@ -421,12 +421,20 @@ NSString* kDKDrawingScrollwheelSensePrefsKey = @"kDKDrawingcrollwheelSense"; //
// to what you might think. It's more intuitive if the centre point remains constant

            NSPoint p = [self centredPointInDocView];

- CGFloat delta = [theEvent deltaY];

•           //CGFloat delta = [theEvent deltaY];
  

•  CGFloat deltaX = [theEvent deltaX], deltaY = [theEvent deltaY], deltaZ = [theEvent deltaZ];
  

•  double totalDelta = deltaX + deltaY + deltaZ;
  

•  //printf( "deltaX %f deltaY %f deltaZ %f totalDelta %f", deltaX, deltaY, deltaZ, totalDelta );
  

•  //NSLog( @"%@", [event description] );
  

•  if ( totalDelta == 0 )
  

•     return; // i think this is the indication that a trackpad gesture has 'finished'... on the iphone, i think it means 'stop animate scroll now'
  

•  // [GCZoomView setScrollwheelInverted:YES];
          if ([[self class] scrollwheelInverted])
  

•                   delta = -delta;
  

•                   totalDelta = -totalDelta;
  

•           [self zoomWithScrollWheelDelta:delta
  

•           [self zoomWithScrollWheelDelta:totalDelta
                                           toCentrePoint:p];
  } else
          [super scrollWheel:theEvent];
  

I'm wondering what the status of the project is. I have forked it and am working on upgrading it to be ARC compliant.

Anyone else interested?

I tried using the library in a swift project and converting the example project DK Mini Demo to swift. I'm running into a few errors. The first is Value of type 'DKDrawingView' has no member 'selectDrawingTool'. Looks like the way the obj-c code is written, those methods appear private. Attached is the project.
DrawingView.zip

Using a text shape and increasing the size of the font after the shape to a high value is hiding a part of the text.
Using GCDrawDemo, I have added two text shapes on the image below, first has font size 48, second has the default one:

Is there a way we can have the text shape resized automatically on font change?

I am aware of concerns regarding the LGPL licence and its use within the Mac App Store. In particular the concerns about using LGPL where DRM protections are used.

Given these concerns, I intend to switch DrawKit's licence to a more permissive licence. My main objective is to ensure the continued protection for those contributing to the project and to ensure the project remains open.

I am considering moving to Mozilla Public License v2:

• https://www.mozilla.org/MPL/2.0/
• https://en.wikipedia.org/wiki/Mozilla_Public_License

Hi -

This is an integration issue with Cocoa, not an issue within DrawKit (afaict).

If I do the following - it works 👍🏽

1. create a new app Cocoa app (Xcode 9.3), add DKDrawKit + DrawSwift files
2. drag a customview over into the ViewController, set the class on the customview to DKDrawingView
3. run

Result = a window with the grid displayed from DKDrawingView (good!)

If I do the following, it displays a black screen 👎

Repeat steps 1 & 2
3. Drag out a TabViewController and rewire the Window to display the TabViewController
4. Place the default ViewController (with the DKDrawingView in it) into the TabViewController

Result = the tab view displays a render area of the right size, but it's rendering a black box.

I'm assuming this issue has to do with layer setup and the fact that it's now in a containing view?

Machine: mac 10.15.3
Xcode: 11.3.1

Summary: Anyone else seeing issues with DnD for images in DrawKit, post catalina/xcode11?

I started seeing this bug crop up recently with drag-n-drop operations, specifically once I a place an image on a DKDrawingView and start dragging it around.

Using default DrawKit primitives (box, line, etc.) does not produce this issue.

I have to set the environment variable "CG_CONTEXT_SHOW_BACKTRACE" to produce the stack trace below. Afaict, everything still seems to work properly.

It happens regardless if it's in a DKShapeGroup.

Image is loaded as a literal from an asset catalog, as a universal PDF.

Stacktrace:

2020-02-17 09:56:15.559928-0700 MyApp[49217:5498717] [com.myapp.myapp] CGContextSetCTM: invalid context 0x0. Backtrace:
<-[NSImageRep drawInRect:]+505>
 <-[NSImageRep CGImageForProposedRect:context:hints:]+325>
  <__74-[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke+910>
   <-[NSImageRep drawInRect:fromRect:operation:fraction:respectFlipped:hints:]+946>
    <__71-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:]_block_invoke.1343+693>
     <-[NSImage _usingBestRepresentationForRect:context:hints:body:]+145>
      <-[NSImage drawInRect:fromRect:operation:fraction:respectFlipped:hints:]+1343>
       <-[DKImageShape drawImage]+579>
        <-[DKImageShape drawContent]+192>
         <-[DKDrawableObject drawContentWithSelectedState:]+189>
          <-[DKShapeGroup drawGroupContent]+400>
           <-[DKShapeGroup drawContent]+118>
            <-[DKDrawableObject drawContentInRect:fromRect:withStyle:]+657>
             <-[DKDrawableObject rectHitsPath:]+636>
              <-[DKDrawableObject pointHitsPath:]+156>
               <-[DKDrawableShape hitSelectedPart:forSnapDetection:]+555>
                <-[DKObjectOwnerLayer snapPoint:toAnyObjectExcept:snapTolerance:]+344>
                 <-[DKObjectOwnerLayer snappedMousePoint:forObject:withControlFlag:]+148>
                  <-[DKDrawableObject snappedMousePoint:withControlFlag:]+155>
                   <-[DKDrawablePath lineCreateLoop:]+818>
                    <-[DKDrawablePath mouseDownAtPoint:inPart:event:]+380>
                     <-[DKObjectCreationTool mouseDownAtPoint:targetObject:layer:event:delegate:]+690>
                      <-[DKToolController mouseDown:]+633>
                       <-[DKDrawingView mouseDown:]+112>
                        <$s13MyApp17CanvasDrawingViewC9mouseDown4withySo7NSEventC_tF+64>
                         <$s13MyApp17CanvasDrawingViewC9mouseDown4withySo7NSEventC_tFTo+47>
                          <-[NSWindow(NSEventRouting) _handleMouseDownEvent:isDelayedEvent:]+4907>
                           <-[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:]+2612>
                            <-[NSWindow(NSEventRouting) sendEvent:]+349>
                             <-[NSApplication(NSEvent) sendEvent:]+352>
                              <-[NSApplication run]+707>
                               <NSApplicationMain+777>

Instigating an NSScrollView embedded DKDrawingView from a NIB results in an empty window.

Problem

With Interface Builder:

1. Create a new NSWindow containing a NSScrollView.
2. Set the scrollview's document view to a DKDrawingView.
3. Run the application.

The window should contain a scrollview with a default DrawKit showing a grid.

Remove the NSScrollView and the DKDrawingView works as expected.

Work Around

1. Create a new NSWindow containing a NSScrollView.
2. Within the NSWindowController class, instigate the DKDrawingView programmatically and insert into the scrollview:

- (void)awakeFromNib
{
    self.drawingView = [[DKDrawingView alloc] initWithFrame:NSZeroRect];
    [self.scrollView setDocumentView:self.drawingView];

    self.drawing = [DKDrawing defaultDrawingWithSize:[DKDrawing isoA3PaperSize:NO]];
    self.drawingController = [[DKToolController alloc] initWithView:self.drawingView];
    [self.drawing addController:self.drawingController];

    [super awakeFromNib];
}

Notes

This behaviour suggests the DrawKit code handles NIB created views differently from programmatically created views.

DrawKit contains GPL licensed code within the framework/ThirdParty folder.

This code appeared in the original DrawKit archive. The code is optionally compiled into DrawKit using compile time preprocessor macros.

As the code is not essential to DrawKit, any GPL code should be migrated to other repositories or removed. This will simplify licensing.

Need to document how to get and use clang-format. See http://nacho4d-nacho4d.blogspot.fr/2013/11/clang-format.html

# Download
$ curl -O http://llvm.org/releases/3.4.2/clang+llvm-3.4.2-x86_64-apple-darwin10.9.xz
# Decompress
$ tar xvfJ clang+llvm-3.4.2-x86_64-apple-darwin10.9.xz 
# Locate clang-format
$ ./clang+llvm-3.4.2-x86_64-apple-darwin10.9/bin/clang-format --help

How can i access and resize an image that was dragged into DKDrawingView. I need to resize the image to fit the view. The functionality i'm looking for can be found in the GCDrawDemo, the object inspector window

//get the layer the current image is at
let obj = canvasDrawing.objectInLayers(at: 1)
//bitmaprepresentation of that image
let bitmaprep = obj.bitmapRepresentation(withDPI: 350)
 let nsImg =  NSImage.init(cgImage:  (bitmaprep.cgImage)!, size: NSSize.init(width: 3000.0, height: 1200))

right now this produces an image thats cropped to fit the DKDrawingView canvas

I really like Carthage over Cocoapods. Any chance you could add support for Carthage? I like that it leaves my project files alone.

Hi

When converting text into Shape Group, line which is below is going top and top line is going to bottom as attached image.

Thanks

The DrawKit is very good framework.

I think it will be awesome if there are a simple demo. ：）

Zooming and panning a DKDrawingView on a non retina display is very smooth. When on retina display the zoom/pan is very choppy and unresponsive. An objectDrawingLayer with no DkDrawableObjects does not behave this way, so the issues seems to be pointing at DKDrawabaleShapes or maybe DKRasterizer? I try setting NSGraphicsContext imageInterpolation to low in DKImageAdornment but still receive same behavior

Is SVG supported now (2018)? I saw a note from 2014 that said that PDF is supported and go that route or make your own converter. I'm assuming that's still the case but wanted to clarify.

I'm porting the legacy mini demo to xcode9/swift 4/storyboards and everything builds. However, I'm getting hit with the assert that the undo manager hasn't been setup yet .

I've got the DKUndoManager singleton created in the default ViewController.

Where's the recommended place to assign it prior to calling createAutomaticDrawing() ?

I am looking for help maintaining DrawKit.

• If you have modifications or changes you want merged in...
• You use DrawKit for your projects and want to help safe-guard this framework…
• You want to help with DrawKit…

…please get in touch by leaving a comment here.

Is it possible to make each shape object separate layer?

Hello Everyone

Double clicking text shape or Edit Text functions are not working. Does anyone have a solution for this issue?