Giter VIP home page Giter VIP logo

Comments (3)

bryopsida avatar bryopsida commented on June 25, 2024 1

@rohanKanojia yes, I was planning on taking this on as well.

from jkube.

rohanKanojia avatar rohanKanojia commented on June 25, 2024

@bryopsida : I see you've got a PR related to helm open. Do you plan to work on this as well? Shall I assign it to you?

from jkube.

manusa avatar manusa commented on June 25, 2024

I can't really find a reason as to why we're transforming the parameter names to lower-case.

The only reason I can think of is to make them case-insensitive.

The change was added as part of #116 when the Helm logic was extracted from the Mojo to a separate module in JKube Kit.

Fabric8 Maven Plugin's original code doesn't include any case transformation either:

https://github.com/fabric8io/fabric8-maven-plugin/blob/89af88323fa685d8b298ba4b2cbc415b9b2911f0/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/HelmMojo.java#L682-L684

In conclusion, I think it's safe to preserve the case-sensitivity and I don't really see the need for adding an additional flag. I'll refactor #2369 accordingly.

from jkube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.