Fix unit tests failing in `jkube-kit/enricher/api` module on Windows about jkube HOT 3 CLOSED

@rohanKanojia: I'm ready to work on this issue too. I'm not sure if I can self assign issue or not. Could you please help me out with this?

from jkube.

@manusa / @rohanKanojia, This issue is occurring due to the use of Line Feed instead of the platform specific line separator in the last test i.e. metadataVisit_whenMultilineAnnotationProvided_shouldAddTrailingNewline()

Here, while adding multiline configuration to properties we are using line feed instead of using the platform specific line separator.

Due to which when MetaDataVisitor.appendTrailingNewLineIfMultiline(String value) is invoked it doesn't enter the if block.

We can fix this issue by:

Replacing:

"proxyMetadata:\n ISTIO_META_DNS_CAPTURE: \"false\"\nholdUntilProxyStarts: true"

With:

String.format("proxyMetadata:%n ISTIO_META_DNS_CAPTURE: \"false\"%nholdUntilProxyStarts: true")

This fixes the issue, Could you please check it once and let me know if it's alright to raise PR?

from jkube.

@l3002 : Yes, please go ahead.

from jkube.