GitUtil : Remove redundant null check for `gitFolder` in `getGitRepository` method about jkube HOT 9 CLOSED

@rohanKanojia can i pick this up?

from jkube.

@rohanKanojia this null check is needed , consider when you dont have currDir then you create it as new File(System.getProperty("basedir", ".")) by default then here this parameter is not at all needed, and if in case its null and we dont create default we will end up with NPE on line 53 while we try to find gitfolder without checking null in first place.

so its always good to do defensive programming and its better to validate all preconditions here, let me know what do you think about it?

from jkube.

Hi @rohanKanojia I can help with this issue. :p

from jkube.

@clarenced : Thanks, please see Marc's comment #2711 (comment) for idea of what needs to be done.

from jkube.

After some investigation, the method GitUtil.getGitRepository is called in 2 places :

from GItEnricher (L 54)

try (Repository repository = GitUtil.getGitRepository(getContext().getProjectDirectory())) {
 ...
}

and also from BaseGenerator (L272)

Repository repository = GitUtil.getGitRepository(project.getBaseDirectory());

Is there any situation where project.getBaseDirectory() or getContext().getProjectDirectory() can return null ? If it's not the case, we can safely remove the null-check.

from jkube.

its always good to do defensive programming and its better to validate all preconditions here

You're right about this. This might be an issue if this utility class is used by users using jkube-kit as a direct dependency. However, at the moment I'm not sure there are users are using jkube-kit as a direct dependency. In our codebase we use it only in two places, JavaProject's base directory seems to be set always from maven and gradle plugin apis.

from jkube.

However, at the moment I'm not sure there are users are using jkube-kit as a direct dependency.

Then we might want to throw an exception instead. Objects.requireNonNull or something like that.

from jkube.

@manusa yes that would be the ideal way. ok will raise an PR

from jkube.

@ajayl83 : polite ping, are you still working on this? If not, could you please unassign?

from jkube.