SecretEnricher : Use primitive `int` instead of `Integer` in for loop about jkube HOT 6 CLOSED

Hello,
Could you please assign it to me?

from jkube.

On closer inspection, we can replace the loop using Java Stream API. Using Map doesn't seem to be relevant here. We should replace it with Set instead:

Set<String> secretNamesPresentInBuilder = builder.buildItems().stream()
            .filter(Secret.class::isInstance)
            .map(HasMetadata::getMetadata)
            .map(ObjectMeta::getName)
            .collect(Collectors.toSet());

then use secretNamesPresentInBuilder.contains here:

https://github.com/eclipse/jkube/blob/3afc7bf1f8dbe4452826c5ec7ec58de5c9408d53/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/SecretEnricher.java#L126

from jkube.

@arsenalzp : I see DockerRegistrySecretEnricher which is extending this class. There is a test for DockerRegistrySecretEnricherTest. Could you please check if it's testing only Docker Registry Secret related logic or also base class.

Anyway, I don't think there is any harm in adding test for SecretEnricher. Please create a new issue for the proposal, I'll assign it to you.

from jkube.

Should I write a test for this class, because test SecretEnricherTest doesn't exist?

from jkube.

@arsenalzp : This is an abstract class. Are there unit tests for classes extending this class?

from jkube.

@arsenalzp : This is an abstract class. Are there unit tests for classes extending this class?

I saw a unit test for ConfigMap enricher, so it does make sense to do the same test for Secret one. It is just a proposal :)

from jkube.