Giter VIP home page Giter VIP logo

Comments (2)

TomHAnderson avatar TomHAnderson commented on June 3, 2024

A PSR-14 event manager would be great e.g. https://github.com/phossa2/event

from graphql-doctrine.

PowerKiKi avatar PowerKiKi commented on June 3, 2024

I am not very keen on introducing events in this project. First of all I think events can be hard to use, because it is not always clear when and in what order they happen.

But most importantly we are on a very tight schedule with an internal project that heavily rely on this lib. And we must be able to move quickly and easily with whatever requirements we might have in the near future. For this reason we cannot afford to significantly increase the maintenance cost of this lib (with more complex code and wider API surface), if it does not answer a direct need for our internal project.

That also means non-annotation is out-of-scope for the time being. If you need a custom hydrator, then you can compose, or write from scratch, a DefaultFieldResolver. But if you need a custom type factory, then I'm afraid, you are on your own for the time being.

What we maybe could do is refactor getRecursiveClassAnnotations() and getClassAnnotation() into an interface and you could provide your own implementation that do whatever you need them to do (read from XML files).

But honestly I am not sure if it's worth the effort on your part (and mine). This lib has its own set of annotations and will never directly access Doctrine annotations, instead it will use the available ClassMetadata. So the fact that you do not use annotation for Doctrine entities should not prevent you from using annotations for this lib.

from graphql-doctrine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.